From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A853313546 for ; Sat, 13 Jun 2026 06:17:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781331434; cv=none; b=S7jEAi/RE27HsgVYGwTisxk+X2hRRUnwZ89UP8cd4CIJ1JOWKmumKcri4nA7vhBk4qTeUfv+kczZhPV/Zo1o3lN3aQGFp1j3aq/vCCk/6gbQpO3FEswvKjnRaT5jmTF/HU6cfXMmk1FyWvJkR3P3xPy30ZZ9upH0CH7TV8Wvy6E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781331434; c=relaxed/simple; bh=IDfj46W7vKL/Gr+E9OsZVvwB3Rdme4iy8oJeC3brNdY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HD1J6PLJ6lSwLuDpzNbDI7mgZu3X/kqZAcLD8/I5MDVP68kdlQLFwdRYqWq3j1Sf94PNO2B5PnLqNcnmhMWjDe0WQngQA/3AMKmQR+gOfmzi+qQ1XxFoOu8kYxqXxLiJMEwDBU4MS+8vCIsgGMqVJ8oqE7lMHIf9C5u/HXU9wWM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=J3m1d8Wd; arc=none smtp.client-ip=209.85.219.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J3m1d8Wd" Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-8ccedaf0b54so12243336d6.0 for ; Fri, 12 Jun 2026 23:17:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781331432; x=1781936232; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1p3BAGZnV1gRRVE0W3J1YkAbfp6JIr+wulrSf/UbmkE=; b=J3m1d8Wd97PnF96ZCKY7qNAqxi7UAvXkrSXbBnPErUbzZBBdP04QC8GvcGQXc0deye TRnCrJ9BTVyRiQUOX+hjg/er2hmTtmPKmK6hUNu1B9PXSgrOsIgkE1YOPHwDkehTUURA 3nCDgQjj12VxJpX2/Mg61dDG3OGm6myQgmQL4bvSaDaec9ihlIl3Ku5xkqjf6u/F2+Lm 7NRe9oxD3QU3SiIRVeMs0Sw+npxr/aeKVG5mQcQOWnVwvppuUWfJreXCS3LeFLgEhffM KiwGhlP2/NKQasTxMvb/oj3t4gk1OeL5TzqnTNdHopssopJMGiTjffTXHNEcK/0KhTDN VVaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781331432; x=1781936232; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1p3BAGZnV1gRRVE0W3J1YkAbfp6JIr+wulrSf/UbmkE=; b=J9Jo7+MEU0YfJJkk0dukgZYa0UOw+zTZfsQFZwWIIIX2tvMuTYDrSNNZQP47kUMgCH jSzl+Eo7W/EOiDoYXxgKVthUjtTbTskEpyyKVJh/3rN8qpK/DcvyZwFaURYrqm4EiOO5 +nJ+VSNOuDdESRyayrT5xjNrYjKNHD0WsgGwk4N36hs+K/v9lm28e5YPi5V4Ls6/2VAi PCPFe8r+6OPEtGVGBFL8+u3QpIvukd6GGVp8HnCrqR72LMGe4QJXhhiHBTN2A7muRtFa aACF+R5wnmZ3HEBWaQLpVaAeryjmZNTXAlGvw+Ue15ZtRe01w2zTktd8I6R7Exc4QNpl 02iw== X-Forwarded-Encrypted: i=1; AFNElJ/T7BI1yknu/Zx7ZLZya/674K2bXsx6ZrUKXJjpY0RHUem3fXxaPhLZyo78xSmfdwGkQzYsFG5NJc3TOr0=@vger.kernel.org X-Gm-Message-State: AOJu0YwZevQ74PxW8h/8Gf8Z+GPvdrIycZpCTs6WRTpoODlljMu+488u q1+tmZyeRkUYz6tkbACWsvR8yoOS5zXzJibaKEK5pfA3WKiDeQQ1Xwbj X-Gm-Gg: Acq92OFQezz0tqpULSAnnb9m2eiFtJ5rCuUEo3yy9PfwlEWRaTBqUkRC+q8x7pFhqpG fi+BAfcEmrWmszQBehuIrJYyt6R1KhKqs3dFzsIhslYWed2bFuoe1UZmkXgADx/YZUp1M1pcNS7 2HSZanRVqZ0nDfZQJinn7XXcuo2+ksgUq9U55MQgqTcOz0rawPwMRr7OhAvwZ7R96bW/nFJWC8y l9Y+oZTL/KomBiw0HNHgmGwXF365ePg2sT5cgAo5SvxRIvXBhO1QjGG3xn6pisvzqBLGDHF5J59 hw6VtDgUK/PaXPfRhU2AKwJMLXFG4qGS7O67tJyYBWG6R+3lh3s6QfY0uceCHSyfVpR6qOGN5yV jL2Emv6E1r7bKiCHZLYLYgMpg1b8N3b6vjLOABNUCUlDoSXtYogzYSqALGtW5SoX10b/gooKgzf teHPczPvv5G55jpX6q X-Received: by 2002:a05:6214:d83:b0:8cc:ebc0:6ec7 with SMTP id 6a1803df08f44-8d32ebcf12bmr100315286d6.38.1781331432342; Fri, 12 Jun 2026 23:17:12 -0700 (PDT) Received: from localhost ([43.225.189.75]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8d305134b20sm43615736d6.43.2026.06.12.23.17.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 23:17:11 -0700 (PDT) Date: Sat, 13 Jun 2026 09:17:04 +0300 From: Dan Carpenter To: Brock Haftner Cc: Vaibhav Agarwal , Mark Greer , Johan Hovold , Alex Elder , Greg Kroah-Hartman , outreachy@lists.linux.dev, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: greybus: audio: add missing newline to sysfs_emit formats Message-ID: References: <20260613014905.48458-1-brockhaftner@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Jun 13, 2026 at 09:15:08AM +0300, Dan Carpenter wrote: > On Fri, Jun 12, 2026 at 06:49:05PM -0700, Brock Haftner wrote: > > The sysfs_emit() function is used to format strings that are returned > > to userspace. According to the sysfs documentation, these outputs > > should include a newline character for visual clarity. > > > > Fix the checkpatch.pl warnings by adding the missing '\n' to the > > sysfs_emit() format strings inside several functions. > > > > Signed-off-by: Brock Haftner > > Please don't do this for existing code, only for new code. There > is a risck that user space relies on the old behavior. We should delete this checkpatch warning really. It could be a sashiko rule which only applies for patches which introduce new functions or something. regards, dan carpenter