From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45C812749DC for ; Thu, 25 Jun 2026 10:26:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782383214; cv=none; b=oG2ue90p0MdMVzhxzJqH4pVsOA/T83X2grwpz6Dt+rowx8GlFmXHPVIA5mhiTbrgNQMzJUmCyVy+FZUzy5+7ypmqqfB3ULYJs745kQn/L5EUVfCHqTM0xhZyjbouaa4FvwsmObyb0FhlqDOK/OUNN6iJt2GgHadmJjQoRpTKww4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782383214; c=relaxed/simple; bh=AU5Hyl9Hn6l54+W2pWDrHIzyw5AWf6ORtaXgyteNaA0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ISK5UdabIihIJZUMR549X3YlpNg3jK75iPM8QMLDiy3UU+0G9c/E7H2KpDd8rTFGa19DfYjXFRLMXWDhDaGwk3bYix60I0AYrdQXc4Q3hdMrPRkMLhTksBMeeJqLRnvcu2744RoaCV5t6KgixYXQPoyN0biTaAGAwPJmlI9G1n8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IwerAhSW; arc=none smtp.client-ip=209.85.210.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IwerAhSW" Received: by mail-ot1-f44.google.com with SMTP id 46e09a7af769-7e9565cc13aso790123a34.3 for ; Thu, 25 Jun 2026 03:26:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782383212; x=1782988012; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RpuUsGnvDm+QoXjPHw7swJUNLQqaW5CEgJOYVsc0Fz0=; b=IwerAhSWU07vz3XyHb7pmjERm3v2/2ErXp5RbiKJGGhzH1Y8IZbvYpw4/5wz9RSb2L kFYogeN5Evy32jBN4ar9jdBbTCMG9jzKRwc+gnmeRch2rNupsTlbqY3AshcHvpZGrteP xVvmFZbVhk9CrBj3JhbHitJbK7pfUYQO73mLRsk2ZaXXH7d0NYNRxww0ZbgxY4pVoEf1 vnpybK925a5ZaBe27GqURlUQGhKWNDAbmb98A+W3pQS9sGtIzMU5DYx9jg0ZRYaL1/bM BQ4cE1vFvuUvOO/J8odh41C3Pf4p87LUln2TXB8E2GRdhx7HH0KZ4QaIP3a40NbxZFpH LGsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782383212; x=1782988012; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RpuUsGnvDm+QoXjPHw7swJUNLQqaW5CEgJOYVsc0Fz0=; b=oYU/UyrXEkbTgN/nHohfEpC9PHSzgr/GVZZQjA7tI3F1/dCRlR5yJYsKB0E6cTwqCD 0t6+vh0296bijpKPicmAch613SCYvQZHjf+TBUMLRSNH+7JycMAgcP8ffXjh7tMwgnln M5VnwvmEZMrVqFMM4uxDbVa3UBOA/rKor2z2yqvdmcVfaUIP/s+m0yCuzhnhMFzwWGnB 3Ap7SjcxJDHgSqPFxNzBGDZtOG3weeyQNRVboTd1BKuVMURxItb0OBc6ao/C8CMK4FIo ng3i/hDeGu+D+lU4caMRnPB3Nnyw1+BaQR9kEoFjK/SIU5Zl1J37GH1dOKqtkG46uA1K gcDw== X-Forwarded-Encrypted: i=1; AFNElJ9Yi6aLbIZ0/BVuPPwtPS4l8yyhMky3Uk5Gn6lpWH+fXRmAt8Q5jNi7KK52fbCdrlWVPDV6JVGSXSKRHd8=@vger.kernel.org X-Gm-Message-State: AOJu0YzhQhVmKpgFoX5KkSbYuS1Eyb7T/9Ab2NwAVxKPjK92pW7DVdlj xblEblbN1ZnadjxudD9WMADhHpFw58Upic+kapQcqc5abgk+iy1IHvEQ X-Gm-Gg: AfdE7cmdpOxLxxRVIL4lvAYSuCNWHSrztZrucbPTb3LiPgmWl4VnElvMechDzw870A1 sMABNqQGvcrcG7Ts8XEFfWLTkbTNjv8cYpZI8mqcLtEgCJJc4InH0Sbhk+Nu+nttcYs96JhUlWA 5WS9mkV1OjYm9VGuhLPeuZMFdIvqkY1FY7UpJLq57MABtg9XuQ0e2tgpVCC32gV3vwVQNvJpdut T94xloww2/zY5pn5RhGW3ZRaRKOIc7Sdx1AczYnzcdjbIaduVGQg8FIBcqfA2cXjXkW5UZRUxQU 9xtcjAudUuAO1lrWQhDA6dsIXn1LeXc+WEf5Y6hc+4ZWboDmIHDkhNRzN7yxD2+HTkA9RHWWulq Z9zUVfVd4hsWuGXoCPhkMLdHfvgXIplyDCKPuDG1ugAOGOqfjW81yywad6YiYtNutjN4qJ9VGXd SMa2fb X-Received: by 2002:a05:6830:2685:b0:7dc:dbe4:3f21 with SMTP id 46e09a7af769-7e99bf36cd5mr2313648a34.1.1782383212267; Thu, 25 Jun 2026 03:26:52 -0700 (PDT) Received: from localhost ([74.80.182.98]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7e94429a5bdsm14319962a34.22.2026.06.25.03.26.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2026 03:26:51 -0700 (PDT) Date: Thu, 25 Jun 2026 13:26:44 +0300 From: Dan Carpenter To: suryasaimadhu Cc: vaibhav.sr@gmail.com, mgreer@animalcreek.com, johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: greybus: add comments to mutex declarations Message-ID: References: <20260625085740.222486-1-suryasaimadhu369@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260625085740.222486-1-suryasaimadhu369@gmail.com> On Thu, Jun 25, 2026 at 04:57:40PM +0800, suryasaimadhu wrote: > Add comments to mutex members in gbaudio_codec_info struct > to describe what each mutex protects, as recommended by checkpatch. > > Signed-off-by: suryasaimadhu Capital letters? Is this how you would write your name on a legal document? I kind of hate this checkpatch warning. What I want is a document, not part of sentence... The document could go in the commit message if you want, but I really want some thought to go into it, otherwise it's sort of useless. regards, dan carpenter