From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B6C1F379EDA for ; Fri, 26 Jun 2026 13:11:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782479518; cv=none; b=bgjynZuXC71VO3h5zyQGaPra7l4PqR34i0D1WKWUFo7vtau//CfIP/TjpOjn3UsaqbYIr0CICIXnN2TjRtn7GZfSz4pOPvYbKZGLVAGYSpPdkEDChuZxjNGn6YIT4u0CgpJv7+pFdW9t2K63CrUbRgGFrGOOIugr0g3YW5OfINU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782479518; c=relaxed/simple; bh=Pnzg4Vua4eUiegPcuy3w1xw7ggvGdZue6WTW7qhL/+s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PRxiWZc/Nh7hUVml5cpn2Oqxzrpg5qt3vc5tbOpM9xJRJvIuaarqTpq+yp+IHh4cqRHL3G02pldwgFIM9RLDFqBsCRZ8k1BrkxmhTwR/YyAn7W3pMJJQWkV8chn86D2izUVooL2WDlsBQRAO4CrzmX2/l+xrLdY0H4+jF8s6qL8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=M8kZTkpZ; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="M8kZTkpZ" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 831AB1F91 for ; Fri, 26 Jun 2026 06:11:51 -0700 (PDT) Received: from [192.168.0.1] (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id D6E493F632 for ; Fri, 26 Jun 2026 06:11:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1782479516; bh=Pnzg4Vua4eUiegPcuy3w1xw7ggvGdZue6WTW7qhL/+s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=M8kZTkpZYWJYjG9dBtS6s1yinupzJW5b77o3Uj+rvooWYFsge7oW7xJcrY9Dy1++K KilXhiMHnCJn6wXG+EVvTDvGGthn2kWuzIaYZpgESwiUJ9Oan1Fio2LgCFbAp0buTI 9uuDm7MOMrVvEjxpNY8L/aL5MQ4G6Rebe2XBG//0= Date: Fri, 26 Jun 2026 14:11:44 +0100 From: Liviu Dudau To: Boris Brezillon Cc: Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Nicolas Frattaroli , Chia-I Wu , Karunika Choo , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/11] drm/panthor: Drop a needless check in panthor_fw_unplug() Message-ID: References: <20260625-panthor-misc-fixes-v1-0-b67ed973fea6@collabora.com> <20260625-panthor-misc-fixes-v1-8-b67ed973fea6@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260625-panthor-misc-fixes-v1-8-b67ed973fea6@collabora.com> On Thu, Jun 25, 2026 at 02:40:34PM +0200, Boris Brezillon wrote: > panthor_fw_unplug() is only called if we at least managed to initialize > the IRQ, so it's safe to drop the "is IRQ initialized" check. > > Signed-off-by: Boris Brezillon Reviewed-by: Liviu Dudau Best regards, Liviu > --- > drivers/gpu/drm/panthor/panthor_fw.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_fw.c b/drivers/gpu/drm/panthor/panthor_fw.c > index 986151681b24..4fbddb9e18c8 100644 > --- a/drivers/gpu/drm/panthor/panthor_fw.c > +++ b/drivers/gpu/drm/panthor/panthor_fw.c > @@ -1279,9 +1279,7 @@ void panthor_fw_unplug(struct panthor_device *ptdev) > > if (!IS_ENABLED(CONFIG_PM) || pm_runtime_active(ptdev->base.dev)) { > /* Make sure the IRQ handler cannot be called after that point. */ > - if (ptdev->fw->irq.irq) > - panthor_job_irq_suspend(&ptdev->fw->irq); > - > + panthor_job_irq_suspend(&ptdev->fw->irq); > panthor_fw_stop(ptdev); > } > > > -- > 2.54.0 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯