From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ECF693F44F7 for ; Fri, 26 Jun 2026 13:14:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782479700; cv=none; b=MfsSEV5CwmBgZ48BpkySLCfLon8QNdH1IFWTgC1rFD1cgR7bgyFK5f/muij6u+DigKhrqU5HWyniFsrRXojc+xX0+SfSWr0bDC/zCDy4Z6QSGfpksHhZp29m19aAX7QoOhiYq+mQ39SDnUdIaxNs/60zYFZhiYv6OGw/7xfmGj0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782479700; c=relaxed/simple; bh=eF0j0/YTdB0/ZJ3vRoIz/xUJ/gxKGDooPHZJ4OvYhaM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=n2EvT3ZSUqDOSQOI32hjfnvLrWRnB9flKaxa7lPq58rCCgxVDG87SUxFCLqxnkbqPJ11xhnt+OdLIM50XYC9LEozl763eJS2bqkC25ws1lRQpYV6pdb9H9aEWRxX7ktUchpUEYygCPWUNVhmTB6I2ktlXooFy3hFK4hl/fhWPZE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=eMsHZ88g; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="eMsHZ88g" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DD12416A3 for ; Fri, 26 Jun 2026 06:14:53 -0700 (PDT) Received: from [192.168.0.1] (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 300073F632 for ; Fri, 26 Jun 2026 06:14:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1782479698; bh=eF0j0/YTdB0/ZJ3vRoIz/xUJ/gxKGDooPHZJ4OvYhaM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eMsHZ88gi6LKmPOGeuosqKgn2y/JfiBx/VWZnio5UkoGWLxbj6pH6R0H5BhpjdFXQ oIEABvnZK8YKV5y2j6niIoqQ8SktuqLTSLH09rJr2qZTyyJ409mjUcEO54ZpVFoAPj veoKMpqvC+UsGgmUKOaViaGV2hl//Qu052lrquBk= Date: Fri, 26 Jun 2026 14:14:45 +0100 From: Liviu Dudau To: Boris Brezillon Cc: Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Nicolas Frattaroli , Chia-I Wu , Karunika Choo , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, sashiko-bot@kernel.org Subject: Re: [PATCH 10/11] drm/panthor: Interrupt group start/resumption if group_bind_locked() fails Message-ID: References: <20260625-panthor-misc-fixes-v1-0-b67ed973fea6@collabora.com> <20260625-panthor-misc-fixes-v1-10-b67ed973fea6@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260625-panthor-misc-fixes-v1-10-b67ed973fea6@collabora.com> On Thu, Jun 25, 2026 at 02:40:36PM +0200, Boris Brezillon wrote: > group_bind_locked() can fail if the MMU block is stuck. This is normally > a reset situation, but by the time we reset the GPU, we might have > tried to resume a group that's not resident, which will probably trip > out the FW. So let's avoid that by bailing out when group_bind_locked() > returns an error. We don't even try to start more groups because the > GPU will be reset anyway. > > Fixes: de8548813824 ("drm/panthor: Add the scheduler logical block") > Reported-by: sashiko-bot@kernel.org > Closes: https://sashiko.dev/#/patchset/20260623-panthor-signal-from-irq-v3-0-2ece396f8ee0@collabora.com?part=7 > Signed-off-by: Boris Brezillon Reviewed-by: Liviu Dudau Best regards, Liviu > --- > drivers/gpu/drm/panthor/panthor_sched.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c > index 5fe95d03f23e..298b046c95ed 100644 > --- a/drivers/gpu/drm/panthor/panthor_sched.c > +++ b/drivers/gpu/drm/panthor/panthor_sched.c > @@ -2368,7 +2368,13 @@ tick_ctx_apply(struct panthor_scheduler *sched, struct panthor_sched_tick_ctx *c > > csg_iface = panthor_fw_get_csg_iface(ptdev, csg_id); > csg_slot = &sched->csg_slots[csg_id]; > - group_bind_locked(group, csg_id); > + ret = group_bind_locked(group, csg_id); > + if (ret) { > + panthor_device_schedule_reset(ptdev); > + ctx->csg_upd_failed_mask |= BIT(csg_id); > + return; > + } > + > csg_slot_prog_locked(ptdev, csg_id, new_csg_prio--); > csgs_upd_ctx_queue_reqs(ptdev, &upd_ctx, csg_id, > group->state == PANTHOR_CS_GROUP_SUSPENDED ? > > -- > 2.54.0 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯