From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3935B3EA96F for ; Fri, 26 Jun 2026 10:13:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782468783; cv=none; b=gkBVgMd2peZqMO0yeAaO8Zvxp+UAbtSEv4RUNprjICq9rfWXmSWvcxCu38hEtoC2WQLnZ2lvHN66kN5Tzu6QlysxNzkIKa0UoIAj2g2y6cFHSbuWqIZ5pdlVSxJkeodFhicPDdXDMmNIi6Xp5RFRJgRLBc0kzLds4afipmLV1Z8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782468783; c=relaxed/simple; bh=FSnrlKBLGASKyLYPnOrD9RhX3K7Ks3POuU+wbvy93yg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iMsPcIuJqWNQb2T/MsM3Z7qBYBK52dTLYmUi+3ze079nxYwpc3DQOgcdUY9z0RWC3pO40WUxcSJyW3FWwf5buzMfZ5dnlkIkt28mQRQV1A5T5zAz3Yh6/FyezrT3zMHipfSdDPvfqW/7B1hp/oBnELWtTxVXMJOQry3C21oZKHA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IkUmBur+; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IkUmBur+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 452731F000E9; Fri, 26 Jun 2026 10:12:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782468782; bh=TLiF915NfwLlVsSq/4aXT/wvHW5AzhlVslUyqSeMDmY=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=IkUmBur+hR2C7H5r5OY8FChnTsJXdoIDefxQHV1RUUXO5CD358HNgpdA3jZOhIf+M h93FSBaZ0HcQjofz07UgDyXxGhvrwXxNxgVeIGA5GGbMEc/AHwhRliI23hrzzWlU9m fGGQ/1UqVLk4j0a2A75w5Wt5JOogseZcJe5EEVVVUwGGGrgdpghvh0dVJG0GXgmEoU fQEGz39TXu8huP1maFinuCvz4dfLfGgmDcmb+yLMrv4OxMAqgygFEha8Juz9CEK/fa ynr26K/mv+ZKn8IaaJceAyduIRqlRP+5bRU7cTU4CHsAC09EenWR+8ksHDNNXn7cYf ZZU0XF01VKxaA== Date: Fri, 26 Jun 2026 11:12:53 +0100 From: Lorenzo Stoakes To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, david@kernel.org, liam@infradead.org, vbabka@kernel.org, rppt@kernel.org, hao.ge@linux.dev, jackmanb@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/2] mm: move alloc tag to mm Message-ID: References: <20260625184857.2193482-1-surenb@google.com> <20260625184857.2193482-3-surenb@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260625184857.2193482-3-surenb@google.com> On Thu, Jun 25, 2026 at 11:48:57AM -0700, Suren Baghdasaryan wrote: > From: Lorenzo Stoakes > > The alloc tagging work is really mm-specific, so move alloc_tag.c to mm/ > and additionally update the MAINTAINERS entry to place it within memory > management and port over the Kconfig and Makefile code to mm. > > Signed-off-by: Lorenzo Stoakes > Signed-off-by: Suren Baghdasaryan LGTM (obviously :P) so: Reviewed-by: Lorenzo Stoakes > --- > MAINTAINERS | 20 ++++++++++---------- > lib/Kconfig.debug | 28 ---------------------------- > lib/Makefile | 1 - > mm/Kconfig.debug | 28 ++++++++++++++++++++++++++++ > mm/Makefile | 1 + > {lib => mm}/alloc_tag.c | 0 > 6 files changed, 39 insertions(+), 39 deletions(-) > rename {lib => mm}/alloc_tag.c (100%) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 0948dc573744..3cf3cf2311e2 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -16704,16 +16704,6 @@ F: mm/mm_init.c > F: mm/rodata_test.c > F: tools/testing/memblock/ > > -MEMORY ALLOCATION PROFILING > -M: Suren Baghdasaryan > -R: Hao Ge > -L: linux-mm@kvack.org > -S: Maintained > -F: Documentation/mm/allocation-profiling.rst > -F: include/linux/alloc_tag.h > -F: include/linux/pgalloc_tag.h > -F: lib/alloc_tag.c > - > MEMORY CONTROLLER DRIVERS > M: Krzysztof Kozlowski > L: linux-kernel@vger.kernel.org > @@ -16758,6 +16748,16 @@ T: quilt git://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new > F: mm/ > F: tools/mm/ > > +MEMORY MANAGEMENT - ALLOCATION PROFILING (ALLOC TAG) > +M: Suren Baghdasaryan > +R: Hao Ge > +L: linux-mm@kvack.org > +S: Maintained > +F: Documentation/mm/allocation-profiling.rst > +F: include/linux/alloc_tag.h > +F: include/linux/pgalloc_tag.h > +F: mm/alloc_tag.c > + > MEMORY MANAGEMENT - BALLOON > M: Andrew Morton > M: David Hildenbrand > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index 8ff5adcfe1e0..3762015522c3 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -1048,34 +1048,6 @@ config CODE_TAGGING > bool > select KALLSYMS > > -config MEM_ALLOC_PROFILING > - bool "Enable memory allocation profiling" > - default n > - depends on MMU > - depends on PROC_FS > - depends on !DEBUG_FORCE_WEAK_PER_CPU > - select CODE_TAGGING > - select PAGE_EXTENSION > - select SLAB_OBJ_EXT > - help > - Track allocation source code and record total allocation size > - initiated at that code location. The mechanism can be used to track > - memory leaks with a low performance and memory impact. > - > -config MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT > - bool "Enable memory allocation profiling by default" > - default y > - depends on MEM_ALLOC_PROFILING > - > -config MEM_ALLOC_PROFILING_DEBUG > - bool "Memory allocation profiler debugging" > - default n > - depends on MEM_ALLOC_PROFILING > - select MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT > - help > - Adds warnings with helpful error messages for memory allocation > - profiling. > - > source "lib/Kconfig.kasan" > source "lib/Kconfig.kfence" > source "lib/Kconfig.kmsan" > diff --git a/lib/Makefile b/lib/Makefile > index f33a24bf1c19..44f6538533a9 100644 > --- a/lib/Makefile > +++ b/lib/Makefile > @@ -197,7 +197,6 @@ obj-$(CONFIG_OF_RECONFIG_NOTIFIER_ERROR_INJECT) += \ > obj-$(CONFIG_FUNCTION_ERROR_INJECTION) += error-inject.o > > obj-$(CONFIG_CODE_TAGGING) += codetag.o > -obj-$(CONFIG_MEM_ALLOC_PROFILING) += alloc_tag.o > > lib-$(CONFIG_GENERIC_BUG) += bug.o > > diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug > index 91b3e027b753..5737a504efbb 100644 > --- a/mm/Kconfig.debug > +++ b/mm/Kconfig.debug > @@ -320,3 +320,31 @@ config PER_VMA_LOCK_STATS > overhead in the page fault path. > > If in doubt, say N. > + > +config MEM_ALLOC_PROFILING > + bool "Enable memory allocation profiling" > + default n > + depends on MMU > + depends on PROC_FS > + depends on !DEBUG_FORCE_WEAK_PER_CPU > + select CODE_TAGGING > + select PAGE_EXTENSION > + select SLAB_OBJ_EXT > + help > + Track allocation source code and record total allocation size > + initiated at that code location. The mechanism can be used to track > + memory leaks with a low performance and memory impact. > + > +config MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT > + bool "Enable memory allocation profiling by default" > + default y > + depends on MEM_ALLOC_PROFILING > + > +config MEM_ALLOC_PROFILING_DEBUG > + bool "Memory allocation profiler debugging" > + default n > + depends on MEM_ALLOC_PROFILING > + select MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT > + help > + Adds warnings with helpful error messages for memory allocation > + profiling. > diff --git a/mm/Makefile b/mm/Makefile > index eff9f9e7e061..4fc713867b9b 100644 > --- a/mm/Makefile > +++ b/mm/Makefile > @@ -147,3 +147,4 @@ obj-$(CONFIG_SHRINKER_DEBUG) += shrinker_debug.o > obj-$(CONFIG_EXECMEM) += execmem.o > obj-$(CONFIG_TMPFS_QUOTA) += shmem_quota.o > obj-$(CONFIG_LAZY_MMU_MODE_KUNIT_TEST) += tests/lazy_mmu_mode_kunit.o > +obj-$(CONFIG_MEM_ALLOC_PROFILING) += alloc_tag.o > diff --git a/lib/alloc_tag.c b/mm/alloc_tag.c > similarity index 100% > rename from lib/alloc_tag.c > rename to mm/alloc_tag.c > -- > 2.55.0.rc0.799.gd6f94ed593-goog > Thanks, Lorenzo