From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A5FE1C84A6; Fri, 26 Jun 2026 11:10:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782472230; cv=none; b=ISm73jou+64RxkfUsHOn3tc5Lelrj+aHNnBc1Prq3Y7moZSWZpoBvgngv5v8DM2Y/cCaEMizgB0fea3Q5N0npCIwxNfqmFAtMW9vU/0n4UHFfL+HTYNw/uYaeqGhBFRKxh6BO4LlmjVs6t4Pw8jkCkfMI+vA++9uicmTUtl/LGQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782472230; c=relaxed/simple; bh=BcOwHJCBoHCD/nt/jx+PVcrmEB7h8PTVijZIhVv3P34=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DqHbdL1yYq7qAZlsQOjKlWrKlJ6WD1L+Iitjp8KvUvVkKY8sylgQ+VPUrzqE/7JjGJT+LCHGm8Evwn+g29UNfsXrxvWj6Le7uSGxXDDF8CEKZ0ASGMhQw0ITficVvXObL+gFhknRjqeIyZeomIQv8TSCQJLDcTB/z4bcFIJqStw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=orM0BkuR; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="orM0BkuR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E2B61F000E9; Fri, 26 Jun 2026 11:10:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782472229; bh=AUAlvBxMc4bt39AC/sKnSSFnKSzDSItRNQY9EFsMK8s=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=orM0BkuRMVNu0xg5QM0Qz3nJn7sG/5q9c8yQHGAYSEMgq2ZwuHw5D3SIT+gh+NhNO NGIW+AYjUQFDt2KcAGfafHF44nmxOJyvHq73WLrfWTClCjpb/uw0BkwJdLS2S1ujE1 sz3N1ICe7QfgsfEafH5CivH1u6UjxsIJ5py8xTXSen9hES8/o8SwcF4FX8cIiEk/OZ ss/DTt6OEgDaMfo+Oqg0IZjMVZYtjhUJ3V2AQwod3baRgRAhTs0cXGr2BS/SqlT3vh p6cKiJIWtup8MdD5ERyKyOmSLgUPMr4eHj0sV/i742eDSOSZk6AjXQBnAETJ2M83NY GRrTvUVIwaabQ== Date: Fri, 26 Jun 2026 13:10:25 +0200 From: Niklas Cassel To: Wentao Liang Cc: dlemoal@kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] ata: pata_pxa: Fix DMA channel leak on probe error Message-ID: References: <20260625141837.62362-1-vulab@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260625141837.62362-1-vulab@iscas.ac.cn> On Thu, Jun 25, 2026 at 10:18:37PM +0800, Wentao Liang wrote: > When dmaengine_slave_config() fails, the DMA channel acquired by > dma_request_chan() is not released before returning the error, > leaking the channel reference. > > Fix by adding dma_release_channel() in the error path. > > The ata_host_activate() error path already correctly releases the > DMA channel. > > Cc: stable@vger.kernel.org > Fixes: 88622d80af82 ("ata: pata_pxa: dmaengine conversion") > Signed-off-by: Wentao Liang > --- > drivers/ata/pata_pxa.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/ata/pata_pxa.c b/drivers/ata/pata_pxa.c > index 03dbaf4a13a7..9f63bdfb8576 100644 > --- a/drivers/ata/pata_pxa.c > +++ b/drivers/ata/pata_pxa.c > @@ -286,6 +286,7 @@ static int pxa_ata_probe(struct platform_device *pdev) > ret = dmaengine_slave_config(data->dma_chan, &config); > if (ret < 0) { > dev_err(&pdev->dev, "dma configuration failed: %d\n", ret); > + dma_release_channel(data->dma_chan); > return ret; > } > > -- > 2.39.5 (Apple Git-154) > Reviewed-by: Niklas Cassel