From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A916E3F65E6 for ; Fri, 26 Jun 2026 13:56:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782482168; cv=none; b=KPeWBBt3dOWfGAyLQe0WNS/+rRRdJ3YSJij19SL3oWId03iWJTiZfOlZiOE0esgMfQdyIRx+PymhvntH4J1fX11Vd2KQbOr3VaIE4PSWYsyoWtBqkNvWqTrA3sd0Lz8Ib/ez0cdONqGTbVphy3gBLxAQgDUIgpDztmrF+aCNuZE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782482168; c=relaxed/simple; bh=Ypj8YbpZh8DLGxiE+bf5181FYshu9+mBWbj2UyK6dBA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HfPlR2qrZyRULZRfg93+e2KAU/NRii9DOd365cvk1CyaSfLez2UXubwETpVHrvMA1u5X9RznrZlqTPa29nuc8H9qyJKd7zduSr+XComV5nnV+VcVkvXwR1s7PGRJ5OASgN/tOLPl2o6FntJOeood7S/XTxvupfNxJUHkyR/Ofhs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YPcS9bjK; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YPcS9bjK" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-49222b6e871so5686755e9.3 for ; Fri, 26 Jun 2026 06:56:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782482163; x=1783086963; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=ALRbLCeBb0+qAmaWCzzB4bdRKDNWwVqd2KysEaQO224=; b=YPcS9bjKZ0ny9A+W8Q9q9bPxRextRu5ido9d0TX0rQRzbBDbM9yK4DvdiyVlz93kPo uGUu3aBR3uKHqr3JsBKk8vJDH/sHXLUOV6HMi9FH0YEIrjtO/IvCAOdlDi+ZFhUA+Cn0 Fx/lTt087Bp41q4KFWLoIPjYbTyb6Yqr3QGds8XxTFbBt8ckb1r9kazHG97uvXGE9n/t 95FOobmMno82zIVQLaLL6i6k0N9s6GqzksdzpCTHvjdxH9wSxwc2+IS6sY28ATlbyMuO Z3LCQjT5E+dk0GqQk+Iskz2W4w4sbRQRk/RyQD9XpLjtKTa/drfzmu0YPAXUqw4fDGj5 8SBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782482163; x=1783086963; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ALRbLCeBb0+qAmaWCzzB4bdRKDNWwVqd2KysEaQO224=; b=QkBC0QmBmWLwS9xf8yA/ETWkmT9QJ0Tf8OtN3dFsEzLg6ZwbtDN/TPOnzHVWJdNyi5 xO8oAyfol5IIrpRcb+/trGj6P8CyYxPSFpEjLEa8N0J3fz+ikPTS4p1/EeMndiWXQa3E YpTA06AWRh7B8vUI9jvD3FhRtkpn7gsocXHlRhJCRTISVzFDFaN9xeS9t492soGrtiy3 /rev2bh4DirbOIQZ+8MnLiQARXYafLn4syDJnODWYRrX3+0a2Y5cTqHyPivYzNDxL4ET lhiv4m7tq1PUbw3hDV45lo+pJmg6MgTdTRfXI9A0g6ZmN6mU3h15mKJl2+cR7Cz0Aumk o+kA== X-Forwarded-Encrypted: i=1; AFNElJ8Xy4HHHssm1tY1tf5QBr3EbknAOM7xy+7YZdfhiUNBL/CyyJLsJ3+I9W1Hn+07b2rucyXC3Z0CTQ8N74s=@vger.kernel.org X-Gm-Message-State: AOJu0YyeTlsuM7a3rqz6J3SmYzhgmCZ2NQMll1F7v/RZH8xq4HPqzoqd BgUDq/X/9IOCIUaXessjWbwfGqOjCNnnRuzjb11Ifn+lQ6fbMpcBtgZb X-Gm-Gg: AfdE7cmuiEGtW0WkuWFHKkWL5cQ6YtMtzCAdV5dyaCSOBa+EU9fNmJTHXNGkYVo31WW VqqK6QriN78DJOunSF8FirwlVcVVFGPauE9XfLBmtwDfQ2X8KlSMaJJGT1IgYMd7jIjv8I6PNVx pPEr+LVgUuyclKvIqy9CiRwyEI8KTUOmdzvj5Z8aBV3Mc8blMXONsbpjTDUr+7ATA60Eh4FbqrT cRSB2VFRWEMEdvk8hRW1sKrcSbfbiokxPiHibgtl17a5KQav12IHFvmFwk+lLgnO/tRwKF0uTgc 5krTbjB1byhhTdJWX4+d5g6gSY8wCcB4aNgiks+9aUZjFBG9htXpNv7bMK8wR2GauPRQsj7ABH+ x+Ft+/ormeQl4rvOth2o0uxJgZnVEffFzuk+N7bTarbU7cF8x0eGG1WDTmKLQIxrGiejdga8cjx dNxnDC X-Received: by 2002:a05:600c:e557:20b0:490:a1dc:e542 with SMTP id 5b1f17b1804b1-49266862d71mr72584745e9.6.1782482162608; Fri, 26 Jun 2026 06:56:02 -0700 (PDT) Received: from nsa ([148.63.225.166]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4926f94f213sm20636875e9.12.2026.06.26.06.56.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2026 06:56:02 -0700 (PDT) Date: Fri, 26 Jun 2026 14:57:05 +0100 From: Nuno =?utf-8?B?U8Oh?= To: Andy Shevchenko Cc: Joshua Crofts , Jonathan Cameron , David Lechner , Nuno =?utf-8?B?U8Oh?= , Andy Shevchenko , Svyatoslav Ryhel , David Heidelberg , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/3] iio: light: al3xxx: add missing REGMAP_I2C to Kconfig entries Message-ID: References: <20260625-fix-al3xxx-kconfig-v2-0-796cf8d7cc49@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Jun 26, 2026 at 03:26:06PM +0300, Andy Shevchenko wrote: > On Thu, Jun 25, 2026 at 09:38:07PM +0200, Joshua Crofts wrote: > > This series adds REGMAP_I2C support to three AL3xxx ambient light > > sensors that were previously missing this dependency, causing build > > failures. > > > > To reproduce the build failure, run `make allnoconfig` and `make menuconfig` > > in which you select IIO, I2C and any AL3xxx sensor and `make .` will > > fail with errors such as: > > > > drivers/iio/light/al3010.c: In function ‘al3010_probe’: > > drivers/iio/light/al3010.c:185:24: error: implicit declaration of function ‘devm_regmap_init_i2c’ [-Wimplicit-function-declaration] > > 185 | data->regmap = devm_regmap_init_i2c(client, &al3010_regmap_config); > > | ^~~~~~~~~~~~~~~~~~~~ > > drivers/iio/light/al3010.c:185:22: error: assignment to ‘struct regmap *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion] > > 185 | data->regmap = devm_regmap_init_i2c(client, &al3010_regmap_config); > > | ^ > > drivers/iio/light/al3010.c: At top level: > > drivers/iio/light/al3010.c:48:35: error: storage size of ‘al3010_regmap_config’ isn’t known > > 48 | static const struct regmap_config al3010_regmap_config = { > > | ^~~~~~~~~~~~~~~~~~~~ > > Now all is better. The only thing is missing is Cc: stable@ line. I'm not sure we have a defined policy for that in IIO. Now that you mention it, maybe time to ask... My understanding always was that Jonathan takes care of Ccing stable but maybe he just does it and being nice about it, does not complain :). So, Jonathan, Should the sender take care about Cc or not? Or it does not really matter :)? - Nuno Sá > Reviewed-by: Andy Shevchenko > > > I made a separate commit for each driver, to ensure a proper Fixes: > > tag is appended for easy backporting. Let me know if you prefer > > squashing! > > I prefer per-driver patches, but let Jonathan to handle that. > > -- > With Best Regards, > Andy Shevchenko > >