From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD6EE3F8ECA for ; Fri, 26 Jun 2026 16:24:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782491086; cv=none; b=ezedzFxFX2kJQG8VOfV/6L4j35bXScUisC4Xvt34cc6l6PijqX03grG77xBwiuavAYhZOxHvX3JJouKZc3DDSO/Z+GInzndbBBgNE5nwKIOnvTha0ghYZoJjZrSoofWmnWlXQF+TvZEqY45OuQpKIFZZP1qHI8X+K9yDgVSz3Ow= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782491086; c=relaxed/simple; bh=ZDpTKXUJtSOCn0iOJVPzDGA8hH0ROrYolCqzrG/2UN4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=n7qhdRIrjx+MLUXeawbt6Fg+GLeGVPHH+ECcwfC48mkox2PbPUZvcIETQj8lUMaCFfDdV/6cnxbV28/X4wIBpNPo0LXzr7/5hb4SB5A+Ow2GhVs0Ndt0X1Rc+LJ8vpKP5JYeeZLxdhITyI7TbJgjPe7o0Rekw+uwDqHJLCePjRs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=fGPDYMfL; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="fGPDYMfL" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-6974a6e54dbso2225907a12.2 for ; Fri, 26 Jun 2026 09:24:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782491083; x=1783095883; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tzLgbGGQbfhbvqh4cQgksDurGIAgQkr1YelLIUbVC08=; b=fGPDYMfL1bzfulPPFs02OXkeK34Wlo1+I1jEZUOk5RndOXBGGc+4vTo9H/6RPPs8PT sNANVZWHb8xK2S4+TAX2c1bnnRpf62IvNLXrXvpRcxEdpEgPvDvmVY61K7MaB/Do9+FN LKuFtGCgHu5/ckRSNaohDqElBmUyHv5rUXLctjE6EChd4rgY+NHHUnL2ApSmNP39pHlK MrL2t8B2kPS1PujnMjr8UIEr1wZ9z5LGtnkCIusItvsPZY8pylHM2w0RfGWQz+P+16Td f0X4kWPvrAPdmdNkQUzkukdphK4ByrpR/yftwMfPRICIzjl4y5WtFMsGPuYI3LJm9Ctb 3RaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782491083; x=1783095883; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tzLgbGGQbfhbvqh4cQgksDurGIAgQkr1YelLIUbVC08=; b=XLIyxWSE7qruQICFADiDqzgpHvegsQaOjQoJyGHT0q5bBYhlP9huOAqa75y7hYBROz wIKK+4X6vxzbp+lc+9SF1W3aVgnTfWqhx5awhuXwpAgUZdYFE8rmPmZQ+BfnLVocik5H piyD0elJ86xtu3+E4uWFocaRe++wIPs+LkNyK20kOv+g1RwwXEJcR8AICwtX+tA24G18 P9HYNF1iAcdDZQbfzpbspE4R0rEkKExKZrQEl7qrYmxqED+O6K8r3BLIHYnsJyMKBdcU jDTlE8RG/yMkVSkDIwKd4bC26+iMO5WiorBaB5YY658lx/SFcaUWflgOVeZnSi+p25cM FhCw== X-Forwarded-Encrypted: i=1; AHgh+RrG33z1UAfo/+0aC++gLvlT81tFAZNSz0gqbKTS2xUvfaDrCnudgpCQ1fsPEp1e6+1tKbSlDouWzLTNTWQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7HSGynFEjowOqC/vriOqtSATLPqNebZ1/+iSRrQR4ksyaPunt aNCZVeahXWWc194gjBAXzqkx7qbnE6pv/vT10MghXpPO1B+/xOto8dv76j1cC+aF4Sg= X-Gm-Gg: AfdE7ckBq+969paVQxpzOncTs8smy8GaEjLE/d4CBCrCQZLVMHGgZQVu9XOH/beICx6 UYUgcCoR+j/T/toMAumUnLnrk0gzzaZBjTtD9E5N7SMZx/tezMb8StuHdX7vNPl7s0btNbJjI0j 6Jb1zlq5JKdtWczx437iwaZaDei1q38p7qBF0JWX+HRitkEBA5qTAaiOJz7yVeaww20VEn1reL2 PYtHtFlAIOkYz5T/E0d1jPnYhh7cP3N4pBgdxxEpr8PtJ5Ag3zLZjaPddgNhKrivvJmtdL3LGJb nfeCKBCdUP0Rm8WQAt/o3bba6cBSTL4qWvfx97ywC+rbWMFoKX2IHkaeJkCufvVzrJm7NvWAXH/ oqbKi77mcMkIIApMFNX65Nx4kUKM9z1aP6qYGXahG+uQDjRVsndts+tVTJbsaab2K0rzxEouvej RyxRTOftD+jEfwHdvYVQ== X-Received: by 2002:a17:907:9308:b0:c08:713e:d8b2 with SMTP id a640c23a62f3a-c1205eb8b71mr494966966b.25.1782491083080; Fri, 26 Jun 2026 09:24:43 -0700 (PDT) Received: from localhost.localdomain ([62.77.90.70]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c11fbbaa46asm365418766b.10.2026.06.26.09.24.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2026 09:24:42 -0700 (PDT) Date: Fri, 26 Jun 2026 18:24:40 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Sun Shaojie Cc: cui.tao@linux.dev, Tejun Heo , Johannes Weiner , Jonathan Corbet , Shuah Khan , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] cgroup/cpu: document cpu.stat.local Message-ID: References: <20260626010914.1154495-1-sunshaojie@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="opqipnw7zmxxqkyc" Content-Disposition: inline In-Reply-To: <20260626010914.1154495-1-sunshaojie@kylinos.cn> --opqipnw7zmxxqkyc Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH v2] cgroup/cpu: document cpu.stat.local MIME-Version: 1.0 Hi. On Fri, Jun 26, 2026 at 09:09:14AM +0800, Sun Shaojie wrote: > + cpu.stat.local > + A read-only flat-keyed file. > + This file exists whether the controller is enabled or not. > + > + It reports the following stat when the controller is enabled: > + > + - throttled_usec > + > + Unlike the ``throttled_usec`` reported by ``cpu.stat`` which > + accounts for throttling caused by this cgroup's own CFS > + bandwidth limit, ``cpu.stat.local`` reports the actual > + throttling time incurred by this cgroup's own runqueues, > + which may include throttling inherited from ancestor > + cgroup bandwidth limits. > + > + When the controller is not enabled, this stat is not reported. I like that you contrast this to regular cpu.stat and implicitly explain that cpu.stat is not hierarchical. Here I think it's been such so long that it's not worth changing (also it's less useful than existing metrics for diagnostics). Hence would you also update the cpu.stat paragraph about the non-hierarchical values? Thanks, Michal --opqipnw7zmxxqkyc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJEEABYKADkWIQRCE24Fn/AcRjnLivR+PQLnlNv4CAUCaj6nwxsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMiwyLDIACgkQfj0C55Tb+AhFgAD/XEcVugLyyou/TK3tUc5F ZkEPGtRFL0h0sCS/DI9icUkBAJ6LorKFQRUDq3uwRK3WH0mlxofp3zGNicQgdouy 18kK =iDl8 -----END PGP SIGNATURE----- --opqipnw7zmxxqkyc--