From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D006481B1 for ; Fri, 26 Jun 2026 16:20:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782490843; cv=none; b=O8Y+VQC/gBJmo/SM7Ya7s9k2M1ovNZ3wwbmvLj+ceGyAIf7JxQYMto1xPgoC8cXsaX3x3lJLYQgzwRxawc7oN2EfS7crWXp90pq7DcE9yvqkpoiJt14ZD7XUk8qOJdMiFQIX/4Kg4bk1Wg7z7r82rRqb/IHQPQ2/ubwKmYzkx10= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782490843; c=relaxed/simple; bh=Ap/ztH6kjdoPEnaUvP4appsFMxVNnj5drj3SBWJPIW4=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=a5sKRDscB5ZTAkzq3oQqcrEyYmsMajuWvzvfnjBk6dec4kALX5XCmhYgENHemc5Qtcj0vdFNz5/hHcCoDA2BwXGYq2JrgcBHq02ppMstzUC5eL/M+4/ozQi78BB8pDnfKNnTu70dJnxd63d7oBEaeUtPUwH7wwcA9ujUa9pEMNU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QGdRau6K; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QGdRau6K" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-5aea5e2a361so802990e87.1 for ; Fri, 26 Jun 2026 09:20:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782490840; x=1783095640; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=4tKsbGrcR78zcHbLWs3JHmwiHpOL5AjwjOIZHc1xSi0=; b=QGdRau6KeJL83XTzgL6vrOgouWTfUBq6G9OtICvrNiVGctdL4J4Nq7TzsSpMFFBuKg PvROfvfMfacfpkI0LXk4MxwWCPs5TtHafSmyMNKlX0y0kA1Ms+BAudF9rJUbBat5ykVC qCuh0nnvXUEfMf0tKJXLi8zRLVkM41Po7RzWtDsS2154yWDaUZQ0M5sOvUiJb9ai80cL qXhuqyqzoaSV+lbwqYAe9vygRi1B7HOv3sscwGqOhNi/PAOvvaDYFGappGTkxSh77pZ5 EKIEy5ukVF9KZ5dFnXYKPLSGwYDijCC5p1aRpcn8Qv6dynXtFf7QLmw5CyYRNeDMvKoy JO9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782490840; x=1783095640; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4tKsbGrcR78zcHbLWs3JHmwiHpOL5AjwjOIZHc1xSi0=; b=rWG7lpBPc18QwUL2vSo7rn+0m4fbIRix2oCYNIjHzYvXoTJOIVH++P4nYpLc3gTaES tBG0mV7Pni+djYMmMwjcfRWaqEyWmJ+eYaQibKxP5NJllFxnjz+zHl0eDyRBNfbQmCZm y7rJIJXDlrNRymI8CLx5JmrMMrepEii6ARR0OygGxBDTQkPetpFy0eozVrWu6sH4G7yL 01WR+D4S/ugFldftwya3BYio40z8jJxTSeEx/xxAiEQU9EzWwTf7UArVrPJxmWDx3uya 6dJ47R8fKcwke+W/Gqc/3kh3S09KtCTg3agn7vRCmkESK45RAVr5nKBz96PJpPfOXmsc kZIw== X-Forwarded-Encrypted: i=1; AHgh+RreQO49BD3VoNqXGm3i+rjyI4ZcirLaibDZFZTMud6BRUoxPjV9z8HDdfSXoIQCg3NPsF/YO/j7eDIo+0M=@vger.kernel.org X-Gm-Message-State: AOJu0Yxlshlz6ATZra6aDeN8xCgwxsdIz0j0Ja0ue+Xyb2r1WUSHJhW2 ppP1tbxitW5BfpH1Xm4/BS+5aKG5aUEvVsSxTxDomwpL2pls1oCY8NHA X-Gm-Gg: AfdE7cnjIAjjCrtBbWYHRDwEDa5hoL9hnnKdGGUtVNKko5qLjAmcpuu/O7+A75Uz3l9 Kr8r3WMUkntkvqhBUnBsw1NNS/2uJezQu95Hc5gqlJLS1nAZSgRY397ujcD07BVF+xtciQIFDWN R7gpBfMsVW3yLTLfZMnbVQpy04BeUXmEozkUMOJovAtbDDBF6jB1ZtF6qkqXgMzagVaoDlJzwbs 7pXiwR9KNkxKGOnyNKsJq7+xFSvGiougmc9oGPSOBZXu7Hv2MEXAzmmOoTWR89jz/yXVAjRMDO7 /APFV0JiJOUo7NjrFR4QL9EoEoKf5nZq73C7oImMyvS1AJAKcRPGOLPmvrQm6EWyyhFMihYNoGb FCKW0lKpW4CkW0QedsUkuEJAfaGdruBY+x96gaZ11NnlbKotFZa1vBw== X-Received: by 2002:ac2:4bc9:0:b0:5aa:71fd:de75 with SMTP id 2adb3069b0e04-5aea94adf59mr297281e87.39.1782490839450; Fri, 26 Jun 2026 09:20:39 -0700 (PDT) Received: from milan ([2001:9b1:d5a0:a500::24b]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5ad69550ff7sm3611804e87.20.2026.06.26.09.20.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2026 09:20:38 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Fri, 26 Jun 2026 18:20:37 +0200 To: Wen Jiang Cc: linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, urezki@gmail.com, baohua@kernel.org, Xueyuan.chen21@gmail.com, dev.jain@arm.com, rppt@kernel.org, david@kernel.org, ryan.roberts@arm.com, anshuman.khandual@arm.com, ajd@linux.ibm.com, linux-kernel@vger.kernel.org, jiangwen6@xiaomi.com, shanghaoqiang@xiaomi.com Subject: Re: [PATCH v4 6/6] mm/vmalloc: align vm_area so vmap() can batch mappings Message-ID: References: <20260618084726.1070022-1-jiangwen6@xiaomi.com> <20260618084726.1070022-7-jiangwen6@xiaomi.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260618084726.1070022-7-jiangwen6@xiaomi.com> On Thu, Jun 18, 2026 at 04:47:26PM +0800, Wen Jiang wrote: > From: "Barry Song (Xiaomi)" > > Try to align the vmap virtual address to PMD_SHIFT or a > larger PTE mapping size hinted by the architecture, so > contiguous pages can be batch-mapped when setting PMD or > PTE entries. > > Add __get_vm_area_node_aligned_caller() as a wrapper over > __get_vm_area_node() to simplify repeated calls with fixed > arguments. > > Signed-off-by: Barry Song (Xiaomi) > Signed-off-by: Wen Jiang > Tested-by: Xueyuan Chen > --- > mm/vmalloc.c | 37 ++++++++++++++++++++++++++++++++++++- > 1 file changed, 36 insertions(+), 1 deletion(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index fffb885cb2158..bc9fa93e2bdc6 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3628,6 +3628,41 @@ static int vmap_batched(unsigned long addr, unsigned long end, > return err; > } > > +static struct vm_struct *__get_vm_area_node_aligned_caller(unsigned long size, > + unsigned long align, unsigned long flags, const void *caller) > +{ > + return __get_vm_area_node(size, align, PAGE_SHIFT, flags, > + VMALLOC_START, VMALLOC_END, > + NUMA_NO_NODE, GFP_KERNEL, caller); > +} > + > +static struct vm_struct *vmap_get_aligned_vm_area(unsigned long size, > + unsigned long flags, const void *caller) > +{ > + struct vm_struct *vm_area; > + unsigned int shift; > + > + /* Try PMD alignment for large sizes */ > + if (size >= PMD_SIZE) { > + vm_area = __get_vm_area_node_aligned_caller(size, PMD_SIZE, > + flags, caller); > + if (vm_area) > + return vm_area; > + } > + > + /* Try CONT_PTE alignment */ > + shift = arch_vmap_pte_supported_shift(size); > + if (shift > PAGE_SHIFT) { > + vm_area = __get_vm_area_node_aligned_caller(size, 1UL << shift, > + flags, caller); > + if (vm_area) > + return vm_area; > + } > + > + /* Fall back to page alignment */ > + return __get_vm_area_node_aligned_caller(size, PAGE_SIZE, flags, caller); > +} > + > /** > * vmap - map an array of pages into virtually contiguous space > * @pages: array of page pointers > @@ -3666,7 +3701,7 @@ void *vmap(struct page **pages, unsigned int count, > return NULL; > > size = (unsigned long)count << PAGE_SHIFT; > - area = get_vm_area_caller(size, flags, __builtin_return_address(0)); > + area = vmap_get_aligned_vm_area(size, flags, __builtin_return_address(0)); > if (!area) > return NULL; > > -- > 2.34.1 > Did intensive random mapping/unmaping, so i have not noticed any issues. Reviewed-by: Uladzislau Rezki (Sony) -- Uladzislau Rezki