From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A25B740DFC0 for ; Mon, 15 Jun 2026 16:42:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781541751; cv=none; b=tRVolXobC5rXwdF2+wp/nFYajXaTpbaV8cmSr8H+nVrmw2QFB0TSOfmaOZNYkoZhxAig0IdTwsCZ4+9Lv2hlQy2QEqfjSAPu4cxQKP1EB67MUAxvL2uhPZwxA5NrCvBSMB36fr2cHhgpInlL42pifKTN3j4Z9IrGLpuuGmyhXcY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781541751; c=relaxed/simple; bh=AgPSODbDd4zTbYSk1CYuNaeRbbg+I1fKKrMAmetN37g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=R6WKU9ghovCXo85xVDS+C8CyAt98lMTYzp+AV+jodK742jo9Y3BwySCG65LCIx5NqpRT54juJaH+qW5cHgI0F+0hmR7vv8LTn8M1r3iUplhwVpKDIGhF8/3SjTO1x+PIvVgFgdu1wjSsLIkyE0ZTIiUhON5q1Mt1X7WbDUj6+b0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dcFr3WEB; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=jEHegoMT; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dcFr3WEB"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="jEHegoMT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781541748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jg3eKHm2/9+Dr+shG2gUZ2/D9yHklfF8q59PVSPRCGM=; b=dcFr3WEBMZm5TRZMdzoJmI3zgLU3eoxW5Qc3fD1Gj/yj9n8M2sdpUGu4e3Rx2n+dPOAO/g 3M0Zzv/eyBqhZzNgSo9xQE+0TshS274NH3gr6GbaZHgVpoMFCW47ndt7OXXKDX8gW3nNGy i3dX8XtAaUds+o9PhHxgrnUfL+ZOHic= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-687-8f00T2iRM6ae6zfM_MnURQ-1; Mon, 15 Jun 2026 12:42:27 -0400 X-MC-Unique: 8f00T2iRM6ae6zfM_MnURQ-1 X-Mimecast-MFC-AGG-ID: 8f00T2iRM6ae6zfM_MnURQ_1781541747 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51949579e09so59771311cf.0 for ; Mon, 15 Jun 2026 09:42:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1781541747; x=1782146547; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=jg3eKHm2/9+Dr+shG2gUZ2/D9yHklfF8q59PVSPRCGM=; b=jEHegoMTQtQw+1c+SEYcOqO54wsR5EaNQMIC82+yPB/6RD2aaHyHWyuuB3isWECLpK Ib/mmlfOnLtOivJeZ4KBh+H7KP6S9rjfRKWkoFyagVLwlAiH7gxt5VFkf7fig6rwJbGr fcUhleMi42sr3xQGR2jd4NKVRjnde65JV84/U8AXucy6v2/doi2TBTtOOoguod2IZvR8 aEt4tJEJ/SdFw9Ljt2wpu66jqIAlJfP/HLNoifo8KSis9BS1Kjq62jf9dzIErm1tXT+L GG8KZ0k0VRzl5xdJytCNZpVhpyCj1f3lj/FCP2k3rBzJBVJyqJn1/N/FScFadhTdxmTo Xd0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781541747; x=1782146547; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jg3eKHm2/9+Dr+shG2gUZ2/D9yHklfF8q59PVSPRCGM=; b=rBFNGFCwNomXAqkaVChsimm44P2QHaY/VWp7L6Cu/jES+Soi5RU3cGMuVw5d31V6zX dj+t1kqFV9Zvl3fQDQ92rv7zGwkeGfHYUfX+QFdR2kmP3FFhHyk8CHRT6JckRFM6PX9q 4y2liflMRX+YBOCAS/s51konywxiT0BN/eNZUXz/t2EMgHqYzREM6TeYOlfZpb51jNAn bsX34APiLsXn1xCUqM557fqeT8walK0jcGZaiXL27CAgTGyKUQTSORrndLwrRj4Z6krH opg1MTyxnJr0yQABlrtAgJhEaoQ+a59zWcXWu0qXMLYtUK6wPIu3njpWrIgmgG0BiXlT 1FUQ== X-Forwarded-Encrypted: i=1; AFNElJ+j3PdcL02WGPUck1ZEIEAtX8GksrZCLkQgHn6dsws0Z0oFoErHQ79k1kiQUWkqLlpopzgm1/SNFc8AOxw=@vger.kernel.org X-Gm-Message-State: AOJu0YyrprVDM5p/SrMJG8GA16eL65nAXCancVK9FSbN1NPt+y7l/waB vD5HGRBrXs8uVVinFmqk/tUOc7ThaeCe3ipDHYb1W9AAB/GYEXCbuRNdJDl7gQREiycpKjQ0A17 aohz4WZ27olvQ7/+yeJCxIM8RL3I9Vew3AMMe2hPBgf1XHxYmlkhQRJrwj8mGDMywIQ== X-Gm-Gg: Acq92OE7gU3tma3jnHYrDACgYanJl04c4eOE+SgnnUcN7t5sfCYi9rHFURAXm2FlfCh 5iBrtcBXcKSIA4VrdDU4pIfIlXpF2JNUSIyMsGwqpQk006EphP1l28OeZPwqpD14WSrzBGgNyMt IoUHQXZ2yL17gghEplA58gFIfX1JCaKbYhthuC4t8nY+h55oMokMnFwNNYhHAhV3qs7XMigY3t3 fBwzOgJI7Uki8zliaVb6oLT/hzXaHqnXEOsWugccyQbmPQBVIVmjVuN3GnF4SvsKlM5E4C9AxCh ElkEOZZ2AO6iWdF3IjNY46hnHp0L0A6PjCAJjGkNjP15f6gYelhDASE6C9t6hME1oTa7spxmM70 /z2PBZodz5Mm4t6mj1oZ4UUj1yC2xYd+tKlj7FTCKheFZHjOJc2uMyquc X-Received: by 2002:ac8:7d89:0:b0:50e:631c:c390 with SMTP id d75a77b69052e-517fe603999mr208597501cf.44.1781541746707; Mon, 15 Jun 2026 09:42:26 -0700 (PDT) X-Received: by 2002:ac8:7d89:0:b0:50e:631c:c390 with SMTP id d75a77b69052e-517fe603999mr208596931cf.44.1781541746125; Mon, 15 Jun 2026 09:42:26 -0700 (PDT) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-517fb7dad16sm112174511cf.21.2026.06.15.09.42.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 09:42:25 -0700 (PDT) Date: Mon, 15 Jun 2026 12:42:23 -0400 From: Brian Masney To: "Rob Herring (Arm)" Cc: Michael Turquette , Stephen Boyd , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: at91: Read "reg" with helper Message-ID: References: <20260612215251.1888345-1-robh@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260612215251.1888345-1-robh@kernel.org> User-Agent: Mutt/2.3.1 (2026-03-20) On Fri, Jun 12, 2026 at 04:52:51PM -0500, Rob Herring (Arm) wrote: > The "reg" property is an address-sized DT cell property. The AT91 > compat clock parser only uses a small bus id from it, but reading it > with the u8 helper does not match the property encoding. > > Use of_property_read_reg() so the code goes through the helper for > "reg" properties, then keep the existing range check before passing > the bus id to the clock registration code. > > Assisted-by: Codex:gpt-5-5 > Signed-off-by: Rob Herring (Arm) Reviewed-by: Brian Masney