From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D39323AA4E1 for ; Mon, 15 Jun 2026 19:08:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781550540; cv=none; b=ZN7MzCTqYI1YdxCBE0GL8wiOpAr9A05KJY/o/Ki/DnxwMN7LgudU/vRopAiG1m2vbnU9qONMeqqRO+/PaVpIKD+ClCpDdBaq/nMs+PfBWZXkuCgTM2E34XIF6c3Q34t1NOYcDw7E41orx6RqIbUWq7XcLklVoH6fhlgalwY28lY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781550540; c=relaxed/simple; bh=EvoJ3aDtZ4F/C8Kr9wphawKCAyi3l8ODysFcMsfBdGc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=T+RkXhTIhWZ2I5nHkFZm+QUFbnnVT+cqKyQMrzSMOAqV0uYQpS1xFK2u0Yji5jkELUCmFWkmKP4ZGZLIIoLvMDo64QJoWDkldgp4hzz2LVKK1MB/deoB1j2FNfUhZraQ7/eeAbKd+Gt2Jf0jeSdUz+H2JxWQLHlU8lT4NYQpLiQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ETarz34O; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ETarz34O" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2c0b1a48855so11565ad.0 for ; Mon, 15 Jun 2026 12:08:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781550537; x=1782155337; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ISqMLHuxmmME4HG1iYeuq/aT+EEs3k5ypriNOeJFwpk=; b=ETarz34Obq789inNl2pics+fHINA3Gx16qKzeiY9T0eqGMZQWo4H/n9KfwSxzM2PC8 Nz/2Ac8IgJa3RMZAOr6TyNnmPd7lvmNDxFw8c314bfo1cl+DKZU9rBV1T/s7VheYrJ0l g400EEgReNo7S/Ox7a5MtRjfBoeFei+GKjSrGmebvtU0rKO4oHoW0Y8O9LTpLGXXtwKH 2gMsGKDGFagEyeQ/2TmC1XjCRa/XkK4MkRgsSN2lxP9s1ZlnAZnE5HAhiWFss8E7L8pG 9il3rn9l41D0SvO2AqquwEXml3fxtzzj/Ym6TcR4l/fFm5GkWb+6GkFRCuiu9dJcJKce 87lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781550537; x=1782155337; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ISqMLHuxmmME4HG1iYeuq/aT+EEs3k5ypriNOeJFwpk=; b=MgIJBt54sC7Y7jXHz0MFIAzZnGdGgf4uU1e1c+lLBwHeiAhxm+V3g/0zsp2MI4BMYk tZx6bAT8Yz94v48/gIn0NK1ThTsSl2/4LX+56wGlbIzi43aGAKaxKBM/v2Dwhx4p+0qM tAvwmuutV6hKG75emSHl7q0qiWUY+quCTTH+9a7bAgcvtL6+iN7/AWD2yNCl3bKMN3DM rSNPDHe0bxz39IQRgfk8AYCgjSIRYBNirORu8Zy6S/HGE2w07DKEqhjDYUawXvep6lEt v9cbC33Bms69PYlu3uAYpPBedKu9XnaG/WiC8lKHdhFzG4kF+5T0saE7LYrTuCeDAGF4 +L+w== X-Forwarded-Encrypted: i=1; AFNElJ9LVgKaue3T8I24S4pERhU/s5MjXLAx+Frz85rWHw9NjSwv50+oIVq6IraWUez0fxQcQQhy918DGFsCpd0=@vger.kernel.org X-Gm-Message-State: AOJu0YxAfPJJlaYrhziwxx74mgjCc2cPU/ZtJJvvlP8Y/J7LGxh83BC9 qh1NAKArboRW2WUSK4tpNJWdX/neNSPy+kAkued2Xoc5UgZKvxSq3XxVmBjBwuJxYw== X-Gm-Gg: Acq92OFWfSuYGr3ojhAK9dDUjwFQnXYce8duR2cUvwq91oSI+vp0xG8xx3Ote3RfVdS GED1jri2TV8J79GqQ4tvdUQUwwNYedakyrtRFlxAtgF+4zI2K243jDGw9UbHwbIfjcqoxuemu7n igsdxl9WI14dVANM0dOM5EOYAR60+COtWt/GBcSJhM+J58tb6iT2XSzyzE2Q0o+KxfxX6Z5FclN OtrV0+jwtY/jSle8DalXRVO9ahic58biltV8p3HW+XWQ1cwHy1ZJHfC+K3l+s4+ca152AJFma60 SoUmWgT8Eq1TgHuUkcYcsJd5DIz0eW81t6sufavPIMAP194m9UrNJBwkkShAykW+DH0bX/YbE9J 1aNENUr1R7SvTBY1H9NzWmxnHPlTSsPyPzGy99CQU3/cZT7dWQzeZPsZpxK4CwhRLjGa2VDR3yU 4/m7q3TzohJneecEgdOVJECW2GTF72hZWV0EOCjFz5CF87x2OF1EvSMA6l9yU= X-Received: by 2002:a17:902:d584:b0:2c2:2485:7086 with SMTP id d9443c01a7336-2c69a3f43e7mr514035ad.17.1781550536841; Mon, 15 Jun 2026 12:08:56 -0700 (PDT) Received: from google.com (62.101.197.35.bc.googleusercontent.com. [35.197.101.62]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37c5228ebadsm344889a91.10.2026.06.15.12.08.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 12:08:56 -0700 (PDT) Date: Mon, 15 Jun 2026 19:08:52 +0000 From: Lisa Wang To: "David Hildenbrand (Arm)" Cc: Miaohe Lin , Naoya Horiguchi , Andrew Morton , Paolo Bonzini , Shuah Khan , Hugh Dickins , Baolin Wang , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, rientjes@google.com, seanjc@google.com, ackerleytng@google.com, vannapurve@google.com, michael.roth@amd.com, jiaqiyan@google.com, tabba@google.com, dave.hansen@linux.intel.com Subject: Re: [PATCH v4 5/7] mm: selftests: Add shmem into memory failure test Message-ID: References: <20260602-memory-failure-mf-delayed-fix-v4-0-a5bc7db5a9b2@google.com> <20260602-memory-failure-mf-delayed-fix-v4-5-a5bc7db5a9b2@google.com> <6963083d-6725-4081-b2a2-894a0510c6fb@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6963083d-6725-4081-b2a2-894a0510c6fb@kernel.org> On Fri, Jun 05, 2026 at 01:38:28PM +0200, David Hildenbrand (Arm) wrote: [...snip...] > > static jmp_buf signal_jmp_buf; > > @@ -165,17 +170,21 @@ static void check(struct __test_metadata *_metadata, FIXTURE_DATA(memory_failure > > case MADV_HARD_CLEAN_PAGECACHE: > > case MADV_SOFT_CLEAN_PAGECACHE: > > case MADV_SOFT_DIRTY_PAGECACHE: > > - /* It is not expected to receive a SIGBUS signal. */ > > - ASSERT_EQ(setjmp, 0); > > - > > + case MADV_SOFT_DIRTY_SHMEM: > > /* The page content should remain unchanged. */ > > ASSERT_TRUE(check_memory(vaddr, self->page_size)); > > You should likely use "fallthrough;" ... unless you are missing a break; here. Thanks, will fix this in the next version. Lisa > > > -- > Cheers, > > David