From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03C2C3B2D0D for ; Mon, 15 Jun 2026 20:20:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781554841; cv=none; b=tB9+OfV3w0KnbqjmyYHmlNQWESfe87V7zv5F5uL6lbihCJR/+ieMqJPr5GiqjUiBBrPLMydpUyJMT0Sx2hogsx/oUMoxbcOZn6y6ERfYG+hM4XluOJmtelW3TEwkiPvRIvL+Q82ag+O1BImAthmLPONwZGp0k9aQYgRordRKS2o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781554841; c=relaxed/simple; bh=TB32LhnDXfTJUQ0KhV0DDq8feI4v0a+HUW9AsVhyJdY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hA5h6oJAV6kvdQ+KGdW707+hfY2CMjipckO1DLlAfZ7WRvxK46NmPObE+8hVEnAlqJBezj+aaXhCJPM/f6vESEUuS+U83lf2s7GLJ3tM+SPTuSqXQTdoAdUkBM9CDZryGlP6kn9trgiU3K7b2317tWmT7bSTC+gRxUuxa3zJyxI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=vNTveM76; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="vNTveM76" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-36d98b68d68so2531809a91.2 for ; Mon, 15 Jun 2026 13:20:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781554839; x=1782159639; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8ynJ3evPKTv+CHJxYf+R9sPicm7rQMH20Hi7EX5GWIM=; b=vNTveM76TEMCSRUshuxZaW48EjNLGh6Ln6suviRcRPJzFhgEiE6DDrImXx6rhXWqZq lKvF2dtcX0RKpWaeiz9imfVLoXkQGrTKi9prUWq/BA5LKtXQ6qbTStp1pzQSUO7j1fBa KJxMKYuFDY4HjLXt2CIiNFEDq+2uFiEWnmo02HGo/tpoAdXLdh6iSkSZ4AItvGKSb8Mu kVBCrLsyuip0I+yj5E2Bfz2Iqz0bSYXreDG48D09IJ3iSWT1MARgtsRBdGPgqb3O7Jfn ags4vSnZ+4bY+Mty/ELtGHTYWPYx/096SbHXH22qItXvmqQq7g/2IDcip+x8k9zciPXi suOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781554839; x=1782159639; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8ynJ3evPKTv+CHJxYf+R9sPicm7rQMH20Hi7EX5GWIM=; b=TwqyhvnZ4JlLHQmt8rb/C5yiviko1B1PICJA4j+w1d4C2KiBa7uOn6wuBxUcvms6Ds OfXe1LEcLL8bAhEW6gbBwFi3ZFGblOy+IeHU5FdT2hXzlbbvaKjg/rfDLf7fBYfenF1K kTZizykwJPOANuUzTFL/x1r3ordyKvbAtGpwfya16NcVVpoNHrxA2cEsLYYLoz4aLuhL C4HEwx6M1vygl5KM3mnNtbCp9K8c6Sr02YW4FNDg04p5ZIcf/JVsn4PxK/OrmX6ebGch ofiUwoXK4d9MKSJuuO32XftoIlnhzXOGp+NwzSr5lZAGWYjpFotOLQ7QSWV/P1IixN1J R2QQ== X-Forwarded-Encrypted: i=1; AFNElJ+FbZTEWZOjxqCHWSt81cL+nYCiPwq9eORr0Ni6J7wMs+DNYEh1sdCRbOv1ezeYa5eNZParO+hjyMV+97M=@vger.kernel.org X-Gm-Message-State: AOJu0YyJxQ7PIqVXALxcvTaCxmLMjXyIVHfNQohrd7yO/HIBKg4nB64k FGRkRus04VT57WRnRHRLnk1kY6OdxYeEobcllo1tHJBC37JyVV7XvgGAG9z1vr0tRQ== X-Gm-Gg: Acq92OHXCdpLSfx8450Hx3DnvduvkFQstE7T9Z3p092fQQSg9LwS8rO5mTyq51VbLFW QeSh7uXdXsmmIqpU9L00tT1r8lElQY2fmVorFdPQhnnA6N75yP3qXnXBTlLiNJ0MOSVNiLqEkNg sTLBNRyVMU1sSbXfaPYng8DiPisOlZU9eWRII5PiYnmYei2w++Lcj42R9PmZ5qISkCD+VZ5HVRV 3q7btJVQN1fTFvP7rnPKMyOqpohqW8F9TYsdxmzTVcgBVw7/HiFvgrk3REI+uphgylfAmBO0ARI 6nosPZnmegTW1qQ0UL7IL89n+m2u4KafLQcrnUIiS8xGdgqiFH/pWf/6KEMvjDvTay2bBGonW5x 07UVeNAOZNOtwefIcQcYCfekaGmAAmgRkzUaVWIhZ+dTQ8BPKqFX4XVXxrr2yT8omCPCphoid7h 30C7PSDywwrC7vdxbjyAV9FkhmqgKmttpCxKX0QQC43069V4zXVVZr7VSuACWylw== X-Received: by 2002:a17:90b:2f05:b0:368:6998:b4a9 with SMTP id 98e67ed59e1d1-37c2bc7c378mr12049662a91.11.1781554838812; Mon, 15 Jun 2026 13:20:38 -0700 (PDT) Received: from google.com (56.149.168.34.bc.googleusercontent.com. [34.168.149.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37c521d96ddsm470060a91.6.2026.06.15.13.20.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 13:20:38 -0700 (PDT) Date: Mon, 15 Jun 2026 20:20:34 +0000 From: David Matlack To: Pasha Tatashin Cc: kexec@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-pci@vger.kernel.org, Adithya Jayachandran , Alexander Graf , Alex Williamson , Bjorn Helgaas , Chris Li , David Rientjes , Jacob Pan , Jason Gunthorpe , Jonathan Corbet , Josh Hilke , Leon Romanovsky , Lukas Wunner , Mike Rapoport , Parav Pandit , Pranjal Shrivastava , Pratyush Yadav , Saeed Mahameed , Samiullah Khawaja , Shuah Khan , Vipin Sharma , William Tu , Yi Liu Subject: Re: [PATCH v6 05/12] PCI: liveupdate: Keep bus numbers constant during Live Update Message-ID: References: <20260522202410.3104264-1-dmatlack@google.com> <20260522202410.3104264-6-dmatlack@google.com> <178144546090.1266136.8524338598480624580.b4-review@b4> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <178144546090.1266136.8524338598480624580.b4-review@b4> On 2026-06-14 01:57 PM, Pasha Tatashin wrote: > On Fri, 22 May 2026 20:24:03 +0000, David Matlack wrote: > > diff --git a/drivers/pci/liveupdate.c b/drivers/pci/liveupdate.c > > index 4f2ec6ffdd16..2421bc218916 100644 > > --- a/drivers/pci/liveupdate.c > > +++ b/drivers/pci/liveupdate.c > > @@ -103,7 +118,7 @@ > > /** > > * struct pci_liveupdate_global - Global state for PCI Live Update support > > * @rwsem: Reader/writer semaphore used to protect the incoming and outgoing > > - * FLBs, and the references to them in struct pci_dev. > > + * FLBs and references to them in struct pci_dev. > > This change does not belong to this patch. Yes, will fix. > > > @@ -396,6 +411,72 @@ static void pci_liveupdate_flb_put_incoming(void) > > liveupdate_flb_put_incoming(&pci_liveupdate_flb); > > } > > > > +bool pci_liveupdate_scan_bridge_begin(struct pci_bus *bus, struct pci_dev *dev, > > + int pass) > > This function requires a header comment; it is public and not self-descriptive. It is private to the PCI core, but I can still add a comment in v7. > > -- > Pasha Tatashin