From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43B3F3B47D3 for ; Mon, 15 Jun 2026 20:24:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781555048; cv=none; b=BH+9OhhMEYLLwCdZ9N6w8n7M4uwupVIje+cA1saY4UjefgpFrdPHCTenY64O5tv1dYG0ujG3V0BxueP3eLUpv04nV5B/GqwOnYYT12o1ZqYOgo7ZQq6pZrMDvlAqMjg3HoCA8PlrAvmos9queKXrennuiUlXTfdDctkeKl5W4V8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781555048; c=relaxed/simple; bh=0d3Q9EbyPKqeUyWtc8aAHAoQPF7n7Yp21m5ECSA4Yvo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CZjR5OwulNaBnH1WXubFHfUNGtOVrX8EfR836GpnfkneEOQ2EWIqeXQT7NYo/8Kt+umvkbcJa60sxWw38OIE43EMrhakMxxfm2nDvQrnWSkiXqdwXB4Pl/1HpYluOXihNk77hilh9m4SWclYJRWyqlZxwJrXJA61OQX9iHQ57bw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fV/3h+j0; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fV/3h+j0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9BD71F000E9; Mon, 15 Jun 2026 20:24:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781555046; bh=Xv0Xx+sFyQZR8z3JaDBhEyFdVXsngUf/nfHDbi4YiMk=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=fV/3h+j0lk70GkTZNTi89QESWOs9EdwFjGu/Gp3wY9R+HHRRWdlSKPLT3P8WzxX9H dlyxag3Z5yJpw7jQBZpIfV/NpqHBlTkl4y6gNd/o0OKOL8HuO1qyoDkYBNCwCeI4MT 9uLhs6NbcWWyu0D0sXNZcBk6IFmWZCNKlVG3gHppg7DS+iWayYRZ1rkRzT6yZ4n0az ssWcvzxVh+dQqiJXHGl3FNFLEJNch6J5WxR2aQ5AWLE8yxEIDnBVwNekq/upp7Q/a6 CAhHCaCx946ZyjXo5D2X1ar0bzli4zUCrRUe3Lfqoaguzb35+adlAr0fOj+WNWEH1W g5jlrvBseLHFg== Date: Mon, 15 Jun 2026 20:24:05 +0000 From: Jaegeuk Kim To: Wenjie Qi Cc: chao@kernel.org, yuchao0@huawei.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, qiwenjie@xiaomi.com, stable@kernel.org Subject: Re: [f2fs-dev] [PATCH] f2fs: stop checkpoint on compressed write IO error Message-ID: References: <20260525061456.231710-1-qiwenjie@xiaomi.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260525061456.231710-1-qiwenjie@xiaomi.com> On 05/25, Wenjie Qi wrote: > Compressed data writes are accounted as F2FS_WB_CP_DATA because they > write compressed pages through fio->compressed_page. Their end_io path > should therefore have the same checkpoint-stop behavior as ordinary > F2FS_WB_CP_DATA writes. > > However, f2fs_compress_write_end_io() only records -EIO in the inode > mapping when the bio fails. The filesystem can keep checkpointing after > that failure, so a later checkpoint may persist metadata that points to > compressed data blocks whose writeback failed. > > Stop checkpointing with STOP_CP_REASON_WRITE_FAIL for failed compressed > F2FS_WB_CP_DATA writes, matching the ordinary data write end_io path. > > Fixes: 4c8ff7095bef ("f2fs: support data compression") > Cc: stable@kernel.org > Signed-off-by: Wenjie Qi > --- > fs/f2fs/compress.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c > index caf522d667d6..9b1501004456 100644 > --- a/fs/f2fs/compress.c > +++ b/fs/f2fs/compress.c > @@ -1488,8 +1488,11 @@ void f2fs_compress_write_end_io(struct bio *bio, struct folio *folio) > f2fs_is_compressed_page(folio)); > int i; > > - if (unlikely(bio->bi_status != BLK_STS_OK)) > + if (unlikely(bio->bi_status != BLK_STS_OK)) { > mapping_set_error(cic->inode->i_mapping, -EIO); > + if (type == F2FS_WB_CP_DATA) It turns out the type should not be F2FS_WB_CP_DATA. > + f2fs_stop_checkpoint(sbi, true, STOP_CP_REASON_WRITE_FAIL); > + } > > f2fs_compress_free_page(page); > > -- > 2.43.0 > > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel