From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 487353B2FC2 for ; Mon, 15 Jun 2026 22:56:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781564176; cv=none; b=NrKBIoUEI7AWGbm0GWPqbEnOGCtVyUds6wxgqui2+pKAEZgCN2kR8GMMHMMsRkj5EVfC/NVISHjJ5yAoT9zU4QjWs8SQTXdTVfQGkNEFzo5t09DrIxjyEDfxulnkzdRJCC0KGGVRVf7bg43TYF5jfUK+t3IBCSFNX0oKsSoGDmo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781564176; c=relaxed/simple; bh=bDkXPecrv7ZD+FnW3wIO2Ni0wOvcPxYqaM51+iZCSsM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qvZCWA1UvISp4dG9Mpq4RdzZDJZxl7dDYCSV4ddTUrl2T0SFPGUQZSkBPzdN+m+j8f56kgISgjLCr7r9yz+TxrTRCRJ4DDcB5J0xp6AS6UoaLZ2rJZY33ZQDYqVGE+bOhYRrr3RyxZyDHlo17EAHp5K6ytVjxVDui14y7L0RTNA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=H8HaN0Cn; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="H8HaN0Cn" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-842273a2c4dso2605543b3a.3 for ; Mon, 15 Jun 2026 15:56:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781564174; x=1782168974; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BVwv2TVfPysI3DzUdG8f9hUqz0gPu0HPnolOP2DEioU=; b=H8HaN0CncxAG7X855lzwTAVlZ9eW/ymwNWXHfB/ykA1mLhC9gSdgPLpooPuaGcLRIe mgZ5gIzjmQAbkK4eW+N2VqEys1k33VSnUDDMnaHBPyq889Al323Rbs6flbIPwtVm4L4F GQMaWagDQCU/7DHpeCqoJ2UglNCDS0oupTYbJAY3Gj7YSybYPs6rRrYmJkWyftTPnbBd ctF6xjNG22vmz9Atb/ENmeQvwLTf03/9FYccirRziUZ0qd07lAh4kl2SeokWDpnDpfSH A41QNMOsebevvBHWihskDgvL0Ja0sgz5/bskl/8RyjovfWywkXBShLXW9fOd2ALMZcST Idbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781564174; x=1782168974; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BVwv2TVfPysI3DzUdG8f9hUqz0gPu0HPnolOP2DEioU=; b=NeAPWAUGI91Id+s6kGvo63KADdNVfoWR7zMBY+4PLmNeU3635SnAJhyGYWrn0aZ3s1 QGm+UIK6xDH6I4CpSHOZaH10VN4vrHPl2qz9cCHn7RdSyLatxdMzZfk/snEzpAje558P JVHOOK05cbveZ0CaEocxqBntQeQie6TZyZIsNS2J4/GPOHxsETCrd+yiq2KPU/A5CUmR kBBu0WxMJOlUE4jP1mZ2FJ5e/WIUar6ZhfZDz4ezZZ3lShV8Ks+5B7hIctuI5P1e2dsi KujZsfEN8hdHzuNEbhwAcyF7DOVBEWFVt9/ajGhRLqacXue7urhvMA7yG7Hu+s3r6HJz QLuw== X-Forwarded-Encrypted: i=1; AFNElJ+5fyIki250agqldbSlGJlBjzYkI6T3YclWz02t+8iOg2mIdHmgygWlnOOWQkJVbG/HwregM1TIoKhzKfQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyAqQWgf/G1xYd4XMQiVk3dbp5P/WTQpfLPRflkocgnkceJ6xWW SSE0/ByX24SNhlJkm6VkUde8grIfGKzK0UKBpK8jwDhdaYodIObAE8PowKGiXDfhrg== X-Gm-Gg: Acq92OFdTPa8AJL9BjeMEcFs9JefrWz+rGPQuK3udsPmuG5uEk+o8F+/WHViazPq/ZC A/q3piAGehX7ob/vdFxa0H1V7APYoRBGcjDXPRsUOJDaE/vSrqEQCvExhW0lIXlnzArDE0sfpMz vHMzw8yUNu3f2IoEtfl80BneCFt5PL3WK34CTzcf9qSaFcDACLVp2jPjfQba3M+SkQNTCNBemPE MKoDpI/Nf7cseoPM5e3YkE3PM2amIs5hbjdiclDqT2sqSXgOEmsmHXPQiRM6FConUZoR+EWObR/ +i6rOQ9sNQ3F344B64jzAkQhtvpJY0eGZx1CNV9mgZVvu8vPyaNrqguTWzaQZNXL3WPV02L5mWQ wGc0MsSTDZ2emUZkxNu/y6NQczqVHakmgQ7GxxAcFxr+1eZha6dK61K9tr22eURI5iVnqpNR0cD coiZIesNflVRRKnGcmceyDqGY/5uVdNzQ2u7RZ71D8c3+O7ioZyGNIow0kKyZCaA== X-Received: by 2002:a05:6a00:3927:b0:842:6004:3fce with SMTP id d2e1a72fcca58-845155f7ba7mr756200b3a.26.1781564173161; Mon, 15 Jun 2026 15:56:13 -0700 (PDT) Received: from google.com (56.149.168.34.bc.googleusercontent.com. [34.168.149.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8434ac9df57sm11362003b3a.7.2026.06.15.15.56.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 15:56:12 -0700 (PDT) Date: Mon, 15 Jun 2026 22:56:09 +0000 From: David Matlack To: Alex Mastro Cc: Alex Williamson , Shuah Khan , Raghavendra Rao Ananta , Vipin Sharma , kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan Subject: Re: [PATCH v3 2/2] vfio: selftests: Avoid VLAs Message-ID: References: <20260615-scratch-amastro-vfio-selftests-avoid-vlas-v3-0-b3798415c72a@fb.com> <20260615-scratch-amastro-vfio-selftests-avoid-vlas-v3-2-b3798415c72a@fb.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260615-scratch-amastro-vfio-selftests-avoid-vlas-v3-2-b3798415c72a@fb.com> On 2026-06-15 12:44 PM, Alex Mastro wrote: > Allocate VFIO ioctl requests dynamically instead of using VLAs. GCC 11.5.0 > rejects initialized VLAs with: > > error: variable-sized object may not be initialized > > The replaced stack u8 arrays also do not guarantee native struct alignment > for the aliased pointers. > > Fixes: 19faf6fd969c ("vfio: selftests: Add a helper library for VFIO selftests") > Fixes: 20face8c75ff ("vfio: selftests: Add helper to set/override a vf_token") > Assisted-by: Codex:gpt-5.5-high > Reviewed-by: Vipin Sharma > Signed-off-by: Alex Mastro Reviewed-by: David Matlack