From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B226D79CD for ; Mon, 15 Jun 2026 23:18:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781565490; cv=none; b=OGRFJT9q3kbrG0BWe7pE7XkhIcDMNg9NwQowE3axPdlH/VlE0Sqxuwt0difnY30Ubbj/V9LZQxZ/UxRsSfKIDcmve0Tw+VItNRggG7ylT4Q+ewiDlO2dKjPUX+HPS5CrWZY8IGJk8ChcpOKev1WoNcUxDwxIy/Qv0dyd/z9crmw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781565490; c=relaxed/simple; bh=1GcEs9TBS6irw+neqn3bWq/PpQaZkycM4UYW8z1vx6E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hz2RKjozsjKFgm68TbdSaRMbxRk6zPXYGqK1c7DwLIejB0fy+DSHSEM+KJ5biCf8lZIKuIVG7in4yg1UxgG/bCQNlOp65RrgWpdxv3ZPFhAKdYOM+S7cboyVMivIEVx49Yt5ZzerteJt52HFiRj1IrZWocQ1g6+xYmDtDxegTxw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=EQx2Em9z; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="EQx2Em9z" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2c0b1a48855so24405ad.0 for ; Mon, 15 Jun 2026 16:18:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781565488; x=1782170288; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=k2l4mkkLLimCM4pi/KAoPVgTmhgqbCjkATKF284xpI8=; b=EQx2Em9zrB99uk5i2waL0dnuZqyyyKCzrmHvR+Nt4paT28xZD6zMnzoSRvQnUr+r4s cKi+hFlwmCXq8hnmhS9/dk7BecLvh/EQzLWaWlpsh9y6FmAlCgOkuNFuogc1Mbzz+EZ9 Ka+lb/5tACPNsAaApzARBEJE9PhsXVVzijIaPpakNulYN9kA8WjexTSdDPJ5vQgIQ8iw XkKIbS9rdjyhNNkajaXdZgTiC4bnamqRGk9rFwlbWga06ZRcybBPh82fnPUipUrCVQzX uY8pQ/L52isEAfeagaBdsQOl7/5gKfIlRetHMpDWRWqsh/umzSNrXTx3mqHLpIplvpTo yn7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781565488; x=1782170288; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k2l4mkkLLimCM4pi/KAoPVgTmhgqbCjkATKF284xpI8=; b=JVFKOtrEr4Tbj/SmeY/7wtinTcGDppAw2YIQKXGIym0fdVrSMXl7KrjHlzoTOu5QcJ hcRTsEK8q6IjlIJKUeKlgygNJZbfyHbhkGjT0BEAcuO4zgpweUamuNAp5ifwMj3sJJmP Ing4drPoz50UYoxsyY9G5TASapXUIitE8R9JkoQpg4EmpG+f5156SFFih7lQ3HRZ3SL6 1NdmsC5Fkw4jl+S3MUQMIG1Ishd3RkETH5//prP5l4clJV7UFz2Sv4Okj2cmGOUVgjvI xaHXpsKEA66OuBYm/Wh+lpBsHhZEISAgzzWz/C7PXogkGJKQG3S25hICGdyD3rv82SRc 4s0w== X-Forwarded-Encrypted: i=1; AFNElJ8emvY4nU10awOU6op016fo95kSUfTWdDz9DUqI2qXgKBi22UgLQeYAT9LHgdK/ttAAFmQnFFqsYWYgdWU=@vger.kernel.org X-Gm-Message-State: AOJu0YzKPQ7rVmq5FVuZbzdT0MixZQymJWPz/jsLsLk0Y+W8tCiNJeF7 sLO/OAAQgYSPk8jj/0H449fRiRnfoRl9auy6BXAjl6GZjizP+GipOW7NiqR8pE75OLViDrrHY2m KYDj8fg== X-Gm-Gg: Acq92OGHkI2VVUv4wM//NSWuXCeUKgzgXzdBmkx/fKi5sY81xq5SHBnc1Z00G1At6RC vLksDw+xGITm7FQX0njwTMVYi3gECvG2P4cK2zZTJYKAeP3co/WQh9P5FKlTVRMeVNaztlTro+4 aV54XM5hbuZOII1UzfbTVm1wcahUrEOj3XINyK5dnYC5AtSsL0ok/uQPB9rQWrLXEQxl6lnAlDk qHZpNmfftYNe0lLAlm82mY2VtExj5+PZ7pQpNW4hL+3ZNi8OrrRreHPZVWAHNLg1ExklzH5byBW triCpYegZe/6Vyz7e8r8XV5c3bCxJ0VSzAntfIRhDgw6oGTC6LiWPpOjNaIsLNn679zi5gtSk5t 5Vg0m3wDgie/zyms5cw/OQwFdCJCVMh73XXjpVMEzvFszpTwSg7YS/5XBnmJmQiNuPymuMGs4lD s/AXX3ZFqJ0GPd61Chpp6r5ce4LlKtTtyt87YfyuMw6ohx2LrUbvq59RC4x3HY6Akn6egE43M= X-Received: by 2002:a17:902:ef02:b0:2bf:139c:dcf3 with SMTP id d9443c01a7336-2c69c30a460mr423675ad.19.1781565487498; Mon, 15 Jun 2026 16:18:07 -0700 (PDT) Received: from google.com (199.255.142.34.bc.googleusercontent.com. [34.142.255.199]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c42f7c6511sm103213235ad.24.2026.06.15.16.18.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 16:18:06 -0700 (PDT) Date: Mon, 15 Jun 2026 23:18:01 +0000 From: Pranjal Shrivastava To: Nicolin Chen Cc: Will Deacon , Robin Murphy , joro@8bytes.org, Jason Gunthorpe , Shuai Xue , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/arm-smmu-v3: Declare eats_s1chk and eats_trans as host-endian u64 Message-ID: References: <20260615194533.3290010-1-nicolinc@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260615194533.3290010-1-nicolinc@nvidia.com> On Mon, Jun 15, 2026 at 12:45:33PM -0700, Nicolin Chen wrote: > arm_smmu_get_ste_update_safe() declares the eats_s1chk and eats_trans > locals as __le64, but initializes them from FIELD_PREP(), which returns a > host-endian value, and passes them through cpu_to_le64() at the use sites. > > Sparse reports the following warnings: > > >> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:1122:38: sparse: sparse: cast from restricted __le64 > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:1124:33: sparse: sparse: cast from restricted __le64 > > Declare both locals as u64 so the type matches FIELD_PREP() and the > existing cpu_to_le64() at the use sites performs the host-to-little-endian > conversion. No functional change. > > Fixes: 7cad80048595 ("iommu/arm-smmu-v3: Mark EATS_TRANS safe when computing the update sequence") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/all/202606151017.QU0evpH9-lkp@intel.com/ > Assisted-by: Claude:claude-opus-4-8 > Signed-off-by: Nicolin Chen > --- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > index 8ce3e801eda3b..4c0f7b17b1f37 100644 > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > @@ -1240,9 +1240,9 @@ VISIBLE_IF_KUNIT > void arm_smmu_get_ste_update_safe(const __le64 *cur, const __le64 *target, > __le64 *safe_bits) > { > - const __le64 eats_s1chk = > + const u64 eats_s1chk = > FIELD_PREP(STRTAB_STE_1_EATS, STRTAB_STE_1_EATS_S1CHK); > - const __le64 eats_trans = > + const u64 eats_trans = > FIELD_PREP(STRTAB_STE_1_EATS, STRTAB_STE_1_EATS_TRANS); Reviewed-by: Pranjal Shrivastava Thanks, Praan