From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1930B1F0995 for ; Mon, 15 Jun 2026 23:33:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781566438; cv=none; b=ZpeFmk4mg1YupBhyjiomIxrfWT0fDXsbVpZAuCuAZ4WVdBMRnLvz1Eln9s1BKrY22RLFAuiku/lYGWiH87CZH64cMN0XHsreNfWB8l/ERSWW/Z12N5Vr9IJMjURgRt2LVgOhvWIFWyH5enP65cuKqloztxncS/tgIbpoKgAP4wk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781566438; c=relaxed/simple; bh=wkWq1YyQe9HfMn5h5fwETvev7LwtmAAMc8+W6YYydmw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AyJNh5KvKmZbmjunjpJ5JjUb1IZogppHVnZUjXKt+Hc5gDPQQ9IfhRBfDyJxJFCiaXGuv/t6+n+B/QlJfNmpLb1omiWF2Ru2l+0S4WBnvBldw/wL6eEJfdljf1c1KFVrokjEbKO3FOxq1qz7VK9fsT31pqDgbjq3olIExl9L1v4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=XAp0NZoD; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XAp0NZoD" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2bf2d865383so12845ad.1 for ; Mon, 15 Jun 2026 16:33:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781566436; x=1782171236; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7RZpXrhOisaz0Hy21Y75kOiIkZX6dkWHiipcMDxVBGY=; b=XAp0NZoD5l1PgFxMpubiNVcwO9ElOcTTqhX+narwtcVZO+DUd82mBQYyQwKMxjuwO9 TKdw/T/3+ASzaVaG/NJi+Ghs3b9vnJYLBFoUf3VNfaZR2fT/pJ95QOOr/u/hwkFkjbgG H65+9hof3ziKy2GkymwmN64YsZsYQo60737v6UWaARPxI2eJHs7uvSbRFmBB34Zf1DHU BCofUzJ/NlGcIJppxAAYgXdRjSX3ZYu94tqD5lVMSjcqLe/shcdOD81Q06nc0wNvVcX9 u+bO7+qaFPP31xLcum84kTqfey5p3bleLBBA2HQwrmdQsd28fBNxNU18LbjDmkSG27km WFlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781566436; x=1782171236; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7RZpXrhOisaz0Hy21Y75kOiIkZX6dkWHiipcMDxVBGY=; b=qiCwrf/GAii5xQnMv6YpGu4FvCaouWwcfKEly6Rq7sOXRFULhzdHVslhtFgyHNszfz 0qRoq9ThWBLXz3UhRWGNMU8cwBaVAe7sqMK3SzrLqjmInyGvz60FyILEm6ggLFwnI2Bu KI2Ige709t1QgpRrZFimiK4FKIA5Mwc1lD11+PNxM/Rc6qC+JCXw+FO6OxmVSBbNUxWn 9MitfO8qNHD2SDSwiqBWqCctz6mAY7uoJ9Us2q7FgIFAB4OomOia/2tXmkNHWlQ92VqU 279AHMSSy/Ho9S5gYZ9mDCQqWn0BACvqcmIufF60ABeGKkPtUdTWuBqhC1lg8DNUMGbX GYNA== X-Forwarded-Encrypted: i=1; AFNElJ86qOu4sxvbSDuEzQ01DIZgDg4iBdMsYiwUs0LkbKar3q+Z1lMNxluLn1GEE9UbCUUyd9KkkE/7LnxbbKY=@vger.kernel.org X-Gm-Message-State: AOJu0YwVRDEDAb/RUjC0uyQZbC/x+S0byYBAs4YOkK54PpgyD25JJkUI r6SANRTf/5lyRHRdOHwAlqIGXwVLnInZ4idqK2Fvw5TX4mYADT4wcz+0DQONyYGbsQ== X-Gm-Gg: Acq92OFOl1wBbph4hH8tTxa7UgfesNEctYS63Bai7SnlJaE7KjNgYeImwIr7JAhS/C9 dEgjPtFY5KhhIekxiv/TB096O/Zp1XgKRSOLvWekeksJ6yAG8OMNpwAkebytJ+erBce9gqbp4m6 80APIL6tREzR3yfSDuiC3ztPjxFvOre02DjM1VE1xXzupjOY7Auj70wUAdK3IupwuBoc9y226Cn o8qAknESiM4cN1m5H2TCOAl3pnhQ92N/tcK/FolSSA5d7uarXaMvif+oAZowzTUaMz1ZqFPlVeC 8BSituGbdrOaAPM9q5ZVWwRx5pKr5P5b+uS51QB0MWu/Wul8sSdjOa06leKxNbw93/ol95nFdz/ LN7ziHvf+SOLvTlRNADSaajeK3BjlHkUsbI8Dabor41oo/X8R9iKyivtSD9RgXdQX3GqS1ulgBK 6KHx3+Uj6hRUas6k3L4LLS2xbKASHQas0p3zpqez86LPXmewIxwhHjOJ2n X-Received: by 2002:a17:902:f541:b0:2c1:4228:3321 with SMTP id d9443c01a7336-2c69a2c4cd4mr979115ad.12.1781566435833; Mon, 15 Jun 2026 16:33:55 -0700 (PDT) Received: from google.com (230.0.127.34.bc.googleusercontent.com. [34.127.0.230]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c4327ac631sm112076765ad.44.2026.06.15.16.33.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 16:33:55 -0700 (PDT) Date: Mon, 15 Jun 2026 23:33:51 +0000 From: Lisa Wang To: Binbin Wu Cc: Andrew Jones , Ackerley Tng , Chao Gao , Chenyi Qiang , Dave Hansen , Erdem Aktas , Ira Weiny , Isaku Yamahata , Kiryl Shutsemau , linux-kselftest@vger.kernel.org, Paolo Bonzini , "Pratik R. Sampat" , Reinette Chatre , Rick Edgecombe , Roger Wang , Ryan Afranji , Sagi Shahar , Sean Christopherson , Shuah Khan , Oliver Upton , Jeremiah McReynolds , kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v13 03/22] KVM: selftests: Initialize the TDX VM Message-ID: References: <20260521-tdx-selftests-v13-v13-0-6983ae4c3a4d@google.com> <20260521-tdx-selftests-v13-v13-3-6983ae4c3a4d@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jun 08, 2026 at 01:57:24PM +0800, Binbin Wu wrote: [...snip...] > + } tdx_cmd = { .c = { \ > + .id = (cmd), \ > + .flags = (u32)(_flags), \ > > + .data = (u64)(arg), \ > > Nit: > The two lines' backslashes are misaligned. > > > + > > +#define tdx_vm_ioctl(vm, cmd, flags, arg) \ > > +({ \ > > + int ret = __tdx_vm_ioctl(vm, cmd, flags, arg); \ > > tdx_cmd.c.hw_error is u64 and it could be assigned to ret, which is a int, > the upper bits could be truncated if the upper 32-bit is set. Thanks. Will fix these in the next version. Lisa > > + \ > > + __TEST_ASSERT_VM_VCPU_IOCTL(!ret, #cmd, ret, vm); \ > > +}) > > + > > +void tdx_init_vm(struct kvm_vm *vm, u64 attributes); > > + > > #endif /* SELFTESTS_TDX_TDX_UTIL_H */[...]