From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Pengpeng Hou <pengpeng@iscas.ac.cn>
Cc: Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/chrome: cros_ec_debugfs: unregister panic notifier on remove
Date: Tue, 16 Jun 2026 05:53:20 +0000 [thread overview]
Message-ID: <ajDk0KvY61EU7S86@google.com> (raw)
In-Reply-To: <20260615063200.43185-1-pengpeng@iscas.ac.cn>
On Mon, Jun 15, 2026 at 02:32:00PM +0800, Pengpeng Hou wrote:
> cros_ec_debugfs_probe() registers a panic notifier whose callback
> recovers struct cros_ec_debugfs with container_of() and can schedule or
> flush the console log work.
>
> cros_ec_debugfs_remove() removes debugfs state and cleans up the console
> log buffer, but it leaves the notifier registered. A later panic
> notification can therefore call back into freed debugfs state.
>
> Unregister the panic notifier before tearing down the debugfs and log
> state.
>
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
For my reference,
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
prev parent reply other threads:[~2026-06-16 5:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 6:32 [PATCH] platform/chrome: cros_ec_debugfs: unregister panic notifier on remove Pengpeng Hou
2026-06-16 5:53 ` Tzung-Bi Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajDk0KvY61EU7S86@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pengpeng@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox