From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1D231FFC59 for ; Tue, 16 Jun 2026 12:40:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781613633; cv=none; b=oefVLRiF+a19YmJmwy0JKeg6GNu9G4kgmAmi35L3cKY+fNuyGp8/2xp3WblOlD0sGEoLqCestKX22OxeVIKV+1bT6slUT6pwNBRcOBleBQS+7IF8AdxQV8i9Mj9MdkgIRmysUlvlQdAhBBS3oOB1bfHD3jQrwis9usiS4SV/WX8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781613633; c=relaxed/simple; bh=+zYPb9QpAEwlhsEkXT18Zv+K7ppCzOTN3pVgB9pUMBQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qzZgbj7OGunihtE7R64tURy8U8chCmZrS+RDaP6Jky14WD/VSxT2dF+D1GtU4IWgJtR3vzWLoQ9pDYPK6m0ZM306I5TJAV04wJEdDKu2r+bCRSy6fBmVL6rndgz3xu8qNO6XJTE2DDscjEseFiFgRhqJYYEC/Vrav/2cFyM2K4U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=wgg33lkV; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="wgg33lkV" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-490b4a8e28bso33673695e9.1 for ; Tue, 16 Jun 2026 05:40:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781613630; x=1782218430; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9bkaQdVB1icoUbZrrnd4GITgcdZYxSW0MNtl1DcuHmc=; b=wgg33lkVgBcHCw2dmcnr0M91ogUMETgr8ykOvRryjl3mYMr9Z+V7EwykB2xfpY+A/k y7HineMeNqbR0dnCgKNRC6BLTMxWR1idokTB0z419IeZjRP/QSVO/1IslkFyyGZ9Ck+q c1gMURcNy4uAIocrRwyDWfzST+jT+6wuS5V+d9lybh1JsX7w4fyl8LxXSVkiFTyGOAcv 5bSnxK5xbPlOYw60/iyyF3vFt/+dzWUpDR8nGK5sGYhgs7qAubXkQPLUsLVFqCzA8mZD c55cTh+gT3l3DjpGHgCZ/ZjgDiaEw9wHlG0DA6AQRctJ7tbKcgsOB30wvbjFf8ylOGeB JLig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781613630; x=1782218430; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9bkaQdVB1icoUbZrrnd4GITgcdZYxSW0MNtl1DcuHmc=; b=FG+bqC9h3o+Wlh5SA4nNd2VVQ+Uuny1o2pQ53F77EvxZF482Ol2hX6H3vxDjRK26cc N+SeSMWWpGBrijwurr5VP38/+vKL5qxcXxa8qVIRBQxOB18noCSZSJw2uGM+sRdjOfTj COAWIyF8cruQQqFyV0z63f84WHfY24M6newsT9i+rlFb+RDlYEKnRg1MBPxPnI3caujN EWkmyAUooyWYu5FqF61trhNjrd5q5pQ3Ba9QgntoTbNOG+8FfD2DlXxqZme82rJ6PD9N ft1DsWtKpMPhjtyt9/d07FKOJn2FyD/O0LSq+wrrNpz2sR7MLRDrgBvcPRxGVOaKnA0i C9TQ== X-Forwarded-Encrypted: i=1; AFNElJ+J5kE5ey+L10AXMEV9L/gLFaKsjXYBozRHKjjV8SoWVljLNiRNTcfQ2YAdexG6YKL0GrQmvTCi5vLhm9o=@vger.kernel.org X-Gm-Message-State: AOJu0YybMyvrixpxuL8tj+NsHmabd7RKftQyE96v5lvYu+s4Hs8rrI6B hilusNMc9uRwZsY9Vvyn0+c6PKOPDkjW2zPWaPlLPyiR49323M5mGw1AVYTRVEKBuQ== X-Gm-Gg: Acq92OG58zZ/oIfbZIpcVJSz7ni/PKCX0KFsOqpryZMApXSOz3+8eghuJQUXU6mZkgk nCwueQgwylCnaQ+aYyWio19EFIWs4by4qfX0YKqXOHXPM31MLGOLEd4VWP07S4KcDIatw5DVz4H Zi1BJdMIYos/Tr8tqhm1wYE0uSxieQ63x0FU3mP/RetNttXDkjKxj8vBeb2NSvmJmlHczhUq0eL m9tsaPKlJJ6OPAK93F0Yi+TrbHAaKXqU706Zbh4ZPmkanoOvhEsGNKxOnk5wadgy7gBcy3bDBN+ I4WWQwwnEvacc0J3kRMvbtuzpwva/5Wn6FMnYooGibquMK5YLtfUaE820v9b3wK6YG/EFHaNOF4 R8tYYW88e5VwyS4e+5+yFw78pu4wnCHxmvK03K8zmjQKBQ23sRawaHeBD+yHs68s//pwh66s6Oo GXjGjaw4521mk1YdDJjxN4TYW+Y6+qA5DbytKGCGP2a99xry7SKUsGh1jCVXlEziEWHgY= X-Received: by 2002:a05:600c:1396:b0:490:c032:ae92 with SMTP id 5b1f17b1804b1-4922ffc87c1mr50927645e9.33.1781613629590; Tue, 16 Jun 2026 05:40:29 -0700 (PDT) Received: from google.com (135.91.155.104.bc.googleusercontent.com. [104.155.91.135]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49230a96d14sm54054125e9.12.2026.06.16.05.40.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 05:40:28 -0700 (PDT) Date: Tue, 16 Jun 2026 13:40:24 +0100 From: Vincent Donnefort To: Sebastian Ene Cc: catalin.marinas@arm.com, maz@kernel.org, oupton@kernel.org, will@kernel.org, joey.gouly@arm.com, korneld@google.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, android-kvm@google.com, mrigendra.chaubey@gmail.com, perlarsen@google.com, suzuki.poulose@arm.com, yuzenghui@huawei.com Subject: Re: [PATCH v3 1/7] KVM: arm64: Support FFA_NOTIFICATION_BITMAP_CREATE in host handler Message-ID: References: <20260616105417.2578670-1-sebastianene@google.com> <20260616105417.2578670-3-sebastianene@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260616105417.2578670-3-sebastianene@google.com> On Tue, Jun 16, 2026 at 10:54:09AM +0000, Sebastian Ene wrote: > Allow FF-A notification bitmap creation messages to be forwarded to > Trustzone from the host and introduce a helper to check for SBZ > register fields. > > Signed-off-by: Sebastian Ene > --- > arch/arm64/kvm/hyp/nvhe/ffa.c | 36 ++++++++++++++++++++++++++++++++++- > 1 file changed, 35 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/hyp/nvhe/ffa.c b/arch/arm64/kvm/hyp/nvhe/ffa.c > index 1af722771178..b1e5f9ee86ef 100644 > --- a/arch/arm64/kvm/hyp/nvhe/ffa.c > +++ b/arch/arm64/kvm/hyp/nvhe/ffa.c > @@ -71,6 +71,18 @@ static u32 hyp_ffa_version; > static bool has_version_negotiated; > static hyp_spinlock_t version_lock; > > +static bool ffa_check_unused_args_sbz(struct kvm_cpu_context *ctxt, int first_reg) > +{ > + int reg; > + > + for (reg = first_reg; reg < 17; reg++) { > + if (cpu_reg(ctxt, reg)) > + return true; > + } > + > + return false; > +} > + Hum, there's something a bit weird, as this function was introduced already in the previous patch. (and both have the same number) > static void ffa_to_smccc_error(struct arm_smccc_1_2_regs *res, u64 ffa_errno) > { > *res = (struct arm_smccc_1_2_regs) { > @@ -676,7 +688,6 @@ static bool ffa_call_supported(u64 func_id) > case FFA_MEM_DONATE: > case FFA_MEM_RETRIEVE_REQ: > /* Optional notification interfaces added in FF-A 1.1 */ > - case FFA_NOTIFICATION_BITMAP_CREATE: > case FFA_NOTIFICATION_BITMAP_DESTROY: > case FFA_NOTIFICATION_BIND: > case FFA_NOTIFICATION_UNBIND: > @@ -862,6 +873,26 @@ static void do_ffa_part_get(struct arm_smccc_1_2_regs *res, > hyp_spin_unlock(&host_buffers.lock); > } > > +static void do_ffa_notif_bitmap(struct arm_smccc_1_2_regs *res, > + struct kvm_cpu_context *ctxt) > +{ > + DECLARE_REG(u32, vmid, ctxt, 1); > + struct arm_smccc_1_2_regs *args; > + > + if (ffa_check_unused_args_sbz(ctxt, 3)) { > + ffa_to_smccc_res(res, FFA_RET_INVALID_PARAMETERS); > + return; > + } > + > + if (vmid != HOST_FFA_ID) { > + ffa_to_smccc_res(res, FFA_RET_INVALID_PARAMETERS); > + return; > + } > + > + args = (void *)&ctxt->regs.regs[0]; > + hyp_smccc_1_2_smc(args, res); > +} > + > bool kvm_host_ffa_handler(struct kvm_cpu_context *host_ctxt, u32 func_id) > { > struct arm_smccc_1_2_regs res; > @@ -920,6 +951,9 @@ bool kvm_host_ffa_handler(struct kvm_cpu_context *host_ctxt, u32 func_id) > case FFA_PARTITION_INFO_GET: > do_ffa_part_get(&res, host_ctxt); > goto out_handled; > + case FFA_NOTIFICATION_BITMAP_CREATE: > + do_ffa_notif_bitmap(&res, host_ctxt); > + goto out_handled; > } > > if (ffa_call_supported(func_id)) > -- > 2.54.0.1099.g489fc7bff1-goog >