From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C1AE3612CF for ; Tue, 16 Jun 2026 13:00:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781614848; cv=none; b=M/MfuJkHFeZSaEHVvspdMcxT7zXJ4Fr7TRGWeX2O3pJbnlZHAY4XvXUOP7Pp0m5Nk+H18cyCHe8ctQnpDQwf4xM44tKjuYHGFLVBZ3thJuUzAIeRqWkurnC8c9tVTkXFZ2LQ9QBvBtd4Uym1VTYQWd6ZMOTitu38Gi00JleUKz8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781614848; c=relaxed/simple; bh=HI4KSffIIgwA5GJ8P55nt6IdxSCSSHhQf83EuNz/dhE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VuFMB/qwYLn+jDSN8d8FleqSwvos+ZjBQTkhLbXbH8QVIMbP2OksTxAM7jxORSBh4zWz8rXA0gSyYzqscr+YzJfOWv7Bg4U5Vxnfi/zxGJubvIoR0iV6FNEDbzp9bJ7da/idh94zVb5v8LBrowo1c9ZXT1xqb5X5kyLoJevhPCc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=loPOW52j; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="loPOW52j" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-6913fb25322so5861744a12.1 for ; Tue, 16 Jun 2026 06:00:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781614846; x=1782219646; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wNTSMzgRJmXIzWcqWEqDdC42PhcZeRCvxhxGiPL0LsI=; b=loPOW52j5qlHSmx450XiSkKgFcktqmlbyZs9N+CR7plUXfENmYjCZl7ULXVmaOpIFl iXn6G6w/pgV+pJmKx3nxi1vPO4grsfOXbrSCPy3l5dnpuefehcXootfdOncLWbpH19m/ ViiPSgZHGr1c/RFqT+IDakqrlA1X4RAHvrbeAZlxIICUxlnjT1prUo5/MZmnNMb+scBq QL5Bv/YZn8ErIN6d5p8O2bwO6luO8827oUMwm3pHToEHyFTxFkcNqFqDnWKI65QMbIEV 3gQmWwHW+rXctq0YQhn4cWb8Xjg02jrgikiIEJk/6DIr/zR0JoZ9xqvXlz+eU8dFRax7 n95A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781614846; x=1782219646; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wNTSMzgRJmXIzWcqWEqDdC42PhcZeRCvxhxGiPL0LsI=; b=HNGuqP1MDVX0LPl4uf3dkEFWPd4NFXfQPi2Qs0rIwNd50WU5X5eFCcbxUSo5Bp9FaJ aVzvmGtTgBbzwM1mTZafCok2Mz+gmm1j6rHy7ifJ2AV1XZrn2SPOf46rEMWMqX+/olwu oUi4+aXcDf6DOPdSwAQTpGr4NGPUzZazPOi+Ku7bbe0lzhxGIOFhBRBavLCIBgxSxu82 ZvNlf6qHByEiqx1oZaalucuxvsCOtDWB3gpfeuKIePR4CtrIBX841LNvaVBgv1fMzXrB eaJ00awew24hXntOIH4A2ixo7sNC0aUn2K29F4CLyScdc7TKgQa4nwdBlOmBwah6jaXJ Ml6A== X-Forwarded-Encrypted: i=1; AFNElJ9dMdInDjsu3fc7lbCj1kw5ijeZiYF8eFo78dQj9wPJ5NFFbIqof9qjOTkrsDs6eKHAshEaFBptiAeOIDY=@vger.kernel.org X-Gm-Message-State: AOJu0YySSYN3x/GTZEiwV5vM3C3WsiyWbjmVUdBPADYjlr5DCEnsCkat s+2q7yt1nwe1G95EiwQNShfpCmIlzIBriTThd3nZq6XqY6o8tTKXU8+fEVNqp4k3/w== X-Gm-Gg: Acq92OGQtNupmilIu+jEdX0OhOYEy4ytkylZz3ofSz5B3e6Dwd7JezzE0VdYdsEM6dE iHY55fAjmecxrWdQPleo0Vw5qTLlvviS+A0emJ4+LoQFO3He0/gEIKk467viWmOYYwbKNpvorFF otDaG7cEJmlJY8NjHUvbOSWfajO1NKUCxZk7p9OxmmyahsFRTSOGqCBDlxUb3VVbMp78vvBenDR Jts8Idmu0VBmR0K2QRBX7OZHW9qV35rKxeKh97AtWamGar4qfZmCJO4ihX6MJX53pGQat9jgIns Ennaz9qXcij9YW2GjxBNXQhG8Q98QUaFDRlEHWKD65omMSTFPMRcg1QbXpvao52NpaY/N6hHzdP 33E1a/AKIdrTgiKWT6fFzWVvFi0zPyODf4jN722R+gex+l8N+WhgEoDji75TwNxJA7yODY/yhQV zTmDppm99pMXPA3Vi478er65vqBXjYVeNKeyqo1kL7zHNf+EJwGD3PAywPGiQh27FLJEM= X-Received: by 2002:a17:906:f5a0:b0:c04:1973:cdd1 with SMTP id a640c23a62f3a-c041973d111mr250472566b.36.1781614845012; Tue, 16 Jun 2026 06:00:45 -0700 (PDT) Received: from google.com (135.91.155.104.bc.googleusercontent.com. [104.155.91.135]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c03ba328d6dsm214905966b.49.2026.06.16.06.00.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 06:00:43 -0700 (PDT) Date: Tue, 16 Jun 2026 14:00:39 +0100 From: Vincent Donnefort To: Sebastian Ene Cc: catalin.marinas@arm.com, maz@kernel.org, oupton@kernel.org, will@kernel.org, joey.gouly@arm.com, korneld@google.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, android-kvm@google.com, mrigendra.chaubey@gmail.com, perlarsen@google.com, suzuki.poulose@arm.com, yuzenghui@huawei.com Subject: Re: [PATCH v3 1/7] KVM: arm64: Enforce strict SBZ checks in the FF-A proxy Message-ID: References: <20260616105417.2578670-1-sebastianene@google.com> <20260616105417.2578670-2-sebastianene@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260616105417.2578670-2-sebastianene@google.com> On Tue, Jun 16, 2026 at 10:54:08AM +0000, Sebastian Ene wrote: > Introduce a helper method ffa_check_unused_args_sbz to enforce strict > arguments checking when the hypervisor acts as a relayer between the > host and Trustzone. > > Signed-off-by: Sebastian Ene > --- > arch/arm64/kvm/hyp/nvhe/ffa.c | 47 +++++++++++++++++++++++++++++++++++ > 1 file changed, 47 insertions(+) > > diff --git a/arch/arm64/kvm/hyp/nvhe/ffa.c b/arch/arm64/kvm/hyp/nvhe/ffa.c > index 1af722771178..c723a21006aa 100644 > --- a/arch/arm64/kvm/hyp/nvhe/ffa.c > +++ b/arch/arm64/kvm/hyp/nvhe/ffa.c > @@ -71,6 +71,18 @@ static u32 hyp_ffa_version; > static bool has_version_negotiated; > static hyp_spinlock_t version_lock; > > +static bool ffa_check_unused_args_sbz(struct kvm_cpu_context *ctxt, int first_reg) > +{ > + int reg; > + > + for (reg = first_reg; reg < 17; reg++) { Hum, should it be reg <= 17? > + if (cpu_reg(ctxt, reg)) > + return true; > + } > + > + return false; > +} > + [...]