From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF92F32B138 for ; Tue, 16 Jun 2026 13:27:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781616429; cv=none; b=dK1NyxwNKyGK3vm8F9/lF/dRGO4odLtJVJZ9HlsqI844+yVsLxQGlvX5WGdMQaszRnNWJebUdeDO6pVsnK5K52ahnf343RDCn8VjDi/wKn+0IvITv3eWtbOw+UY7LCdiyrUS1Zp3eqTYHIJIcneNAUgAlbIreMy8PDt9ddFymZ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781616429; c=relaxed/simple; bh=nCGZq1Y/w9q0pTP9FjapDpvlqsG0F51qx/wH2o1R7Ic=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=d3jD2nkZPx5DD6O4mFuoSjV066oQs3H6mx3T/9/xBqjT7693i2UcV8adEmP9fKfR35U/jqdneuP4UzXyNG7mlqNesZYWTqW9lXrOIw7WFOeLX55c7LliBGXjGx4CfE8KceNjqDFro1vJxaPnrTVTVXcLzxPAvtv+mdyzJL/iz/g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=IEIZnm03; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="IEIZnm03" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-692491fec0bso7691850a12.2 for ; Tue, 16 Jun 2026 06:27:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781616425; x=1782221225; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YK1mdYovXCET+aePqJYcxlz0Er7guRuMQroVpfBxRaQ=; b=IEIZnm03TMiwig1mDnwc4Nm2cpY2S0MtllLl3ncPzPzLjohha6kTfJNdZWuTUgQeOq Sr6jFlG7+Pv/Xr1WA65nrD7umrG+e0fG8u6vpsVWw1yVtzq5zLDaduj1lDGy1Gd1Wjfj nsyPK6Sn4S3dkJ87PeTEtC7qupLLGV/xrKazrR5uvsHdB6Yf89vzitOR/dT3pKM067SH wf49VIvsl09yFUcp78vtYIxVEvp/H7nQtpOUXCMd/UlyXDDUofdQ84WzgN3ZNfeYu+aM 26RKtDmp3fL4fAbxGmCzNBPhJiM6XlvPPLoQ1pzj+2HmnYnq3b2BegP4JVHY0KznQ+/w hW/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781616425; x=1782221225; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YK1mdYovXCET+aePqJYcxlz0Er7guRuMQroVpfBxRaQ=; b=n+v8A1Kja7Q2e4IZd8tns2T2o04l+Qvz1M61yQ6/r5z7hGOU/cd6MfhuMmuMvmzNPo ClIUDozBvwXqZP2y8E8Ae4k2U5zyq3MKuD4gD4qaUBP2nEVhwwPya7TAXM/J91ny1N0a YqSuwIaLxvuTzv1XX8EIK4k6Vld//7NltUpwWj9LUVPiaqOEcmMRfG56QZNO/WrsaS0K YfXVoc0Ih1Z58QqL0zuuiZOuiAlouGd2yWlugB9epK9ESog4cfxK/O5KH7kSq59NfkkQ JVBCkDuOxMFasGzZcL2WJyPjxNjIIY79HA/LxMRM+/mI9mVf3SncWSETUOyOIZXXKbow GcSw== X-Forwarded-Encrypted: i=1; AFNElJ+dVDYwuAKa4oAUfz00IIYzgUr9wIVLT2T1ilMz69L79q4qrR0v9NqRc6B7uhol/yTL5u3sHw1Cl50aUfM=@vger.kernel.org X-Gm-Message-State: AOJu0YwFZAKWWFPGtHeuwynUDx8XAbNi3jS3JWBSqqmM0azENN+rlNLO q+4d6DJpyfTeXLJuFnnxajS6JnQnu/zWccUtEoEp5hp9gQ9b8qCaK2PQm0qwqSw8GQ== X-Gm-Gg: Acq92OE1Y6lFCX7xA/LEiFA3C/VyaTT7icw6s9n1fRiaUVEOz+tpZYM/EoUE/mToB0x XGzRkYs768Fd7/6ByFe6B3L4ekCxhplYXMt7P2DGdO0z0uSCA5xzak/a7Qx/TuWRGE5J2V2wyxv TGnmfjtz+ItAlcTH+FY20fgWYNZpYEQd125yGFlILNwDW/HJOm3aaG2kP/eyVuFBKbf60K7DiI9 ns5fD2smgkwjI91uwexr0A985zXFHj4F8VFfGKDLlawKjyTOttil/jO8W3trL0jkxyH4AMfqRfP SoIqort/sGeKBdXzQLGNDK6GCEVl9+1H1SfNgOKy9HktLjKim0VUi6FSWdI3/24VceY2YMrKuOr qJ8lBK1fAgi4StR9cNsM9JPrn9qKC0fI43gkixPGnZq2dbtnopaxq/kkOzRxcQYtMxzenir8ngQ oKktMQPzZm8r0qAcxVvcr0e0kE+SI0Nz3hp81RCUaoKwVNr2IfOM6KLO/KDHeXITqFrNw= X-Received: by 2002:a05:6402:5d0:b0:691:706b:183a with SMTP id 4fb4d7f45d1cf-693788fb0c2mr9398945a12.6.1781616424703; Tue, 16 Jun 2026 06:27:04 -0700 (PDT) Received: from google.com (135.91.155.104.bc.googleusercontent.com. [104.155.91.135]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6937938a524sm5111182a12.18.2026.06.16.06.27.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 06:27:03 -0700 (PDT) Date: Tue, 16 Jun 2026 14:26:58 +0100 From: Vincent Donnefort To: Sebastian Ene Cc: catalin.marinas@arm.com, maz@kernel.org, oupton@kernel.org, will@kernel.org, joey.gouly@arm.com, korneld@google.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, android-kvm@google.com, mrigendra.chaubey@gmail.com, perlarsen@google.com, suzuki.poulose@arm.com, yuzenghui@huawei.com Subject: Re: [PATCH v3 6/7] KVM: arm64: Support FFA_NOTIFICATION_GET in host handler Message-ID: References: <20260616105417.2578670-1-sebastianene@google.com> <20260616105417.2578670-9-sebastianene@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260616105417.2578670-9-sebastianene@google.com> On Tue, Jun 16, 2026 at 10:54:15AM +0000, Sebastian Ene wrote: > Allow FF-A notification GET messages to be proxied from the pKVM > hypervisor to Trustzone and enforce MBZ/SBZ fields. > > Signed-off-by: Sebastian Ene > --- > arch/arm64/kvm/hyp/nvhe/ffa.c | 24 +++++++++++++++++++++++- > 1 file changed, 23 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/hyp/nvhe/ffa.c b/arch/arm64/kvm/hyp/nvhe/ffa.c > index fcfaa441770d..549250ff8f82 100644 > --- a/arch/arm64/kvm/hyp/nvhe/ffa.c > +++ b/arch/arm64/kvm/hyp/nvhe/ffa.c > @@ -715,7 +715,6 @@ static bool ffa_call_supported(u64 func_id) > case FFA_MEM_DONATE: > case FFA_MEM_RETRIEVE_REQ: > /* Optional notification interfaces added in FF-A 1.1 */ > - case FFA_NOTIFICATION_GET: > case FFA_NOTIFICATION_INFO_GET: > /* Optional interfaces added in FF-A 1.2 */ > case FFA_MSG_SEND_DIRECT_REQ2: /* Optional per 7.5.1 */ > @@ -1001,6 +1000,26 @@ static void do_ffa_notif_set(struct arm_smccc_1_2_regs *res, > arm_smccc_1_2_smc(args, res); > } > > +static void do_ffa_notif_get(struct arm_smccc_1_2_regs *res, > + struct kvm_cpu_context *ctxt) > +{ > + DECLARE_REG(u32, flags, ctxt, 2); > + struct arm_smccc_1_2_regs *args; > + > + if (ffa_check_unused_args_sbz(ctxt, 3)) { > + ffa_to_smccc_res(res, FFA_RET_INVALID_PARAMETERS); > + return; > + } Shall we check that the endpoint ID is HOST_FFA_ID here? > + > + if (flags & GENMASK(31, 4)) { > + ffa_to_smccc_res(res, FFA_RET_INVALID_PARAMETERS); > + return; > + } > + > + args = (void *)&ctxt->regs.regs[0]; > + arm_smccc_1_2_smc(args, res); > +} > + > bool kvm_host_ffa_handler(struct kvm_cpu_context *host_ctxt, u32 func_id) > { > struct arm_smccc_1_2_regs res; > @@ -1072,6 +1091,9 @@ bool kvm_host_ffa_handler(struct kvm_cpu_context *host_ctxt, u32 func_id) > case FFA_NOTIFICATION_SET: > do_ffa_notif_set(&res, host_ctxt); > goto out_handled; > + case FFA_NOTIFICATION_GET: > + do_ffa_notif_get(&res, host_ctxt); > + goto out_handled; > } > > if (ffa_call_supported(func_id)) > -- > 2.54.0.1136.gdb2ca164c4-goog >