From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 355D8384248 for ; Tue, 16 Jun 2026 14:30:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781620214; cv=none; b=KSr3c9ukY+9+TX7QhUVHhk4WYpyKT7kvH7RmozaAO2kWh4azJqkVhygLzVxbMyQQFPu7pYMJquMVp55zZFWXZ+XdLGgctl6P7kATTn/Kl8UsIdyTWuVUCXgr7JWZdeXn1Y5Gg6zJJ4xrugaApunt3X1LcENqaIRVzD4msfP/1uY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781620214; c=relaxed/simple; bh=Pvc8JNK+ktSQxPOt78l79kkSMj1nVhMZrB5rdUQSrPM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lu6MSfPsNXLa7WB+uwdD7jykU6aQlpYCieCL4Ee/Zt83/0EMaL5wJw/4AhPBnh5EYTLR7tZ5UXPAPXQBzdQa0IRGAyAAAPN8wEM6RGJ20Fgv9TDZSa1RdrwgYN2g3+5Yhh9Jx80/viG1UIRMdEDjn1obGVuEFIv2YfJ5vzqjCD0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=R01ax81F; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="R01ax81F" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4891b4934ffso54475e9.0 for ; Tue, 16 Jun 2026 07:30:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781620211; x=1782225011; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sxF4JdKLz/47JU+Sn8F0zfHSo7R8CT604WZzC5dB9aI=; b=R01ax81F1gJjk0CW5lp8rZlm9/FxNm68rUFcDjNR1huj5xQSZVRe6Wt/ROtGr9JbZx eUhauwVNH6+EU8SMnQLzNpoe88+H99mnFuhwFU6VNzgnggpLE5/EbJIPoGsPOcNiNZC4 HdfCxnIAKwaT32sop9onfiJaXIsUFlTTtUeRFxFVGSD38c1C5eJkxxHittrzQPW2G5VO dtSdPZanf2+etVmrsUpVDlRMDeGvOVneR4TxXQ7QqYqm17f6TLCaO/xs2Vf6PR9gM2IP C5nD4pRVrjrhYnnSSel2SbNEIcyv+rJ4VLE0kLXw0q6WcGjsWpDLfGiExRxhLAZ2JY8g JEYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781620211; x=1782225011; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sxF4JdKLz/47JU+Sn8F0zfHSo7R8CT604WZzC5dB9aI=; b=ab0D9ad5AqoSXw65gJEVfS+31MctkMWSo6IOcOh4nUyxHihbQbLCfO4G+PLH1jumDl TrvX/YfCqAUnHH79kUK0fTYSfhVVmot+bBdl5KwnkgfWOEtnhS+uX7YgBhOjKiFyg0iz pavIlTpp1llWU/PIlJPhizoRyyKWmp7BNNCjLUKGg0FxLUInokROgqgJULlRWnkA101E canMD6Flbd11pCIYbvQwiTKikL3PFW18WojnDi7/tW8Ob3GZFKGU3kZjro0EwOAH+iz2 kbGSEhUjXuq+6XPfA0ZDImEHPvajSY7OlIEJk2Dmyed9V9xgIs4apbT/VggTJM2cDRJ2 9LLw== X-Forwarded-Encrypted: i=1; AFNElJ9hdT4TUu6+xxT1/XiMsRV4Ma3zwgGEoVxxJ6gx87wp4odigqyaIvQz5FHNfbBmwfMoi0XLKkAzryKThEw=@vger.kernel.org X-Gm-Message-State: AOJu0Yww3hwUE8rP8kTCfCjRh4qBCjTi9Bgl8+a5wsIeMOnDIidwQpOF X1CuvKvaj3kM51rF211Dys4RVsr6QeeeE1Sa5Y74doxx98KxfMwQHS91BS2KZRz8tw== X-Gm-Gg: Acq92OFoEpQQARqMPX0blhkh1zx5JH4MfuAAoYAkR6Nh7pts0MVaF3jhpD9M/xE+BYP UMR+R+Xkf+oTZ6fkn70rWFBs5H9DEdo4wUwYtuxZpND/pyBHlYSW4RYbPnyuxvx5LNhL/pj6ffo XDp5QD0hq6xLUhwwT+7zEhDlOe040pQNuIYqzyLLvlWnQZyXExo7CKrBALwdXVPpxFaY2ITXwz1 97cvVEJnHPxTgsD3uC3QBsnSD+j0aD7m7u9HUiUxOnj5H/1VT3RgxIsB+I0dVLDkrzQKJ9QttrG rpckz48vfYIgCy6RfkZkCNUy4JljrJwqt/qYTbPeqqo1enlziieQ9OHJt6Z8nBHTs3HVmfKSxUc DsMwWGptTGWOte22MoYRBm3Z0CCyb6FFhWEmbo2wIgFwRNyVAnxTcTSGwNlthFU1LwyHLP9TVof wBXaB5W/lbWN7MmcF9x/jGwmQqfsEXb3ASbqHykTQvC+O1GSlQHG7oTkGnqs8suWzF4FS7NQ== X-Received: by 2002:a05:600c:6dce:b0:490:ae08:1150 with SMTP id 5b1f17b1804b1-4922ffad1c8mr1143425e9.4.1781620210848; Tue, 16 Jun 2026 07:30:10 -0700 (PDT) Received: from google.com (143.11.148.146.bc.googleusercontent.com. [146.148.11.143]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4606f2d933esm44203626f8f.33.2026.06.16.07.30.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 07:30:10 -0700 (PDT) Date: Tue, 16 Jun 2026 14:30:06 +0000 From: Sebastian Ene To: Vincent Donnefort Cc: catalin.marinas@arm.com, maz@kernel.org, oupton@kernel.org, will@kernel.org, joey.gouly@arm.com, korneld@google.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, android-kvm@google.com, mrigendra.chaubey@gmail.com, perlarsen@google.com, suzuki.poulose@arm.com, yuzenghui@huawei.com Subject: Re: [PATCH v3 3/7] KVM: arm64: Support FFA_NOTIFICATION_BIND in host handler Message-ID: References: <20260616105417.2578670-1-sebastianene@google.com> <20260616105417.2578670-6-sebastianene@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jun 16, 2026 at 02:06:12PM +0100, Vincent Donnefort wrote: > On Tue, Jun 16, 2026 at 10:54:12AM +0000, Sebastian Ene wrote: > > Verify the arguments of the FF-A notification bind call and forward the > > message to Trustzone. > > > > Signed-off-by: Sebastian Ene > > --- > > arch/arm64/kvm/hyp/nvhe/ffa.c | 32 +++++++++++++++++++++++++++++++- > > 1 file changed, 31 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/kvm/hyp/nvhe/ffa.c b/arch/arm64/kvm/hyp/nvhe/ffa.c > > index dc7496ec295f..3d8ed829f558 100644 > > --- a/arch/arm64/kvm/hyp/nvhe/ffa.c > > +++ b/arch/arm64/kvm/hyp/nvhe/ffa.c > > @@ -42,6 +42,8 @@ > > */ > > #define HOST_FFA_ID 0 > > > > +#define FFA_NOTIF_SENDER_ENDP_MASK GENMASK(31, 16) > > + > > /* > > * A buffer to hold the maximum descriptor size we can see from the host, > > * which is required when the SPMD returns a fragmented FFA_MEM_RETRIEVE_RESP > > @@ -713,7 +715,6 @@ static bool ffa_call_supported(u64 func_id) > > case FFA_MEM_DONATE: > > case FFA_MEM_RETRIEVE_REQ: > > /* Optional notification interfaces added in FF-A 1.1 */ > > - case FFA_NOTIFICATION_BIND: > > case FFA_NOTIFICATION_UNBIND: > > case FFA_NOTIFICATION_SET: > > case FFA_NOTIFICATION_GET: > > @@ -929,6 +930,32 @@ static void do_ffa_notif_bitmap(struct arm_smccc_1_2_regs *res, > > hyp_smccc_1_2_smc(args, res); > > } > > > > +static void do_ffa_notif_bind(struct arm_smccc_1_2_regs *res, > > + struct kvm_cpu_context *ctxt) > > +{ > > + DECLARE_REG(u32, endp_id, ctxt, 1); > > + DECLARE_REG(u32, flags, ctxt, 2); > > + struct arm_smccc_1_2_regs *args; > > + > > + if (ffa_check_unused_args_sbz(ctxt, 5)) { > > + ffa_to_smccc_res(res, FFA_RET_INVALID_PARAMETERS); > > + return; > > + } > > + > > + if (FIELD_GET(FFA_NOTIF_SENDER_ENDP_MASK, endp_id) != HOST_FFA_ID) { > > "A Receiver uses the FFA_NOTIFICATION_BIND interface to bind one or more > notifications to the Sender" > > Does that mean that if the host issues a FFA_NOTIFICATION_BIND it is the > "Receiver" and not the "Sender"? > > (Same for unbind) > This means that we will have to check the ID of the receiver and not the sender. Thanks for pointing out, I will add this to unbind as well. > > > + ffa_to_smccc_res(res, FFA_RET_INVALID_PARAMETERS); > > + return; > > + } > > + > > + if (flags > 1) { > > + ffa_to_smccc_res(res, FFA_RET_INVALID_PARAMETERS); > > + return; > > + } > > + > > + args = (void *)&ctxt->regs.regs[0]; > > + hyp_smccc_1_2_smc(args, res); > > +} > > + > > bool kvm_host_ffa_handler(struct kvm_cpu_context *host_ctxt, u32 func_id) > > { > > struct arm_smccc_1_2_regs res; > > @@ -991,6 +1018,9 @@ bool kvm_host_ffa_handler(struct kvm_cpu_context *host_ctxt, u32 func_id) > > case FFA_NOTIFICATION_BITMAP_DESTROY: > > do_ffa_notif_bitmap(&res, host_ctxt); > > goto out_handled; > > + case FFA_NOTIFICATION_BIND: > > + do_ffa_notif_bind(&res, host_ctxt); > > + goto out_handled; > > } > > > > if (ffa_call_supported(func_id)) > > -- > > 2.54.0.1136.gdb2ca164c4-goog > > Sebastian