From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f170.google.com (mail-dy1-f170.google.com [74.125.82.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C46235BDA8 for ; Tue, 16 Jun 2026 19:17:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781637446; cv=none; b=JRiboYV1cVD2eTE10VeaLZHodBe7hjMm32PkWVf84+N33KcUWrTMbXJkItVQXcydPkgKNlXSfgdKgpPuMXfIB7seGiXXns13iu60Rnr1CAVaREne9M5HpLIo0yTC7OERgcEQ49qVWpGsInV+V6t2BHZRmNDb+RkKU0O5OrA1MtE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781637446; c=relaxed/simple; bh=JJYTTjkksJKuvApYhzKEoSa9mLsNiQ0WHtwYRFZOoww=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sK5zA8dLVcjPrZgPdRz4ZnYZee2a+3utGHpCHtV3Ixvi3T2e/yPOVYmXLtPvKOSZTw0QY/1QUQQx3Qptd3ScXN7hy3GV/H/zFksHwxuFS8M4fEBHkQI8ChjqCb2AOIeX/WEHYO1or7nnFx606XESMOMzTAiByzxZAipToUPriBA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EJdNW9T6; arc=none smtp.client-ip=74.125.82.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EJdNW9T6" Received: by mail-dy1-f170.google.com with SMTP id 5a478bee46e88-307631dbfedso10493787eec.0 for ; Tue, 16 Jun 2026 12:17:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781637445; x=1782242245; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hI8CQ7iIs183Bza7pfsOzCiD8tUmxO8qZugpjjwhilU=; b=EJdNW9T6tixA32vKpg3MWx4K+BAr7XcscHaCSn7uI1qQFwEVJZP4ezl8Pu9FEVUkqB EZKPV5nJGLY+C7TzdeQ2VNeTrKm6ja8OxXdsxaXHVMPYMLj7FSXlJdL6rPiybm4H1T5j ke2I8RfKsmy0OGcLS+scLOn969oxIRRmqQ6WU6TgyswGIodnaBYnPmN0Wotyn4CBzQkm WLn4iOfw6C3qjQbiZwy2MaXcJIya2Yy8hmlLImhTOZnnh863i1XI9i2TfHqvA4Da5OZx n8ofsoBXZGRK0yZHYRZwRY3s0E8olOFdO65Fw88W3jMzeHUGin6QrWv4aZEZ4B4oMbmN gSRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781637445; x=1782242245; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hI8CQ7iIs183Bza7pfsOzCiD8tUmxO8qZugpjjwhilU=; b=U1GU7nRcmI91vuqnNuIZnNIBKB5V43wmHBUKBTthz88REGtcwyDBRU8Z+C2hoCo7YQ 24XMkeCZG6JazbcGdCzIPrhcAq7iVbkk326qf/SUBGdJgTpEtbZn6u90SNHYXtdBVsqJ ImZ26fzKfxwwNhzw0b1Nu7Vvq1tU6CTPnBmdJa/761Axnac1G9K2PVUCyqlimv1XrXpC vjMcbfWz8qRp2YIgx6LJJzGudiinvjjiSl6bos8xQNLgldleFD4AVWmMBmPQjND3WKxw /4sdadmVf3E703Muw1NA29PgtOif5j7rR5Zt6ndeQv4mYStuetDMzVp68AjInskHvcwn l2LA== X-Forwarded-Encrypted: i=1; AFNElJ9s4DCaYYzENyye14MaNfkC5Sh55wDwY6+oPtlLdmfo08ZWrnVlAEJNGfCZYQPO3UtvX8aV4QSDEH42J88=@vger.kernel.org X-Gm-Message-State: AOJu0YxW/u79KMfROdVXU+WbOB2gqg2GkMvqAW3RFRh2e1/kVweYced/ ps9VKmeKp0Oeh35qdwapYMGt8lySdr1+M8qkwZUBAQaGfw0cZXw94sm4 X-Gm-Gg: Acq92OGavMQfUA9w5qPPItaUvXF6HMVWOItQfxVr4Me4kW/MqwA9bXyuG1ajaeXZkWi 3Kn45hGk2XP+NJIYBi1QwcpH6ZdrAQlrQ84tcI9VOm1Yeg27qzR0/NZjgedDq4ndELJN56zwrwH SYxHg3HOILFa8IRrtsaQIgMq2pYeRfMSIm5BOmny9uM/zHVVM+YoeupZlhi+T4ugmSU4zy+8pxI gqeZEW/0rd39qY0XZDHB3AwU/y8reEgWmqA6oBunWmxYFIm3D/v/mYySCwUpIOK5P+9fnJIY8ON r9KraAnBb589ZY6cA4oeWr+JHmUH9+FWqy0h86KKQwlNXhg7qO8h5JvP4evSW1Dc04+vPbUulRO cz13REIfxr9EH4BYdF3f+DQmdp3brCJYj3MCg575K/8NTTwVx+W7QoXErPB1/cTC0cxJuOPRykF c0dyqKU5Ndfn456C+SITTdxhMVknlUozyolDi3tvcVoAoj2HusxmWpIS4DScy8Bo8= X-Received: by 2002:a05:7300:2153:b0:2ea:3370:6e51 with SMTP id 5a478bee46e88-30bc9cbb744mr374150eec.4.1781637444500; Tue, 16 Jun 2026 12:17:24 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:cbae:d24:189c:2cb9]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30b6191bf9asm14518352eec.31.2026.06.16.12.17.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 12:17:23 -0700 (PDT) Date: Tue, 16 Jun 2026 12:17:20 -0700 From: Dmitry Torokhov To: Jie Wang Cc: Henk Vergonet , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+039eab266c6321a174bd@syzkaller.appspotmail.com, syzkaller-bugs@googlegroups.com Subject: Re: [PATCH] Input: yealink - stop URB resubmission on completion error Message-ID: References: <68bba4fb.050a0220.192772.01a4.GAE@google.com> <20260616110440.1073059-1-jie.wang@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260616110440.1073059-1-jie.wang@intel.com> Hi Jie, On Tue, Jun 16, 2026 at 11:04:40AM +0000, Jie Wang wrote: > urb_irq_callback() and urb_ctl_callback() resubmit each other's URBs > regardless of completion status. When the device returns a persistent > error (-EPROTO), this creates an unthrottled resubmission loop that > starves the CPU and triggers RCU stalls. > > Stop resubmitting on any non-zero URB status, following the standard > completion pattern used by other USB input drivers. > > Reported-by: syzbot+039eab266c6321a174bd@syzkaller.appspotmail.com > Closes: https://syzkaller.appspot.com/bug?extid=039eab266c6321a174bd > Signed-off-by: Jie Wang It would be good to have a helper like bool usb_is_permanent_error(struct urb *urb, struct device *dev); instead of having this "switch" in all the drivers. It also unclear whether we should not attempt to re-submit the URB on errors other than ECONNRESET, ENOENT, or ESHUTDOWN. > --- > drivers/input/misc/yealink.c | 26 ++++++++++++++++++++++---- > 1 file changed, 22 insertions(+), 4 deletions(-) > > diff --git a/drivers/input/misc/yealink.c b/drivers/input/misc/yealink.c > index 8786ed8b3565..bbfa1a9c23d1 100644 > --- a/drivers/input/misc/yealink.c > +++ b/drivers/input/misc/yealink.c > @@ -414,9 +414,20 @@ static void urb_irq_callback(struct urb *urb) > struct yealink_dev *yld = urb->context; > int ret, status = urb->status; > > - if (status) > + switch (status) { > + case 0: > + break; > + case -ECONNRESET: > + case -ENOENT: > + case -ESHUTDOWN: > + dev_dbg(&yld->intf->dev, "%s - urb shutting down with status %d\n", > + __func__, status); > + return; > + default: > dev_err(&yld->intf->dev, "%s - urb status %d\n", > __func__, status); > + return; > + } > > switch (yld->irq_data->cmd) { > case CMD_KEYPRESS: > @@ -452,9 +463,20 @@ static void urb_ctl_callback(struct urb *urb) > struct yealink_dev *yld = urb->context; > int ret = 0, status = urb->status; > > - if (status) > + switch (status) { > + case 0: > + break; > + case -ECONNRESET: > + case -ENOENT: > + case -ESHUTDOWN: > + dev_dbg(&yld->intf->dev, "%s - urb shutting down with status %d\n", > + __func__, status); > + return; > + default: > dev_err(&yld->intf->dev, "%s - urb status %d\n", > __func__, status); > + return; > + } > > switch (yld->ctl_data->cmd) { > case CMD_KEYPRESS: > -- > 2.34.1 Thanks. -- Dmitry