From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f170.google.com (mail-dy1-f170.google.com [74.125.82.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 052753D890D for ; Tue, 16 Jun 2026 19:22:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781637740; cv=none; b=lWCr4yvuCudqdke+kg/w/EOgyMiFBgm9Ja2tNHUtzg9iHpquMXJLp1jDDhTQP3NXvhq2NHxxeOptP/VDiF7KtDz7e2Y95R+kZBSTecmOeWvNq3tc3chj7V4F055U5i/6y83DUPz2ZauEb6hbT12w5yxZdSfRVokEJUM1JIWrvc4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781637740; c=relaxed/simple; bh=CzrTjRh8aVFApgaFvhsZxWUfS7HpvI2aH47+Qzw6otE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=q+2AiuXSBwNWdJN6znDx+tF3gzITAXSzGqs83cWaVwnB7v5Ps22YKyMPyhu6w7lZ4HnuS+oFhg+WPB0qoZ7hUQvhuK4q6bkvNvqzU+CfucCxJedrG9QyUY37hGerSf8NsE8Rf0VGVdVpzzEJDMiFbnJUSjyYOG4ixjUpY+gOALA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Gd01ltZQ; arc=none smtp.client-ip=74.125.82.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Gd01ltZQ" Received: by mail-dy1-f170.google.com with SMTP id 5a478bee46e88-306f36df4feso198497eec.0 for ; Tue, 16 Jun 2026 12:22:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781637738; x=1782242538; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=F9t9c6bYslGUW0YJ04TH35qJToA/FwEVp7/7In1g8XU=; b=Gd01ltZQDw2fa08Q1TvVEP5f0fxdrowwR4s/r5qxIbdH5xRBSf3xV3jF2TlOZ54+W3 3HA37DDoaZxhja9UNL/pDj4eej5Dnusrcif4BTmBjTJTt55AGJJspTlPdggAxgHHQiYM Vot6ofEM+kaQWLuXEhV1JSSBk2j0UgyFNEGxFxCvPcVnt5kVzc70+2imT+9pOvZHUnoy e4yaS2gxcpWqxCqkWt0aDJpOChWnfOLuc079xsaigEZ5XZI9NIXUmrFVi+06IHQYOMzI M6XY1/Y/jEnSdMzsJh80aEhhT0Hs5pDdNzIr6GS3MiZtzLqTihTHh/smA1Nvq7Jk8hGQ Nc3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781637738; x=1782242538; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F9t9c6bYslGUW0YJ04TH35qJToA/FwEVp7/7In1g8XU=; b=T09uJDePaigHPbty8UtCV2yRqLMbV3x5IMC0JYBOUnGlDtxRG7cNTYh1mIXvKZLZga IdFtxaw4rZEniYB58pSNCtBW2VTQWMcRaFgIMF+bFIFX507la4bPzI1u1a7Syen0Saw/ qmkirLQMymfqUCssv7nUO9dooki9JRmYUjE5A9YfPqUelyBV+QxcLzd8yJGOrYrTb7vt uqO7WjYJDFY6cR5m/7gqygEfnh/SNlbgg3AhJTd8QTwHFWZUhpOfHzFOmmfqkJ78r8XL TiHlxcX1W0igBGKEJ09KreNtwgSESpNlfQBYUamDExtj0alG5HAHMkS4y7ncgYOZtP+Z bOWg== X-Forwarded-Encrypted: i=1; AFNElJ/s2XRtzbouG/6UWll7aIVFt6Gsu3LP9eX6ufqkuOaSPesFYvjhyetZH1jQTRPu7K4K+ffG4L7SXuIIzuI=@vger.kernel.org X-Gm-Message-State: AOJu0Yzq0IlaXIy8B0fpx7mXyCsuaWD39SAEErNBu0E4SR58WjQ2Juri Wg9gkKvSJXykCkkbTWQpnyJ+xbI3LA0GVxbZ7MdNkgeeAi/6UzlmB8gW X-Gm-Gg: AfdE7cnXYLWWEwOWUuas8rY7ZR+YoZJoZaTKbQmTnRCIoWjFRNZKzTeoIf040AJxke1 A+jNrZub0soq5hsIpf1y0kfOYoM0rvfI8F0Y+825mV/zkMzT8ZdxUHtbF3eR8B1BA3xCHZnor3n e//UDXeH/ygMaVfy4N2ujJG4Onf97SaBFjZdwTv7FLcw7pB977KBBiPE98CInGqu5y3Mqn597Ej o6bBsfzeLSupSRDeRTqolkueglfNmjJKS0ZbY6orKphaUH50qtLQPJmNS4B3AXLpRH8at4/E3YB /KaYXgseY93jx+33U+/Xqa6hTjPbU5HwOhKllDgdAOUQREP3DaHPi5VLIeeVX7vyCcWIkojyrC/ +2AcBgtzn0sPwhmOl1DWizb2Ob2Inr+GyGodoAw3Js1c7ssHM3xIHSrV3digo/4W4u3vBIeehmV atGt8e0X6jU3V9ZuXR/wScKnIbwmavWe67GaKvQYkWdH5X30NhYzTToo2bOq14kYtgIB7YYNg69 g== X-Received: by 2002:a05:7300:6d2b:b0:30a:e52f:9b99 with SMTP id 5a478bee46e88-30bce88dc80mr66631eec.0.1781637738011; Tue, 16 Jun 2026 12:22:18 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:cbae:d24:189c:2cb9]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3081ea447b4sm18650560eec.23.2026.06.16.12.22.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 12:22:17 -0700 (PDT) Date: Tue, 16 Jun 2026 12:22:14 -0700 From: Dmitry Torokhov To: Konrad Dybcio Cc: Fenglin Wu , linux-arm-msm@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Stephen Boyd , Bjorn Andersson , Konrad Dybcio , David Collins , Subbaraman Narayanamurthy , Kamal Wadhwa , kernel@oss.qualcomm.com, linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] input: misc: Add Qualcomm SPMI PMIC haptics driver Message-ID: References: <20260616-qcom-spmi-haptics-v1-0-d24e422de6b4@oss.qualcomm.com> <20260616-qcom-spmi-haptics-v1-3-d24e422de6b4@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jun 16, 2026 at 12:25:55PM +0200, Konrad Dybcio wrote: > On 6/16/26 12:08 PM, Fenglin Wu wrote: > > Add an initial driver for the Qualcomm PMIH010x PMIC haptics module, > > named as HAP530_HV. This module supports several play modes, including > > DIRECT_PLAY, FIFO, PAT_MEM, and SWR, each with distinct data sourcing > > and hardware data handling logic. Currently, the driver provides support > > for two play modes using the input force-feedback framework: FF_CONSTANT > > effect for DIRECT_PLAY mode and FF_PERIODIC effect with FF_CUSTOM > > waveform for FIFO mode. > > > > Assisted-by: Claude:claude-4-6-sonnet > > Signed-off-by: Fenglin Wu > > --- > > [...] > > > +static int cfg_write(struct qcom_haptics *h, u32 off, u32 val) > > static inline No, let compiler do its job and decide whether it should be inlined or not. Thanks. -- Dmitry