From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 748423112B2 for ; Wed, 17 Jun 2026 10:59:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781693964; cv=none; b=NCJWkpSoqhhdYgq5Jji8VgZKYqOcv+6J/pPz8dy5u51DeAqH8l3A5WE+FiRzKvtRpbid2gvoPBd29XDzncdDL1iBUOWdfUzvbphOpFIJCApjUWroDRIR/sjb8M6jwrI1RAH3GzBPwa9Uhl5LNIi53pR/aiXcAtiBfFJ46pP8mQA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781693964; c=relaxed/simple; bh=BG8I6hWOhVmVwAETJ4Mpnqkk7ce1JkzQX78g+XE7054=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=E94MJZO+HKZBYpprCIvSgGduSgKZWe0gJXW4srN8IkLjHQrLJoFpoPvZEa/5YWkxFChGsgOdyajYFVYy9vHoV7C7IYGco03BQPPQw/sdjYI4/95WiLohK5nx0mE1H2l6FRBjlHI6Ahbq1Jecrqw9a6Xz9YEWciljeAza76lEFR4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=aW7d3/ct; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="aW7d3/ct" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2c6d3851e0aso5165ad.1 for ; Wed, 17 Jun 2026 03:59:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781693963; x=1782298763; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7/VrBPPU0BxnUkyl2VIWVxkiohO/pXSg9OgJaB65iUM=; b=aW7d3/ctNaNxCC2wphkYKVfAW6ipeqIcwJyTyny4aSwg7Be8SpDs57KWxWuOBkdI7H vsoRdZDihs4lxJKnJlhUbEcc4bDgsclN9OOZSNGDeAYorigtpwVRi8tJ7j/Pc3/BHX6s QK9z6nfmv8FtNdTX/TMgvmPWCPvxzwCTXnoeSr02rRDRhNqLS9iUJdZW503ggN3gyUHH 6zbVmGbEs2cyLYTj+F4OTn0/xoTdQq7+p7erXsFTcNwQSeBQJrfg3AMvtB06RiRX5P4/ 6+e3ti1kuyq3l6PQEaOqRePOdJvnONUT2lgmOWRcBI2PbyRrnxSOn0L/4ucYsI2rB24g mklw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781693963; x=1782298763; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7/VrBPPU0BxnUkyl2VIWVxkiohO/pXSg9OgJaB65iUM=; b=S/pOCnAFOICzJkOCKQSYugXe4RIOOonC1MnMh6Lo6KnxuwofP3/zxf/mmnoEcHj4OY HPg0oon8OCJk45Z3g59uxwnAltNBcn8ECA/OkhvOLdA5VVO9M/5gazYCLDefH8ffNvsw Ic5wG8yRR2V/pbZL0hmGGq9SZ1/LXcvt13SdgzrTBB+8yJb5e2K5pZwMZFpMaeJaPugr tdEUtaIBNppvi9zuInPNNpL1p1ukr2uyy40/4e7MwsbRwnPoWavwaE+N50c2ZZWtDpEp UL0psWS2hUtpv5OmAr3rjhkks0uc3DAFQqBti6fOd7T7qH6HJuCK1dLiGGuLpXA2I989 +p0Q== X-Forwarded-Encrypted: i=1; AFNElJ+3BUDoEVVqKEx2fFWRklFGE2/7fQsDG5ybbv6o8p7hOj/Ch92aYeOrBNPLCWH8Rs9V+fVokp90f1ZHBhk=@vger.kernel.org X-Gm-Message-State: AOJu0YwhDnyaqW6kgX0XbZLSUHArb8jUx1yPg77JpJxek5MAzpxmNKes iYsHHaKjfT4HQkMlEzUK6m1rS8U+3AAa75lR1N0Ce5+yxPhQd7e+yTJduRwFio48bA== X-Gm-Gg: AfdE7cm+f2e9JemYf2TyaH3NDXWuPEclM/hTXrri9TDmzkf/+U2s3eTmu/wmfDpRnQS f6pCNJLixugMx+Y55NbQZXziI9xkiK07xmHainQkt6YI9Luk5yU5Eh2CVZVlrl1uMOGpuM70Khs Tt51hvk19mRFTeWzZWo/yRyMxHglaN7Iycr80YcHHMQ4dR60XvZUVKB+9o8PFwNkWm6rD2OZ/31 U28bShMk2ov8zEpZONP6sECmoy3TYuSgGBA3+56zQB3RimLXb3BAOAM8b4fI02Ay8XLs0uI06pe oE0PnnaMRYcb6vS3zj/pSDxyUAQqJ3EDd1FwLFPTJvzJyf9HBldDYTznX5+dkUeBiZwfbxGlosc OKanFM/1VyM2ol+6pYblziu0D3ZQQm6YDts597HpkBxTiqRSG1b2N/gk/dfv9MfdpU3C26g45lQ +YNxWK9S75Pd1Bq33dG3S0I9F7dur/ZdFS2VRP0hm/mzfRYjYvTA== X-Received: by 2002:a17:903:1a8f:b0:2c1:4228:3321 with SMTP id d9443c01a7336-2c6bb8b16ddmr1874595ad.12.1781693962331; Wed, 17 Jun 2026 03:59:22 -0700 (PDT) Received: from google.com (199.255.142.34.bc.googleusercontent.com. [34.142.255.199]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37c521cac5bsm5696164a91.5.2026.06.17.03.59.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 03:59:21 -0700 (PDT) Date: Wed, 17 Jun 2026 10:59:14 +0000 From: Pranjal Shrivastava To: Jason Gunthorpe Cc: Jacob Pan , linux-kernel@vger.kernel.org, "iommu@lists.linux.dev" , Alex Williamson , Joerg Roedel , Mostafa Saleh , David Matlack , Robin Murphy , Nicolin Chen , "Tian, Kevin" , Yi Liu , Baolu Lu , Saurabh Sengar , skhawaja@google.com, pasha.tatashin@soleen.com, Will Deacon Subject: Re: [PATCH v9 1/6] iommufd: Support a HWPT without an iommu driver for noiommu Message-ID: References: <20260611172658.3421138-1-jacob.pan@linux.microsoft.com> <20260611172658.3421138-2-jacob.pan@linux.microsoft.com> <20260617000948.GA3577711@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260617000948.GA3577711@nvidia.com> On Tue, Jun 16, 2026 at 09:09:48PM -0300, Jason Gunthorpe wrote: > On Tue, Jun 16, 2026 at 08:18:06PM +0000, Pranjal Shrivastava wrote: > > > diff --git a/drivers/iommu/iommufd/Kconfig b/drivers/iommu/iommufd/Kconfig > > > index 455bac0351f2..6c3bea83631b 100644 > > > --- a/drivers/iommu/iommufd/Kconfig > > > +++ b/drivers/iommu/iommufd/Kconfig > > > @@ -16,6 +16,18 @@ config IOMMUFD > > > If you don't know what to do here, say N. > > > > > > if IOMMUFD > > > +config IOMMUFD_NOIOMMU > > > + bool > > > + depends on !GENERIC_ATOMIC64 # IOMMU_PT_AMDV1 requires cmpxchg64 > > > > Nit: Should we explicitly depend on 64BIT here? > > I see further in the patch we assume 64-bit addresses: > > > > + cfg.common.hw_max_vasz_lg2 = 64; > > + cfg.common.hw_max_oasz_lg2 = 52; > > That will work fine on 32 bit, it is how all the drivers are being setup. Ah my bad, I misundersood the GENERIC_ATOMIC64 config. I agree. Thanks, Praan