From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b2-smtp.messagingengine.com (fout-b2-smtp.messagingengine.com [202.12.124.145]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C8B739F162; Wed, 17 Jun 2026 10:00:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.145 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781690439; cv=none; b=l+nSJ926lCIoQX3bE4qxIGGhFA7AbNEEuHuB3pXxLQc/hi7hzHTt64TWcYOHgY758UgBiy+KG/mSwBibcPYWg0h/XryvZb2EgtDw/OtzHbOkJ+MCyuGNpcgWw6Jx/6Jl0L/2DUkU4FcZcgMpr6+5OoMslnUEVFd9IhVshK8jPAo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781690439; c=relaxed/simple; bh=vFePy412tZrj1pquGV7Iqax3UX1paocgmjl5R+aD3ho=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uQ6p98KMG/Li5AwFGad+mn45k9OwgvWzZYjwiOw2WfmEnQAtFI4BYYgd3fwdxpBhs9FjOnCbtCE103cQ+JfEkA1qIlGEKF/STwrSlkJeOpdbQtBftlsg6a2AUNV7BLdCsrKEfvLxzlooSI9YEXFCeyPBzgJxqa0qH8qjRpu3V/c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net; spf=pass smtp.mailfrom=queasysnail.net; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b=QQWRis/R; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=O3iwMR7g; arc=none smtp.client-ip=202.12.124.145 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b="QQWRis/R"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="O3iwMR7g" Received: from phl-compute-11.internal (phl-compute-11.internal [10.202.2.51]) by mailfout.stl.internal (Postfix) with ESMTP id 031091D000B5; Wed, 17 Jun 2026 06:00:34 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-11.internal (MEProxy); Wed, 17 Jun 2026 06:00:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=queasysnail.net; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1781690434; x= 1781776834; bh=Iitia+nm4SEU8NOqdpm1cv3/pVeEmHmNmKX2zgwhAks=; b=Q QWRis/ROh1JFz9l2Q79JCsnOXJz+NO+iOAUs361Ttmzf3Ag6ealOuA9k8dulvlaM JNK6Npbgp9quyvpdYcC0ZJzJrpvcLRu+aANa/iplPofx3ooo9Kl3I9IESpJojNUp bogiM6+E7aAK5X1DGeeMsqQCvqRGCQZoTiroFyoMzH4kmFlNs1iSYziR9sCqaFVU mieHW28W1cNmgwNLKo9c5r0vZ5t4m1BoL4qrg7B8QVA/nYYfxDdAHtDMsO9MuJyo VZGrkEu4hnp+ziIECBapv41lOQDiiZWG0N9I+EceGFSbNTrUC/DEnQX5VdzylhuZ nG6ANeShj62Z56HHcG3vg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1781690434; x=1781776834; bh=Iitia+nm4SEU8NOqdpm1cv3/pVeEmHmNmKX 2zgwhAks=; b=O3iwMR7gBaXTkFNLR6nkMcGdoJstDx9gjykgpJJOxI7LJTLbAbi jWVx7mtYlFFYuFdTbpGyIrrHEoGBSbVVqkSDUOd1pHVdhXUbr4elu7UfivLUQeNz uASLFw1jQtb5ikN0zw/uGLr226NCs0+VKnjDtgoPN3fa26EG9Fx8LrDumiGEeRNQ lq/bjvHzivuDgt544AOF0t+yxDdKE2ZAnVuQQx53gD8dsRQ8zxQZXBtioKxgLGPy DaGdSrS9qxdXKaSwVUjAxO86LPXcGHCRk9KfAmivI6Evv9sODjyMPwWTGAxf2e4T r0z5he/SR1T5gATIllVxxJFIx1R6ZeTunHA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFzZPdHrXtsdAZHUBxb7Zy6lBmBdO6Jhk0EUHgTJOXZ4Kin/PP7fYFwr90S70K0ew kjp29eJi1sVn/IajN8AAo2Bu/g7mF890tQwE6w7rEYV4XpVv2WSyywdsAfDbfYkyGj2HPL M2CPpT8W0KTyjvsB2iUTFB5Yk3o0uyGFHbfnTmzOs5OU5PRqbg4cVheu8oGXPowgJ3ZJwP ZMC4/sMtF+B7xPUSxmRl/Qz+lQM6aWzRufFwFutfM+lLgZI0BnC5EjFOBTyUZNyP+pzRy1 yOB4Nwd1OpLJMr5crXw8D3pWHnrUBi2Mkeg0rSlGOaCBdEHj0hVmZaw4pQfnxiTsHKllom WGiQC3estGvBo3rmNHIkAF8OokHeyvHsyG910BFdQFw2cANXOAPiSLRyXDzV057rCAdTsR jlj/5pHAJE3YuwH154zbfEQ0IhBeM+iZNzQwGnqXD4vjl0oF6TAKkwq0cQv1PQLZW6Nco3 eyfJJi8iNpv6wtc7cTCqfnmKtocSWtXpPVdNuZ8aY7FAUNnoDcrjuf/bRBi9a3FzSpsSJg FIlK+6yYpIfG9WsQ9F6s1fikHWVjfLnPcT5UyJHPx8hEvuiMUlbQIEFNHazNIgXVcFc+L4 vjjRzhFO8D9cDbRKcAvjYdy9taQKkNymjewRLVUWt16lgx2iUXH9gXjIJGRA X-ME-Proxy: Feedback-ID: i934648bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 17 Jun 2026 06:00:33 -0400 (EDT) Date: Wed, 17 Jun 2026 12:00:31 +0200 From: Sabrina Dubroca To: Jakub Kicinski Cc: syzbot , davem@davemloft.net, edumazet@google.com, horms@kernel.org, john.fastabend@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [net?] WARNING in tls_err_abort Message-ID: References: <6a315d48.b0403584.28d0ff.0002.GAE@google.com> <20260616082816.4dd0f035@kernel.org> <20260616142359.43300727@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: 2026-06-16, 23:46:28 +0200, Sabrina Dubroca wrote: > 2026-06-16, 14:23:59 -0700, Jakub Kicinski wrote: > > On Tue, 16 Jun 2026 23:00:54 +0200 Sabrina Dubroca wrote: > > > 2026-06-16, 08:28:16 -0700, Jakub Kicinski wrote: > > > > On Tue, 16 Jun 2026 17:19:22 +0200 Sabrina Dubroca wrote: > > > > Don't we depend on it being set > > > > to avoid further state transitions once we hit a crypto error? > > > > > > I kind of thought so too. > > > > In which case the question is whether we should try to remove > > the sock_error() instead? (stating the obvious I guess) > > That would make sense, but we can't prevent sock_error() being called > from some helper. Actually, getsockopt(SO_ERROR) will also clear sk_err. If we want to prevent further state transitions, we'll have to use something else (probably a flag in tls_context set by tls_err_abort()). So I'd go with 2 separate patches. The 2nd one will be a change in userspace-visible behavior, but hopefully not one they'd be upset about. -- Sabrina