From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2489400E13 for ; Wed, 17 Jun 2026 12:26:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781699177; cv=none; b=E7D1x5C/c8yrC3AbOKmdi/0WtoZLP5VghXYWalkNncp+MyMR54XTv6C4j1zwVpuiOckdxGmO6OQSklZ1Brh+K1LZxv2vIW5cCV1K0zuZADBXqSEqDglcLT0cC+CQaQSaNfzv5V7HKwZCAUd8IOPDTBGVadbZ5RymBrVSbX4RtXs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781699177; c=relaxed/simple; bh=oaz3MeK8t59MilWFzgrN7JxYEFiRZHAVlA6cq0zb+U4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CT8HmA0QoUOjnFkz+X1BSR3d2H5toXV5iBPNaPwf9N2uUi2zHV/cK+CGCG8DvXvjibGif90xHTwnJ/yvbuAB8oznO+N/1RlJVbkAxjz45nnBZfKa1RyrmLUkmZcDPTmErnSdkNs2CPEYyAFItbQgzUpwNTcwBzrdawuN+l0f0oU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=I8wEw6y8; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="I8wEw6y8" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-490b4a8e28bso42912005e9.1 for ; Wed, 17 Jun 2026 05:26:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1781699172; x=1782303972; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3YBXCuE6tuFht3k3o9SLsq14tW7sWyyo0dU5FVc07Z8=; b=I8wEw6y8OeWlwrWo1LOrG8Lu+9huJ7uAuTaoWo7hud2L6bLkCs588HSUzd0ZtyCN1z ElsWQCo45qq1TMavK9xfSIUWzNWTeTepZ4jh/iZtiM4SOe64OggaKSdouw9loielihMQ IfmLbo0L2QDjXJ54F022cbEr5fNCeisqh5w/DF6bqZga7Dq9+nvnvDcqse48jRfKKusR RcKP4pMUF0M6lqb46lXrvsjMgPNlz2WXQThB7rvLzxUVWYYU++fMMibjznCV6nE2sf8q RLKm858BA3hUqRHh5qHqMG6uxR9UopErmW/xGEAR55cxdgm1FwdnYWYhT3byxae566KS hunw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781699172; x=1782303972; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3YBXCuE6tuFht3k3o9SLsq14tW7sWyyo0dU5FVc07Z8=; b=qz6GBjrAQB4G8ttMi9KfRgBqqIvqZ8KWqMFLAROdlM3f1SjnGOj0vZzCzpsi5Dhg/2 Ia0/WiIDUGfGcXfqCuojvqSTtZ6YswpHmOml7vBSPpNjTcUb+X76XWGXb5HC0DUM3Mim qeW+qgQz+QZiVgJR89X+KEp2zt+17uH1+sGFXtjwd4Y89HPzmdQyaRM5BfZLd7N3l9M/ Pi385rLoc4mMK0K8ni5tmPlYi5IbNSyrIpbDoerBM99ufyCNBk1F9x2CJmVIqriyfV2C nYT//pDJSVnrdXMRC2xkz/l7UpD6T31zZCiEvCXVeiPkMCXUdURXSy5xB6DCrosaV6mU fqNg== X-Forwarded-Encrypted: i=1; AFNElJ+T4sYrshiBXp24Dr0EoqW31oZmLDV7NnL3IEJr7HmCX93lbL74vQjkbPrd7IhsxP0ygMbfDCC4OAh8jB0=@vger.kernel.org X-Gm-Message-State: AOJu0YweL1zPqCmVFbSXR7bB9jlwyZUAZUW8bf0f89vwEsknv+uF0nak hKJtmgOcsxMXw61juDH9CilHKRouFq4CBczCARtonn2jMK9RMeKI+LdBkA36D5LzJyI= X-Gm-Gg: Acq92OGCnFzdEs8iUoCYPTe4QGOM/yUaxJy0PC22y3Mn9r6oTRf76gNCbUuEh2/73um /g8t09eWjl7KnzhVqx301afevmbhrKeYoHhcGXYCh1Cu+KyC7wpgb1SI2Hmm/y4V6YQJ4qEOCtL UYiD/ITZ5/hVVikf7BQIYDlF8EClsIq/OpJYLFx0MW84Jz828rFeDgqHMXLynWyc3xwaR7u7OR5 TsMN6VGyg7JKixwNDP51abvbMqRk4zkg21LNinzEQazIavoUfmWYfJhKOe3qCR2Gx6jRaA2mZVi zgL4yI2sZ0FAEMgaMsIwZ/RRw8Bi23y6nk6DCcOaSusdBrdXVQBJu0H3pTGFA4XT8kv7VegGI+L M7DCJfYM9VFbVxwec6vPv3LeLBZG/eMSxmmE85l8ICmLPpMYsJ1a7ZIG2cU8pau1C3t2+0OokdN 7rxpGzb0TTT6T9f+ddDQ== X-Received: by 2002:a05:600c:8b43:b0:490:bbc4:76a6 with SMTP id 5b1f17b1804b1-4923341fdb8mr74870325e9.21.1781699171664; Wed, 17 Jun 2026 05:26:11 -0700 (PDT) Received: from localhost.localdomain ([62.77.90.70]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4922fa3abd0sm179575345e9.1.2026.06.17.05.26.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 05:26:11 -0700 (PDT) Date: Wed, 17 Jun 2026 14:26:09 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Li Wang Cc: akpm@linux-foundation.org, tj@kernel.org, longman@redhat.com, roman.gushchin@linux.dev, hannes@cmpxchg.org, yosry@kernel.org, jiayuan.chen@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, shuah@kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Hocko , Muchun Song , Shakeel Butt , Yosry Ahmed Subject: Re: [PATCH v7 8/8] selftests/cgroup: test_zswap: wait for asynchronous writeback Message-ID: References: <20260424040059.12940-1-li.wang@linux.dev> <20260424040059.12940-9-li.wang@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rhxkikwyiqml4ro5" Content-Disposition: inline In-Reply-To: <20260424040059.12940-9-li.wang@linux.dev> --rhxkikwyiqml4ro5 Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v7 8/8] selftests/cgroup: test_zswap: wait for asynchronous writeback MIME-Version: 1.0 On Fri, Apr 24, 2026 at 12:00:59PM +0800, Li Wang wrote: > @@ -345,7 +366,10 @@ static int test_zswap_writeback_one(const char *cgro= up, bool wb) > return -1; > =20 > /* Verify that zswap writeback occurred only if writeback was enabled */ > - zswpwb_after =3D get_cg_wb_count(cgroup); > + if (wb) > + zswpwb_after =3D wait_for_writeback(cgroup, 5000); We should have something like cg_read_key_long_poll(cgroup, "memory.stat", "zswpwb", 0, 500, DEFAULT_WAIT_INTERVAL_US); for this. Although this also needs further change like (and respective adjustment): diff --git a/tools/testing/selftests/cgroup/lib/cgroup_util.c b/tools/testi= ng/selftests/cgroup/lib/cgroup_util.c index a7b3380d88d77..c0511853db9c6 100644 --- a/tools/testing/selftests/cgroup/lib/cgroup_util.c +++ b/tools/testing/selftests/cgroup/lib/cgroup_util.c @@ -188,8 +188,8 @@ long cg_read_key_long(const char *cgroup, const char *c= ontrol, const char *key) } long cg_read_key_long_poll(const char *cgroup, const char *control, - const char *key, long expected, int retries, - useconds_t wait_interval_us) + const char *key, enum exp_op expected_op, long e= xpected, + int retries, useconds_t wait_interval_us) { long val =3D -1; int i; @@ -199,7 +199,9 @@ long cg_read_key_long_poll(const char *cgroup, const ch= ar *control, if (val < 0) return val; - if (val =3D=3D expected) + if (expected_op =3D=3D EXP_EQUAL && val =3D=3D expected) + break; + if (expected_op =3D=3D EXP_GT && val > expected) break; usleep(wait_interval_us); diff --git a/tools/testing/selftests/cgroup/lib/include/cgroup_util.h b/too= ls/testing/selftests/cgroup/lib/include/cgroup_util.h index 567b1082974c5..3e9bfb66cf5a9 100644 --- a/tools/testing/selftests/cgroup/lib/include/cgroup_util.h +++ b/tools/testing/selftests/cgroup/lib/include/cgroup_util.h @@ -19,6 +19,11 @@ #define DEFAULT_WAIT_INTERVAL_US (100 * 1000) /* 100 ms */ +enum exp_op { + EXP_EQUAL, + EXP_GT, +}; + /* * Checks if two given values differ by less than err% of their sum. */ @@ -69,8 +74,8 @@ extern long cg_read_long(const char *cgroup, const char *= control); extern long cg_read_long_fd(int fd); long cg_read_key_long(const char *cgroup, const char *control, const char = *key); long cg_read_key_long_poll(const char *cgroup, const char *control, - const char *key, long expected, int retries, - useconds_t wait_interval_us); + const char *key, enum exp_op expected_op, long e= xpected, + int retries, useconds_t wait_interval_us); extern long cg_read_lc(const char *cgroup, const char *control); extern int cg_write(const char *cgroup, const char *control, char *buf); extern int cg_open(const char *cgroup, const char *control, int flags); --rhxkikwyiqml4ro5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJEEABYKADkWIQRCE24Fn/AcRjnLivR+PQLnlNv4CAUCajKSXRsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMiwyLDIACgkQfj0C55Tb+Ahk/gEA8MFcY73q1d/mRp6IVc/w CQOVsXy+oQ7vXkS8eyOailYBAKUGPqDDIcVYrCtsuMyhJ+LOoh7WKCiXRcrKQPNr iBMI =ROyv -----END PGP SIGNATURE----- --rhxkikwyiqml4ro5--