From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B90820D4E9 for ; Thu, 18 Jun 2026 00:23:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781742188; cv=none; b=CbBvXoTKwJExFDieJMgGyyix5Os3OrLWmjYLgWhhQ6dr0DK32Al9MRSCYvQUIRPdY12mz2g232x5R9s54prb9EK8/Tb4aF2c8Vcep8I/zOroaO0lAm3cIYpq9Owudnlb6S0Bx+SVF9iPn6/JmaX9Y1zjU0qMogQfnD671K8N7QQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781742188; c=relaxed/simple; bh=BbRozTqu26VO2dhTueZIIbzTNtNq1g2dj3vfv28wZzI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CmDqMopifCT3uVLK+P+bKmLvJ2UQ4cmQbRwI1qWywrV8DNy4z2YDZJcM3Aqz0P5tfHSf9QxGuOcovRQ8GurjX6JFG+bjyjDKxmu6X8KXcGH74FPWo9vpq8ZWVJCiec/aXcaA5whl1o5/S78QJiWpVqU0AVM5Bn6Wjt1yrnrENU8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=m0byTSiY; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="m0byTSiY" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2c6b67d5fa1so3114475ad.2 for ; Wed, 17 Jun 2026 17:23:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781742186; x=1782346986; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MnSWdPmYlLvglnlJ8/YPpZimMTUfQVBUOmpHrGeFGz4=; b=m0byTSiY0GqEMkBnqnGgvwm3ELXnqefdXOLN+zZSFZDROdil9HFTbRkDHmCPSsmqF8 rt92p9X7ax8XZzgSrZhKlvaTNnfUFm8R8sY28n9vRyP4+EmUV2wSYOXReo+NRdhIbyTg W2ZjdCBiRoNRyaa311v9GR6/nY+G9HdzHhTzV21wRw9H9fLmTJJxKJBWJzo6jfW/4yyz e8FeylfzjwL2MMw6k87h3XIpCpcV+0qErGlMVDhMEQw8mVIoKrLm3u+Xf1sYsUDQcIBd 7gLg3lYM2IaBseSptM8UJ6tcWWvwNGAztmYcKiWSiraIdYTDBK1oNz0Kl+Ny6J4ccG+I ednQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781742186; x=1782346986; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MnSWdPmYlLvglnlJ8/YPpZimMTUfQVBUOmpHrGeFGz4=; b=ZXIZolIarVIUKcdIod0t1Zkkl4bY9aZ9vGTlnSm1uS9HyqQvL1YSHGbDPzpRWsq4ta kCecv/GIk8RaF1JqF04Yjhvg+dWVjJhaQrKNVbgiQ9r8oatWMbO8IT/5RXDjm68viUqs g8P0xlMt/foIgD2pra8RvyGANzPPBid063/RuaVjSTdAySzvDItIuMebeJo9Br3Ux6DA Ekp0x0XyqvFEq5Jmr8Hb4ZCZFjHUFA05B79eZZXKvVh0Nh+iZMtdTNUNpOl35CDAXekG gW7JKz2BcM6BVgVMk0ZkIWvk+HUFJU9zgxNxH85K6Oj2Ptpl0RipfF3T9yahp394ix2T FRTw== X-Forwarded-Encrypted: i=1; AFNElJ9tzqjEDt5h3UeRoEJ7l/I0oRMOUNqQiYqomNgwWhRhEUn1OsBeWyYKxPSLVU4k2My0tKDmsuxWaqdeyzE=@vger.kernel.org X-Gm-Message-State: AOJu0YzJNjX8ekE81uIcx4fvk+qFzSwBAErxx1ryHGf0RkbJbhhJFwOA 9upQ8f25GSqY3xPqYfosvN4gdAZTRN4RAVXGzSeMPKH28IbidZ1zzrfQQUhfV7UwwfnTL0Q/5+m sPs8hLg== X-Gm-Gg: AfdE7cnULOho3ZaiN48uzYYM8TiaVuhOJJ9vwsyZ9IiD8ec+V2FWwK3GF8zhAhHnp0F eM+c/8fnwGWmyVePXgb7VEFnXLL4AWaIB+6HxIHBxIh6+VjimuiL6xqeo5s9Z6R4OkGMHjW+LbE TXEDuPT0zTSVwGjPThPIvuhc215LSE3ESy9UocGylO27TGLRZ7RCrFthaYcmpzFO3cDlxsS9cMt s9QqBzVoYtP/eCK5CxLlyiYrATu/mGyokgJ3qu4DMREPvrgboePmn+kqg5VJzyAAvx98fna9+pZ /L/I9uQFEXd1oiRYVJf1owQMlFm9hWCAvBvuOfOO1leN1dXwy1PEBu8NXGfYp6bcdQEv3bVHdLg /rUyqNMM+6lPv57LbouaF/QysyqhZVMh+IH/wsODTg8wS3C2mgkqPjWazkJL8Pj4/0FNeHFB5FI GwXlLwnQK7r45k1Nm79TlQqh28ybfiO8Y/hYwPxj946innCPUJwMtMQnfopXE= X-Received: by 2002:a17:902:e945:b0:2c2:245a:3366 with SMTP id d9443c01a7336-2c6bc24a8a6mr58474885ad.27.1781742185890; Wed, 17 Jun 2026 17:23:05 -0700 (PDT) Received: from google.com (211.37.230.35.bc.googleusercontent.com. [35.230.37.211]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c42f2e52c0sm181730345ad.13.2026.06.17.17.23.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 17:23:04 -0700 (PDT) Date: Thu, 18 Jun 2026 00:23:01 +0000 From: Benson Leung To: Andrei Kuchynski Cc: Heikki Krogerus , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/3] usb: typec: thunderbolt: Check cable altmode support Message-ID: References: <20260611122146.262184-1-akuchynski@chromium.org> <20260611122146.262184-3-akuchynski@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9eYec23LMP4Rc8Ax" Content-Disposition: inline In-Reply-To: <20260611122146.262184-3-akuchynski@chromium.org> --9eYec23LMP4Rc8Ax Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 11, 2026 at 12:21:45PM +0000, Andrei Kuchynski wrote: > Update the probe function to utilize the new > typec_cable_altmode_unsupported() helper. If the cable doesn't support > Thunderbolt altmode, don't initialize altmode_ops and prevent altmode > from being activated. >=20 > Signed-off-by: Andrei Kuchynski Reviewed-by: Benson Leung > --- > drivers/usb/typec/altmodes/thunderbolt.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/drivers/usb/typec/altmodes/thunderbolt.c b/drivers/usb/typec= /altmodes/thunderbolt.c > index 32250b94262a9..2eccdddf1b1f4 100644 > --- a/drivers/usb/typec/altmodes/thunderbolt.c > +++ b/drivers/usb/typec/altmodes/thunderbolt.c > @@ -284,6 +284,10 @@ static int tbt_altmode_probe(struct typec_altmode *a= lt) > =20 > alt->desc =3D "Thunderbolt3"; > typec_altmode_set_drvdata(alt, tbt); > + > + if (typec_cable_altmode_unsupported(alt)) > + return 0; > + > typec_altmode_set_ops(alt, &tbt_altmode_ops); > =20 > if (!alt->mode_selection && tbt_ready(alt)) { > --=20 > 2.54.0.1099.g489fc7bff1-goog >=20 >=20 --9eYec23LMP4Rc8Ax Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQQCtZK6p/AktxXfkOlzbaomhzOwwgUCajM6ZQAKCRBzbaomhzOw wrrPAQDwXfkD6ebsQzaDRoh+SN/N7LDBJvwt73nLBysg4zAJGAD/TIJlzlwz51fg QNboeVUJL9Q8mGvwbTVVL1BGJs8dSw8= =G0yR -----END PGP SIGNATURE----- --9eYec23LMP4Rc8Ax--