From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15D6A37C11C for ; Wed, 17 Jun 2026 22:55:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781736908; cv=none; b=dOqs1D12xNZHrT7egU+FMfgafCW/JSeYhdtJFkvN0Zb/61XMT4ovaFKOVN9fcvFEFdc6ZzOfBMPnQ57HDgjXzdVNIm+tZRPbgRzFlLuxcM7a4f7WZusLPfBnV0tt6/BE932eTJUlZtWkQR+P+TCGRs8n+prNsiSne+dHX62NL8M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781736908; c=relaxed/simple; bh=XZNQCD0Wlzebe8+k82p0GQLAE+XVfMCy17xY+qRHYtY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QHTW2BiDuL5fY4b7fgMsXLiTF03I0H84E6Cblln5CHxBt1gIEKvzw9rcIpmT1jpdF57xmU/5eNss7uOxNp+RjkJll+vtZj6VxkcyD3A4sWY/3sE+tNrw9TtoURRf9CWpWpgPuIOERvujfn+2ldPmdcvSEht2I+c/qXd2HpL2Ogg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=bOjR2tpW; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="bOjR2tpW" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2bf2247e38eso3594425ad.3 for ; Wed, 17 Jun 2026 15:55:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781736906; x=1782341706; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=31pm6bOQX9ZGFrg4v1e61iShzXMdpZDAT+S55BgXi9I=; b=bOjR2tpWG0AYQDC8avd4GdHSX7j782z8Cgjq/6OJUzIYiYoazTRpi/Wzj+0f5Wy8UR l0Mcc4gbrrYC3xdOTJD69DbsUZgHO0w8ztyx0258WwnlvT+N1hDQfhAyPH6RvmIivB85 y4Qefx5vxOm8M/ELtpfNye2NwSgnNdlX19bgoD6XLHDU2pgDAIyxU1IvwaRQPytgpHaj tZxxO85cOCTy8ULqq8kY6wV+R+IYNn3dJB+dukJ7ftA9eryOMzmAoIMotkgoUklOYQJO Y2BxsONgtQqYO/CFF6QERttj+j7vVyBUHhW9hv2F2IZHuircQVYqM+9z95fC9FEc6T38 UIqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781736906; x=1782341706; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=31pm6bOQX9ZGFrg4v1e61iShzXMdpZDAT+S55BgXi9I=; b=ERYUFI1G//lbsxtJPJLXSSPzkA4RGrgNGkE9jDknZ55Yx5SNfFVowJMjPTDE96YuIZ drEyR5+GAmZZHZie7HM8lWRU/54GEslaGx+ksHrlhRYVWTNQOD4BghTufqNmwRbX5QeB pCBXGT0N6udydm7Ky2u8mjO6BzVfNHx5Z8LnB/UPR3WqxUvqxGT06uRHHtxR0KaPL8yc 1d9n24L2KiKmSSxOOrbCJ4PkOBYofYR+LeSqaH2H3UFUJhiVJvd2TCC/i6lJotFgZyLa /7NCvp13kN2MX0Ig5/Rz+buzaw2zr8s/sXInoBfgNRyBYEF4rQaYEFM9xYBNh8fNYvCq 8DOg== X-Forwarded-Encrypted: i=1; AFNElJ9sl5Qf7qp5Id6l3pGzmRVVdwVcMWMdF6azngNYkwmQXD8dxVCZ6CEfvV9Yt1qU7Xe7MWbQTfkzGJNPWss=@vger.kernel.org X-Gm-Message-State: AOJu0YxtjAj89h15gtn7aKbNJRncI9sOHNqwih2KAx4hTblQlkpZbvj1 dtBWnEWwQrbMqdvPcJJSAuy312sw2K9Dx7MBu+CvXuye8LU7nn5WsFQKV9JKahjmaA== X-Gm-Gg: AfdE7cnS77Q/rQib0n7qfmhUNZaJgz3XPc4acVJ+tgyo4rs/hMW8jwydTi4l1PEatFk k2l56vyYJAX2PZzHTXShMIdQqtSLxoz5Ic2490I3wXY2NAKfAXeLe38WNtV5rkQRWxYWYG7aYS7 CQpm8NHmoFsuoP43+uLlw9JR62xWhDtVeNEmJw5QABD2Wma+3OQhQ+eBWCvGs4T2xFIFCQ6pRau tV0kTC0WYxdsT73xBS+vvh3Vud6EiovJSwMkC+1iHUSoaaJN04+KL1OIJ/NVDOcF7gmNhNQW3Ah VWWNHd/MmE5n181RbQh7U8ZUQcRnEaQumX7Efrvinc1eYlpk2NiAmVGinQ/QhiR5qzxZHouDE/o 5SahqjdQQ+lWKUFzOsJNPJyLwy7HpdPvKXbVkm1TkPujVhAsgaAyEh4mHoTZEvpe1/fHqWHnYbz TU4w1As65KryGaTSiXJ7AeOKQuA2hWj5p2yCDNiejDQS/V8kbFog0= X-Received: by 2002:a17:903:196b:b0:2c6:cbcd:a0d7 with SMTP id d9443c01a7336-2c6cbcda883mr35120735ad.25.1781736906001; Wed, 17 Jun 2026 15:55:06 -0700 (PDT) Received: from google.com (56.149.168.34.bc.googleusercontent.com. [34.168.149.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c42fbb5411sm172146015ad.32.2026.06.17.15.55.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 15:55:05 -0700 (PDT) Date: Wed, 17 Jun 2026 22:55:02 +0000 From: David Matlack To: Alex Mastro Cc: Alex Williamson , Shuah Khan , Raghavendra Rao Ananta , Vipin Sharma , kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan Subject: Re: [PATCH v4 0/2] vfio: selftests: Add allocation assert helpers and avoid VLAs Message-ID: References: <20260617-scratch-amastro-vfio-selftests-avoid-vlas-v4-0-b9f52f1e2c5a@fb.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260617-scratch-amastro-vfio-selftests-avoid-vlas-v4-0-b9f52f1e2c5a@fb.com> On 2026-06-17 11:57 AM, Alex Mastro wrote: > Add VFIO selftest {malloc,calloc}_assert() helpers, then use > them in places that open-code malloc() or calloc() followed by > VFIO_ASSERT_NOT_NULL(). Thanks! > Use the helpers to replace VLAs with heap allocations. This avoids GCC > rejecting initialized VLAs and avoids treating a u8 buffer as a possibly > under-aligned VFIO request struct. > > Changes in v4: > - Add malloc_assert(). > - Link to v3: https://patch.msgid.link/20260615-scratch-amastro-vfio-selftests-avoid-vlas-v3-0-b3798415c72a@fb.com > > Changes in v3: > - Add the calloc_assert() helper as a precursor patch. > - Convert existing VFIO selftest calloc() assertion sites. > - Update the VLA fix to use calloc_assert(). > - Link to v2: https://patch.msgid.link/20260615-scratch-amastro-vfio-selftests-avoid-vlas-v2-1-4e4df462908a@fb.com > > Changes in v2: > - Reverse xmas tree variable ordering > - Link to v1: https://patch.msgid.link/20260612-scratch-amastro-vfio-selftests-avoid-vlas-v1-1-ba3acb635f0a@fb.com > > Signed-off-by: Alex Mastro > --- > Alex Mastro (2): > vfio: selftests: Add allocation assert helpers > vfio: selftests: Avoid VLAs Reviewed-by: David Matlack