The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Lee Jones <lee@kernel.org>
Cc: Matti Vaittinen <mazziesaccount@gmail.com>,
	 Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/2] rohm-bdi718x7/71828: Use software nodes for gpio-keys
Date: Thu, 18 Jun 2026 12:03:50 -0700	[thread overview]
Message-ID: <ajRAnY4ciK9NHc1E@google.com> (raw)
In-Reply-To: <20260618111844.GD1672911@google.com>

On Thu, Jun 18, 2026 at 12:18:44PM +0100, Lee Jones wrote:
> On Thu, 18 Jun 2026, Lee Jones wrote:
> 
> > On Thu, 11 Jun 2026 08:48:24 -0700, Dmitry Torokhov wrote:
> > > Now that gpio-keys can use platform resources to identify interrupts
> > > assigned to buttons we can convert ROHM power buttons to use software
> > > nodes and device properties for configuration, removing the need to use
> > > platform data.
> > 
> > Applied, thanks!
> > 
> > [1/2] mfd: rohm-bd71828: Use software nodes for gpio-keys
> >       commit: 320580a6d87705a705bb9802b13cd565880fe2ed
> > [2/2] mfd: rohm-bd718x7: Use software nodes for gpio-keys
> >       commit: 94e077e9e27b63e6c81a10e43362b683f1e82b8e
> 
> It's a shame to have so much duplicated code, but I think I've asked
> enough of you at this point.

Now that we have gnomes working for us it is pretty easy. Posted a
followup patch factoring this into a helper.

BTW, would it be possible to have these 2 in an immutable branch? That
would make it easier landing Arnd's changes disabling legacy gpio
support.

Thanks.

-- 
Dmitry

      reply	other threads:[~2026-06-18 19:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-11 15:48 [PATCH v5 0/2] rohm-bdi718x7/71828: Use software nodes for gpio-keys Dmitry Torokhov
2026-06-11 15:48 ` [PATCH v5 1/2] mfd: rohm-bd71828: " Dmitry Torokhov
2026-06-11 15:48 ` [PATCH v5 2/2] mfd: rohm-bd718x7: " Dmitry Torokhov
2026-06-12  4:38 ` [PATCH v5 0/2] rohm-bdi718x7/71828: " Matti Vaittinen
2026-06-12  4:40   ` Matti Vaittinen
2026-06-12  5:09     ` Dmitry Torokhov
2026-06-12  8:26       ` Matti Vaittinen
2026-06-18 11:17 ` Lee Jones
2026-06-18 11:18   ` Lee Jones
2026-06-18 19:03     ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ajRAnY4ciK9NHc1E@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=arnd@arndb.de \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mazziesaccount@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox