From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18B5A38A726 for ; Fri, 19 Jun 2026 13:00:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781874011; cv=none; b=GVxB+to7a5z6myWcEeZmNyE6rgjP63rU9cnU10U/KL6esNoBM8ik76vQF1e0tT7jKQByWYCrELRBMWqIimdVi7s10lhboIyg52o8nWhLne0clYrcR2GAt/AVdkWAIMZqpD4PdqfVqJLiCNLHKceUXg0bX1qeG8ScGSnE739nRhY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781874011; c=relaxed/simple; bh=VnzYMuGGOZOFQ0lkAErjhznaopoAsL3miQ4uX60fQMA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=T1wBV9GBj+kdpyYmQU70IFewQXwLaoVpmTvweSJWUOQpTqsJdBc6Lmklqkthonsbz9a4FloZA6rNJPjhWzP9qsLipVpBXNgfnx9ZhXVLlC2UkAr9bgZNzlGFWQGdG+89tIN+PbzpgNbVYYAF2jtEwqlRdCFDlG5zWTMUsAqyAAs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eJsy/YgJ; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eJsy/YgJ" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-4629051c946so1666561f8f.1 for ; Fri, 19 Jun 2026 06:00:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781874008; x=1782478808; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=qiZU2ur+yus0frcrsmwpHi+cHkIfW6hKIYxrtn8YRlk=; b=eJsy/YgJO8yOtf7gg8rfx16lJcDo/XV/V8kKM6w6CAptkr8JVCqnYtkp+wrocw5Tdh OiHZCocnHMGGP51+gSlK7UlvpjDfU4xFhYEFakcmZwHMchbak54dEkW+ItlME47WIc1F IFtBS/BDfh3jlVZ+n7xgF2gysunXXAyR4WiWNZz7yC5jzm0FROfZrp/tHZ4VuA3M5KuF y2RMp1joeArpSs3C1GZ29a/PLuDHlIO9nXazbvb8RjVH1Cbtw9RzcW3tZWaK6wZzS/UD wJbGjELKKpDCDeshL2QOnvLiLCRa9PEpr7yXpIP0sjfTGrIYwXlps/yVS+qpocihVkZq wX3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781874008; x=1782478808; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qiZU2ur+yus0frcrsmwpHi+cHkIfW6hKIYxrtn8YRlk=; b=LXnlDL1PQsind29g+JrKkVEkiuydsGbN1YPIFO9sxsY0faxeC0l/pz7c7S8LswpAZ/ JKKcAPQaqLdSgqmMHl8uV0yXZAMqpNpNEx3R5+aBNzieepPgYeepflFjh302DuWIHY4+ qm0hYuNe+cEQzQ38fCXBUckujc5o5cY1SAkCG1Za9dRgbqFWiQkCBWePFuZhGqYn1JOe RXAduox5Ogl7r6MCekTN37ZSBQumZo7b/iFOfXsuFrr9iFmtCiZJk20gnMlUjnAkRorJ 1JSMnUTFNE8ZqB4LCL5sI6PMTdQKngAPTGmywqwUAAVfC1clA+eeZRwHo/QeQ6O9cuSB lUew== X-Forwarded-Encrypted: i=1; AFNElJ9Ifigj+dNoW/gDnjjvM8xP96Qf2JhT2f3zOiQUbs0U7CqKXmnou5hLXpFL979ujFpPckDJVVgqDZnVb6E=@vger.kernel.org X-Gm-Message-State: AOJu0YzTeruUW81f9nqQ1rQqddnCZQXxKNPrUIngLN8vA01mBRMOV5bH pyB9a01/tdmkW46UJsgZAyhTHsg4Kr6L6NQfT/UeJ2HbvfTIjtUjhNUY X-Gm-Gg: AfdE7clJmdaXctVQFWUJtSUoCbt4IGjkH3aSlmjvbGNqaV1k1MV/shGtmLguyf8oGor mbt1ozIyz8ROGkEaVutfR6xSjgvWANgkeUbgLicDXIwsqB3BravOQD4DfjnWEPHNRyG2TbAo9yj sbHLMY50vJ+l930KUonA9v+HokjWkJ6YkBSLtO/Re5OIMqBwgGhuO5gemXg4qXUWPSZiMhU7JCI xXCf2pzdSlOU5Hxa7w2Cvyplgf9igPqXkjTYv4/yMM8w4X/CfbZZVTQuNrNHKF9Xqcg3GnZkX9d v+eJLVwKhHZ5la9OeE6+LrpboIb5fSBsY7Woul70tFQjVdgJ32u702w61UitTJCU6al26UvJzbo JxBqN9XNk2BdBfJXEdE/uOE6l6fXnnylwMQoiXWbju/5DcHLRmEv0QuPgHcWxBWLI4uawuwb607 FBDMc= X-Received: by 2002:a05:6000:611:b0:463:3184:6310 with SMTP id ffacd0b85a97d-4651e7b3b26mr5222838f8f.28.1781874007796; Fri, 19 Jun 2026 06:00:07 -0700 (PDT) Received: from nsa ([185.128.9.171]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4650b67a253sm8027816f8f.23.2026.06.19.06.00.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2026 06:00:07 -0700 (PDT) Date: Fri, 19 Jun 2026 14:01:08 +0100 From: Nuno =?utf-8?B?U8Oh?= To: Conor Dooley Cc: Janani Sunil , Jonathan Cameron , Rodrigo Alencar <455.rodrigo.alencar@gmail.com>, Janani Sunil , Lars-Peter Clausen , Michael Hennerich , David Lechner , Nuno =?utf-8?B?U8Oh?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Jonathan Corbet , Shuah Khan , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Mark Brown Subject: Re: [PATCH v3 1/2] dt-bindings: iio: dac: Add AD5529R Message-ID: References: <20260519-ad5529r-driver-v3-0-267c0731aa68@analog.com> <20260519-ad5529r-driver-v3-1-267c0731aa68@analog.com> <25mh6grzh7zh3b4uytcqnusyv5zjuf6ia4if3ce3oqzqz56ehi@le72iqv7ye3d> <603473ac-30e6-45e5-8a3b-c9902715cc9e@gmail.com> <20260614204455.408c4d40@jic23-huawei> <076d7d2d-81a0-49c2-af94-bd65ead66c09@gmail.com> <20260619-obstinate-polo-a230bef97fda@spud> <20260619-bunch-diocese-dd7805cc17ff@spud> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260619-bunch-diocese-dd7805cc17ff@spud> On Fri, Jun 19, 2026 at 12:40:54PM +0100, Conor Dooley wrote: > On Fri, Jun 19, 2026 at 12:36:55PM +0100, Conor Dooley wrote: > > On Fri, Jun 19, 2026 at 12:33:11PM +0200, Janani Sunil wrote: > > > > > > On 6/14/26 21:44, Jonathan Cameron wrote: > > > > On Tue, 9 Jun 2026 16:47:23 +0200 > > > > Janani Sunil wrote: > > > > > > > > > On 5/26/26 15:11, Rodrigo Alencar wrote: > > > > > > On 26/05/19 05:42PM, Janani Sunil wrote: > > > > > > > Devicetree bindings for AD5529R 16 channel 12/16 bit high voltage, > > > > > > > buffered voltage output digital-to-analog converter (DAC) with an > > > > > > > integrated precision reference. > > > > > > ... > > > > > > Probably others may comment on that, but... > > > > > > > > > > > > This parent node may support device addressing for multi-device support through > > > > > > those ID pins. I suppose that each device may have its own power supplies or > > > > > > other resources like the toggle pins or reset and enable. > > > > > > > > > > > > That way I suppose that an example would look like... > > > > > > > + > > > > > > > +patternProperties: > > > > > > > + "^channel@([0-9]|1[0-5])$": > > > > > > > + type: object > > > > > > > + description: Child nodes for individual channel configuration > > > > > > > + > > > > > > > + properties: > > > > > > > + reg: > > > > > > > + description: Channel number. > > > > > > > + minimum: 0 > > > > > > > + maximum: 15 > > > > > > > + > > > > > > > + adi,output-range-microvolt: > > > > > > > + description: | > > > > > > > + Output voltage range for this channel as [min, max] in microvolts. > > > > > > > + If not specified, defaults to 0V to 5V range. > > > > > > > + oneOf: > > > > > > > + - items: > > > > > > > + - const: 0 > > > > > > > + - enum: [5000000, 10000000, 20000000, 40000000] > > > > > > > + - items: > > > > > > > + - const: -5000000 > > > > > > > + - const: 5000000 > > > > > > > + - items: > > > > > > > + - const: -10000000 > > > > > > > + - const: 10000000 > > > > > > > + - items: > > > > > > > + - const: -15000000 > > > > > > > + - const: 15000000 > > > > > > > + - items: > > > > > > > + - const: -20000000 > > > > > > > + - const: 20000000 > > > > > > > + > > > > > > > + required: > > > > > > > + - reg > > > > > > > + > > > > > > > + additionalProperties: false > > > > > > > + > > > > > > > +required: > > > > > > > + - compatible > > > > > > > + - reg > > > > > > > + - vdd-supply > > > > > > > + - avdd-supply > > > > > > > + - hvdd-supply > > > > > > > + > > > > > > > +dependencies: > > > > > > > + spi-cpha: [ spi-cpol ] > > > > > > > + spi-cpol: [ spi-cpha ] > > > > > > > + > > > > > > > +allOf: > > > > > > > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > > > > > > > + > > > > > > > +unevaluatedProperties: false > > > > > > > + > > > > > > > +examples: > > > > > > > + - | > > > > > > > + #include > > > > > > > + > > > > > > > + spi { > > > > > > > + #address-cells = <1>; > > > > > > > + #size-cells = <0>; > > > > > > > + > > > > > > > + dac@0 { > > > > > > > + compatible = "adi,ad5529r-16"; > > > > > > > + reg = <0>; > > > > > > > + spi-max-frequency = <25000000>; > > > > > > > + > > > > > > > + vdd-supply = <&vdd_regulator>; > > > > > > > + avdd-supply = <&avdd_regulator>; > > > > > > > + hvdd-supply = <&hvdd_regulator>; > > > > > > > + hvss-supply = <&hvss_regulator>; > > > > > > > + > > > > > > > + reset-gpios = <&gpio0 87 GPIO_ACTIVE_LOW>; > > > > > > > + > > > > > > > + #address-cells = <1>; > > > > > > > + #size-cells = <0>; > > > > > > > + > > > > > > > + channel@0 { > > > > > > > + reg = <0>; > > > > > > > + adi,output-range-microvolt = <0 5000000>; > > > > > > > + }; > > > > > > > + > > > > > > > + channel@1 { > > > > > > > + reg = <1>; > > > > > > > + adi,output-range-microvolt = <(-10000000) 10000000>; > > > > > > > + }; > > > > > > > + > > > > > > > + channel@2 { > > > > > > > + reg = <2>; > > > > > > > + adi,output-range-microvolt = <0 40000000>; > > > > > > > + }; > > > > > > > + }; > > > > > > > + }; > > > > > > ... > > > > > > > > > > > > spi { > > > > > > #address-cells = <1>; > > > > > > #size-cells = <0>; > > > > > > > > > > > > multi-dac@0 { > > > > > > compatible = "adi,ad5529r-16"; > > > > > > reg = <0>; > > > > > > spi-max-frequency = <25000000>; > > > > > > > > > > > > #address-cells = <1>; > > > > > > #size-cells = <0>; > > > > > > > > > > > > dac@0 { > > > > > > reg = <0>; > > > > > > vdd-supply = <&vdd_regulator>; > > > > > > avdd-supply = <&avdd_regulator>; > > > > > > hvdd-supply = <&hvdd_regulator>; > > > > > > hvss-supply = <&hvss_regulator>; > > > > > > > > > > > > reset-gpios = <&gpio0 87 GPIO_ACTIVE_LOW>; > > > > > > > > > > > > #address-cells = <1>; > > > > > > #size-cells = <0>; > > > > > > > > > > > > channel@0 { > > > > > > reg = <0>; > > > > > > adi,output-range-microvolt = <0 5000000>; > > > > > > }; > > > > > > > > > > > > channel@1 { > > > > > > reg = <1>; > > > > > > adi,output-range-microvolt = <(-10000000) 10000000>; > > > > > > }; > > > > > > > > > > > > channel@2 { > > > > > > reg = <2>; > > > > > > adi,output-range-microvolt = <0 40000000>; > > > > > > }; > > > > > > } > > > > > > > > > > > > dac@1 { > > > > > > reg = <1>; > > > > > > vdd-supply = <&vdd_regulator>; > > > > > > avdd-supply = <&avdd_regulator>; > > > > > > hvdd-supply = <&hvdd_regulator>; > > > > > > hvss-supply = <&hvss_regulator>; > > > > > > > > > > > > reset-gpios = <&gpio0 88 GPIO_ACTIVE_LOW>; > > > > > > > > > > > > #address-cells = <1>; > > > > > > #size-cells = <0>; > > > > > > > > > > > > channel@0 { > > > > > > reg = <0>; > > > > > > adi,output-range-microvolt = <0 5000000>; > > > > > > }; > > > > > > > > > > > > channel@1 { > > > > > > reg = <1>; > > > > > > adi,output-range-microvolt = <(-10000000) 10000000>; > > > > > > }; > > > > > > } > > > > > > }; > > > > > > }; > > > > > > > > > > > > then you might need something like: > > > > > > > > > > > > patternProperties: > > > > > > "^dac@[0-3]$": > > > > > > > > > > > > and put most of the things under this node pattern. > > > > > > > > > > > > So the main driver that you're putting together might need to handle up to four instances. > > > > > > Even if your current driver cannot handle this, the dt-bindings might need cover that. > > > > > > > > > > > > Need to double check if each dac node needs a separate compatible, so you would maybe populate > > > > > > a platform data to be shared with the child nodes, which would be a separate driver. > > > > > > (not sure if it would make sense to mix and match ad5529r-16 and ad5529r-12). > > > > > Hi Rodrigo, > > > > > > > > > > Thank you for looking at this. > > > > > > > > > > For now, I would prefer to keep the binding scoped to a single AD5529R device instance. The current > > > > > hardware/use case we have only needs one device node and the driver is written around that model as well. > > > > > While the device addressing pins could allow multi-device topology, we do not have an actual platform using > > > > > that configuration at the moment, so I would prefer not to introduce an extra parent/child binding structure > > > > > speculatively without a validating use case. > > > > Interesting feature - kind of similar to address control on a typical i2c bus device, or > > > > looking at it another way a kind of distributed SPI mux. > > > > > > > > Challenge of a binding is we need to anticipate the future. So I think we do need something > > > > like Rodrigo is suggesting even if we only (for now) support a single instance in the driver. > > > > That would leave the path open to supporting the addressing at a later date. > > > > An alternative might be to look at it like a chained device setup. In those we pretend there > > > > is just one device with a lot of channels etc. The snag is that here things are more loosely > > > > coupled whereas for those devices it tends to be you have to read / write the same register > > > > in all devices in the chain as one big SPI message. > > > > > > > > +CC Mark Brown as he may know of some precedence for this feature. For his reference.. > > > > - Each of these device has 2 ID pins. The SPI transfers have to contain the 2 bit > > > > value that matches that or they are ignored. Thus a single bus + 1 chip select can > > > > be used to talk to 4 devices. Question is what that looks like in device tree + I guess > > > > longer term how to support it cleanly in SPI. > > > > I'd swear I have seen this before, from some Microchip devices. Let me > > see if I can find what I am thinking of... > > > microchip,mcp3911 and microchip,mcp3564 both seem to do this with > slightly different properties. > > microchip,device-addr: > description: Device address when multiple MCP3911 chips are present on the same SPI bus. > $ref: /schemas/types.yaml#/definitions/uint32 > enum: [0, 1, 2, 3] > default: 0 > > and > > > microchip,hw-device-address: > $ref: /schemas/types.yaml#/definitions/uint32 > minimum: 0 > maximum: 3 > description: > The address is set on a per-device basis by fuses in the factory, > configured on request. If not requested, the fuses are set for 0x1. > The device address is part of the device markings to avoid > potential confusion. This address is coded on two bits, so four possible > addresses are available when multiple devices are present on the same > SPI bus with only one Chip Select line for all devices. > Each device communication starts by a CS falling edge, followed by the > clocking of the device address (BITS[7:6] - top two bits of COMMAND BYTE > which is first one on the wire). > > This sounds exactly like the sort of feature that you're dealing with > here? > The core idea yes but for this chip, things are a bit more annoying (but Janani can correct me if I'm wrong). Here, each device can, in theory, have it's own supplies, pins and at the very least, channels with maybe different scales. That is why Janani is proposing dac nodes. Given I honestly don't like much of that "adi,ad5529r-bus" compatible I wondered about solving this at the spi level. Ah and to make it more annoying, we can also mix 12 and 16 bits variants together in the same bus. - Nuno Sá