From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CD6E2DC32C for ; Fri, 19 Jun 2026 18:46:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781894783; cv=none; b=bL3FFHX50HkycjZ2LkQSj/GlphHcf2TcNTDZr2voYtCrvFj0Km5wLZGP2s7bwQfs1P4+VCSU620k9SLWiHJm0nt4+Cd1N5+k8m/AWAyDANgLtkXVrfAC9bvT1k/K9syePu6aZV0yJQOUtOyQY41k+yUgsPIbu3sGGL81yxQD38Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781894783; c=relaxed/simple; bh=EWQLNPK1AUAI+pNpdpq3a6y6uUYIGTK0BN4j1FD0cxQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=A13T9NWEcgsZAm0CvjwdMwBviwYnGmDu7c6cfDraHES/Njigz5OCUdSEnVFqVCAuwRa8bA6Iz7Y/0s9pC35FWj2DjH7v1I1J/bZDfYMBEWHb595jhNABs4RJCXxupZn8kBO0OfntjwHKghUdQ5N18tOArGhlwiPxIjG+MGb3Ml8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=pX7HTGZ/; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="pX7HTGZ/" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2c73cefe192so15005ad.1 for ; Fri, 19 Jun 2026 11:46:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781894781; x=1782499581; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=q63lvOWSyGFyoDtx2qv9weUbM77aGJ0C15XM//TDr7Y=; b=pX7HTGZ//o06ejbjh7ScI0UzaVtVpq5iXGRkyL9JZ3Bxh/LTT1iAMKXBh/uz8UHo+C itgGMMODdxAkhjgYlK6Vs6Xrg58dA9S3TL/KE4UcMn7izFVSGUVY7s7xWWJUEvZ1Oh1i 7YvumeCG4SxNXgZTmxLkhimub66B5/Lo0MaDMpJiBF+POybhX7lBm/+tP08B2zCp/Ydh D774ypOWGH93Wxgyy0RBt7yYYLC7RenYZnx9VYouGli2s/AaKHYuZrxn/6CKsxC9SnGH 1VQAB13gkhKgBKUrK3Gkm7q+IqFfVIXVQ/fILKaMgdU7NPekzFB3hQdl5VVJ6K5Qxhq9 leuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781894781; x=1782499581; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=q63lvOWSyGFyoDtx2qv9weUbM77aGJ0C15XM//TDr7Y=; b=MrGl0zN4IF17RKj5NXZ8mW33OHoiKFcaNImK0PsCQQxaNX+Ty0pLnqVFJO9gcTWFRQ Klnhoeix8EzoZO4errAX9myTi3ghbivddduS79Bqvufw163LoeFFKDbrVv9h3PXpOGEI L8iZWsKhzaiqBeAdyx/a+KeBbytZ/OWlQqIM+YEAomXPXI7BbLgaTM7EjTG4F9VsnhNe N+KD9/7BRuNqtOncclKEAXNCqu1GfI5s/PPS0SBtOPEPvaPHQAmeWyzBi9fb+S+//6vc Brcb12x8FprmI3aaKv8xyiHptcEHu7drZv2r2bQOiWRZY2hrSgCq8VcChL+7xgIainpL lmBQ== X-Forwarded-Encrypted: i=1; AFNElJ/w1oP4jYIAG6H9CPrVCbrusVwfSNnIymOSv63U22Z+PcOcgYl8EpCxaSi//lIm6B2t9Mgv+LRru17Hi4M=@vger.kernel.org X-Gm-Message-State: AOJu0YxeATexYgW8pvoNh72YibPqJkC+nWfkjEcMXxzT6caCJW/fLBlM d90BxL6yWqk6POHNGR4tBepEuZUpStSOxX6oCfCzqaCikJSOUcPAc+0jHUOMOhT9bw== X-Gm-Gg: AfdE7clZuld7ishOvle0/GNPat7AwuLTsWHrIR6cLY8GXl4wReY9GQwsfjLbpgq7o9W BLj97RSMHnKsGWBanBp4jKYCGPiXn3grDs1qmlShdpe5N9YYIvBT3GXkefyZ97MwbV3IGrcxHPV IEFNcYNSaFDDisHvKJ9LPCswrPH58I99QvTpn9nct7LIDl3EPRkUHDEC8OwaQddW0UerAFkCJ0w sMSgkDFlJNz6tVFrUHLlH7YviuADIL0BsnMFmoPdRm1TOPyHDcQFVkKujKHSeyoKL5EIZvHPPqL Olwrc4jex0zSRfI0kvsh9CutqERGvGuaZnmlgwvKzbimLgZbbC18plAix1MVc1LfVqEdGDmWv+U vQ8FELsrm0i4mGqCx3vve2jp1VH+YrJWsyIa0wsBlPQWKnHWqcibvqGryOY/Fe17WcepRnT8/YA dnyY6HuEXzLAfwzB+8hCshryRNYMwhvxeFTCELwDFb+zKqmgSRZyk3Zg8u0hbb4LxbLH5Jd1lU8 Ma/BG0OA0NL+fShZfUohtwjpBz0QFjUrKw= X-Received: by 2002:a17:902:f684:b0:2c2:2485:7086 with SMTP id d9443c01a7336-2c72007c547mr245885ad.17.1781894780900; Fri, 19 Jun 2026 11:46:20 -0700 (PDT) Received: from google.com (112.174.16.34.bc.googleusercontent.com. [34.16.174.112]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c8bc5d04858sm392064a12.28.2026.06.19.11.46.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2026 11:46:20 -0700 (PDT) Date: Fri, 19 Jun 2026 18:46:15 +0000 From: Carlos Llamas To: Alice Ryhl Cc: Greg Kroah-Hartman , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Todd Kjos , Christian Brauner , kernel-team@android.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] binder: fix UAF in binder_thread_release() Message-ID: References: <20260606022233.2402965-1-cmllamas@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jun 10, 2026 at 06:50:17AM +0000, Alice Ryhl wrote: > Although I don't think this fixes all issues here, as we discussed more > in private, this does fix the specific UAF referenced in this patch, so: > > Reviewed-by: Alice Ryhl Thanks. I've managed to reproduce the UAF that you pointed out. It was a bit tricky but I have a fix for it now. C binder just keeps proving we should switch over to Rust ASAP. It doesn't seem like Greg has picked up this patch yet, so I'll resend this as v2 along with a separate fix for the UAF you reported. Cheers, Carlos Llamas