From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A425A3537C7 for ; Fri, 19 Jun 2026 22:18:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781907534; cv=none; b=nC4dO+njIojTE3yO4R0sj/l0mcQBlSlykY6lK4esP1BgCYTx00G5twS64MxNxxBcpYkfqq0d+/D2m/bW5BhWOmJG8qVftQAnbsvChn32dLPwp3YafSLufKAWlHSZiPA+yqoLqB+sz+s32mezmTxg0NaUEtl7Eiiqs1r2SmPZHLc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781907534; c=relaxed/simple; bh=aCnyjCR9eIvzZl98pBI592s3MpWRlTL1fX+5dzBeG9w=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jM5SXb9hWFSFMq99GsBw937r7NCNZKiuHiMOgK5wy9PEvgblT+nFiz9cNTeVDphcLdZ/piVePwWKSEdc1NT3ZIoq4JcF5YoufZ1jEk79TkSAXzQUxetPdT+j2Vc2Dd8dd3ZLp8p6iFnsGVlBAHOpQIwbXjyN6eVc7aCVQGX6Oqg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TIvqeJbe; arc=none smtp.client-ip=209.85.128.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TIvqeJbe" Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-7f69b71f7b2so29428767b3.1 for ; Fri, 19 Jun 2026 15:18:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781907533; x=1782512333; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=t/+v/F17BOqLuKfl/h17nuHBIQ8xnM0Mz0zCSXptBMw=; b=TIvqeJbeyAiWDxjeq0MDth9UcZWh5GsamzmUVvtj74AqRJhhc5zk4gfz9aJK8RDh8Z hUhohCcHoGuOsVbEJR888qDim4GtHqM50KeDrG3IEDdPF9xkp65x1p7WIOwok0UdHEy0 rhdk+O14Hd/NwnLN0by2vOImLgVBcF+GKsJTkYG8s9ltGDYG5Ph275jcDmmZUbxaC5kJ q13EPoCbiI7r/nu7tTQ3ZV7s2OB+Hjprh9OVvzFAFY5wT8PMI9v9ZPPJpa6UoeZBtI8M NHTq6diY4nuLmFdjxfBnXMxiFhlEi5SNn4yiXAt3Q3VtK85VdcGow1dmDAUsclF1iS0/ wYMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781907533; x=1782512333; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t/+v/F17BOqLuKfl/h17nuHBIQ8xnM0Mz0zCSXptBMw=; b=rUMPq72SdocSuIAcSOZoP1eh7oE8D2IHSo8MeJygfLeB1mh12PCvqIncQAhRoaVb1u yTxpLHJ8OlIacnaK+Qc7H1wmZ/OkDbmwXaHTVsj0cG6D6UlAc98TnmrCk5rQLufo9s1x cjJ0NU3kjoS2s+Vsf+mInASx17t8WKKRRxhF0HsJbHebDQ5Skoud3oTkMEjzod6VAcCg qfiPFfoGtitYvfrDqDGxSGsFp8+vOAUoUCKHW17TdnHZ+J82LWKovp+ZKlqnjXvLFuZh 7Rm6ff0iXP7qluEwHZSFXF0bc9v5GAT3VR6foEmPcyKsUXeDD4oxLjrDs4NXETBGFB16 ARxw== X-Forwarded-Encrypted: i=1; AFNElJ8zSzO+Cw++2SMVK6N1CI75jDpJMjiEOMl9YfgnUpFjIvA+yoaJ7PAOhA9tv2y/PXbOyz3Ly4cxnhANRk4=@vger.kernel.org X-Gm-Message-State: AOJu0Yyj4oe2KkSPVaZxvLggHy0RKowiGyRMFlcawjSbV6T9OD+GIRph JUCDH+1qMixJSqN+hufkucEuJdPN4wQ4r9ERoB303vtR0x+hZkM8xCLR X-Gm-Gg: AfdE7cneGFmEGqkCD9hPQ1fWI75QiXeaBFDrFt3u1BvlfBZ6ZcmWsg/usn9wpflzQVg 7Dixn1CJ46CeeHQMRHj0NNarRlVnnig9cCz0VMdKUrtV7qUilOJ3Lsh0dNztk3IIchXICXAz+r9 sj+m+D9iyY6LY5/4t4aXw7J1MZjhYwarN/TAqnB3/40zY1BiN3gpxGwcl49Vs3q0zupZW3pfg36 T/iAllAZxfnFsxuinSJUX6Tim1INkxxHWR5r1JUTDd7jvwCUPeLxAGxLax+PKwk4lm8XdpGb+UT qko9W9sJm7CTUd7PHVXmtP1nxN2VC/hy1opF5IJqs2Eooe1rM2c8TsD8R/HuK9s0CrSx05CzF5q ojgoMvqakVvMhy8OZQJYn7Rimh8W6tJITZSTkZnRYn8wTeNMJY+UAsIK9RUVNIuD73bUhDYqLCC SN2DPifDMl0uoYUJDiimcj6GscjxOzqgJ1quqIbrU6Ww== X-Received: by 2002:a05:690c:6389:b0:799:198d:8c5a with SMTP id 00721157ae682-80133bd9785mr56260217b3.34.1781907532649; Fri, 19 Jun 2026 15:18:52 -0700 (PDT) Received: from localhost (c-68-59-147-60.hsd1.tn.comcast.net. [68.59.147.60]) by smtp.gmail.com with ESMTPSA id 00721157ae682-8025cf69b5asm3919507b3.20.2026.06.19.15.18.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2026 15:18:52 -0700 (PDT) From: Yury Norov X-Google-Original-From: Yury Norov Date: Fri, 19 Jun 2026 18:18:51 -0400 To: Linus Torvalds Cc: Yury Norov , Steven Rostedt , LKML , Masami Hiramatsu , Mathieu Desnoyers , Ao Sun , David Carlier , Karl Mehltretter , Martin Kaiser , Pengpeng Hou , Qian-Yu Lin , Rik van Riel , Rosen Penev , Shuvam Pandey , Vineeth Pillai , Yash Suthar , Yu Peng Subject: Re: [GIT PULL] tracing: Updates for 7.2 Message-ID: References: <20260616180122.57a3b426@fedora> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Jun 19, 2026 at 08:40:12AM -0700, Linus Torvalds wrote: > On Fri, 19 Jun 2026 at 08:19, Yury Norov wrote: > > > > The Steven's point is the convenience for developers to throw > > trace_printk() here and there without including any headers. > > Steven's point isn't a point. It's just fantasy. > > trace_printk() isn't special. It's not even common. And people who add > debugging printk's can add a header file to their own hackery, rather > than hurt everybody else. OK, then I'll resend my patch. I tested it with build bots against various architectures and configs, so I believe it's complete. Your version includes trace_printk.h in linux/trace.h. It looks reasonable, and it allows to drop explicit trace_printk.h inclusion from: - kernel/trace/trace.c; - kernel/trace/trace_events_trigger.c; - kernel/trace/trace_functions.c; - kernel/trace/trace_printk.c. With that, the total number of files including the trace_printk.h is 30, which looks reasonable. I need a couple days to get feedback from build bots, so not sure I'll submit it before the end of the week. If somebody wants to give it a try, check here: https://github.com/norov/linux/tree/trace_printk Thanks, Yury