From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B3763AB26E for ; Mon, 22 Jun 2026 13:32:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782135154; cv=none; b=fJ7+/5aGpPiKtymr0tX1eVNz0koXCfVCXypyrxjfi3ZQUkJ5NLvq+WTdwmDEBBIaCrU8Rl9fKxI0504oLcn4DZVP+X9AvuHtBu+qoz6kmp/m7uebJ3Ti8/F8ONDkdGPpmOzsP1ElIpYf6HbjCPSpABswjTfPrqCI40BLr88EXSg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782135154; c=relaxed/simple; bh=tbZVVOtwFYLwxLichiaXb/anhWmg2HaAr18TFUDTHVM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BkhXxS06VCygpQjYSHGSZqJTUxuJVw9f8z9/pAKgwDNA7/6BS6ftHDAA4iSjpEEuNbJHMOw1HZr3T93bNi/jrVQu0zJtLakIegh8cwoV08ALhdbzr/7bI8pKkMsKKCO8ujz76S46AZwD8fNBCyy5euUNEiFNH26rhzWplJiDm74= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=h4rkmYUH; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="h4rkmYUH" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-45eeea039ebso2485131f8f.1 for ; Mon, 22 Jun 2026 06:32:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1782135148; x=1782739948; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7jc5HSn+4K0JdQCOT1UOHDiDsJE6hyDUtS3E6IsWkNE=; b=h4rkmYUHVLaK6oJMFCFO0Xi6U3R9YAJDh8o8xSF0Gb36QkXqN9t6nCjiAyhAiqw5CW 7HN0t89dT0E/VzPj6f7slbxUVGiKvdbJbNqnfjDxelyQAbfx5ai1Nya4ZxU5xBy968yj Bl+3Gqoffxl+yWR7bfLfTbYmmhobbWwmMxrso88rAHIqgVvBgSJ7S5akK5ZuhSugrue0 Lf59Gg+rlGP5hvLd5dGagzpTo1j5NYDZaOU2sc7OJVjSTAT8JKbFX8t4ReJQQestvrrq x33lV/O5sGRZWL+0jTC9sacqSqjDSDoD7N7DaQSDlQ6T2dipClK5tDu39yVeURdTuhP7 uFcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782135148; x=1782739948; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7jc5HSn+4K0JdQCOT1UOHDiDsJE6hyDUtS3E6IsWkNE=; b=c3n40SVVwgSrIlh0DbvhZRFvwzDEL9KZUxw7OK+b6GavsqwemmQP4GQo7B6WpJZW90 I2zkWKlo00yKYEOoW0Ed2sMi/YWoAE8t3KEkmdLmEQTd6gW/IcGIwWsVJUN6fBQVp8uh xr2hkUBNcxTOFlTf/QECemy2qDbQYs1bsZCn4uJOD3D5LvpZ9wwKLgcmeAPPnmxUDJKO FelBbvcHjIusNG7fYO6z/oKE/o52b9l6wZPftidjtPfdZG6SV/w4d8fNDQ8W6qsrRkK7 u4KCVfnhKPpWkEAovi/k2zMWQeKt4T//kSCuxQmevtOZu6VZpneAPfwsbXj714Cceauh 4GCA== X-Forwarded-Encrypted: i=1; AHgh+Rom7T7qAQzFk7C9zOTAiO85qcb24XRnUmxJqDdf0BLUCQduEbf0kRUj5TZYhW57oCGEpGn8IoANTOykPIc=@vger.kernel.org X-Gm-Message-State: AOJu0YwSQnM7QOGjeqVIottV5+q2KcVpJBG+IJXRa3EkFfUYcwRRQ2mL N2ecP7b/MBldzUEWAHtuCcEnHtsP3fxxtdOmEFIdjal0rGppGTiR0gu+398Zcj64kiA= X-Gm-Gg: AfdE7cnoR8fRAH3aIKRFwBb+YQO0kDM0d+GOAK1oiton8e521IMZeMLNj4uKQMSpbUf Cz+CbZj9LHn0JKn9HWYhG2KaG5FOm2shqv4gfIx3xP60x5nY2qpaIsZQicMvTW48XxenUYJKqJo SQDrO8do7zPzyEw/26BgChOtOmspFSCbewNo5YX3Cl+vMdkvXpSXrGGmQs5544AisNdNlHJhy2i JTEKFR+hup4yzg30HcPsuYbe02PgB2iwH9+34a86v3iHSmvhb4ol2E+IOd6wHbVm0Etdze6fTNL 6qeFARz3PNfZBu9r29NQLiRCO2LaGMvTKPJkTsvOm+3aIGtva9DW8iz00xE1aF5cuxPqYApNCCk x1XnyzTRBHis+jUJuTkBWW1RBza3/dzXuMOQbUgQRwhmVe4P9Hqqs6gA8DapVC9kouAfcYHgCvr X2my3Bv3f8uDiSR33/TlEHE79C3jWa3V3Wh0/mFb+Vf0vvj/r21gMpsiEqyd//0aSDlsn7iCRtL a0U X-Received: by 2002:a05:6000:2386:b0:460:1967:abed with SMTP id ffacd0b85a97d-46503646b28mr23423097f8f.39.1782135147573; Mon, 22 Jun 2026 06:32:27 -0700 (PDT) Received: from localhost (p200300f65f47db0439f7453c727e8fab.dip0.t-ipconnect.de. [2003:f6:5f47:db04:39f7:453c:727e:8fab]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-46667221da1sm25881623f8f.36.2026.06.22.06.32.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2026 06:32:26 -0700 (PDT) Date: Mon, 22 Jun 2026 15:32:25 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Andy Shevchenko Cc: Jonathan Cameron , Oleksij Rempel , kernel@pengutronix.de, David Lechner , Nuno =?utf-8?B?U8Oh?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 03/13] iio: adc: ti-tsc2046: Drop unused member from private data Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="stbh7ln7otlrn7lo" Content-Disposition: inline In-Reply-To: --stbh7ln7otlrn7lo Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1 03/13] iio: adc: ti-tsc2046: Drop unused member from private data MIME-Version: 1.0 On Mon, Jun 22, 2026 at 01:30:09PM +0300, Andy Shevchenko wrote: > On Fri, Jun 19, 2026 at 05:54:31PM +0200, Uwe Kleine-K=F6nig (The Capable= Hub) wrote: > > .dcfg is a write only field and thus it can be dropped. >=20 > Why isn't squashed with the previous one? Because they are two different logical changes. But I don't feel strong here and can squash them together. > Also, what about struct field and the accompanying data type > definition? It took me a while to understand that suggestion. I guess you're talking about diff --git a/drivers/iio/adc/ti-tsc2046.c b/drivers/iio/adc/ti-tsc2046.c index 97ecc429db27..125f6d7e2d84 100644 --- a/drivers/iio/adc/ti-tsc2046.c +++ b/drivers/iio/adc/ti-tsc2046.c @@ -121,11 +121,6 @@ struct tsc2046_adc_group_layout { unsigned int skip; }; =20 -struct tsc2046_adc_dcfg { - const struct iio_chan_spec *channels; - unsigned int num_channels; -}; - struct tsc2046_adc_ch_cfg { unsigned int settling_time_us; unsigned int oversampling_ratio; @@ -213,11 +208,6 @@ const struct iio_chan_spec name ## _channels[] =3D { \ =20 static DECLARE_TI_TSC2046_8_CHANNELS(tsc2046_adc, 12); =20 -static const struct tsc2046_adc_dcfg tsc2046_adc_dcfg_tsc2046e =3D { - .channels =3D tsc2046_adc_channels, - .num_channels =3D ARRAY_SIZE(tsc2046_adc_channels), -}; - /* * Convert time to a number of samples which can be transferred within this * time. @@ -738,7 +728,6 @@ static void tsc2046_adc_parse_fwnode(struct tsc2046_adc= _priv *priv) =20 static int tsc2046_adc_probe(struct spi_device *spi) { - const struct tsc2046_adc_dcfg *dcfg =3D &tsc2046_adc_dcfg_tsc2046e; struct device *dev =3D &spi->dev; struct tsc2046_adc_priv *priv; struct iio_dev *indio_dev; @@ -767,8 +756,8 @@ static int tsc2046_adc_probe(struct spi_device *spi) =20 indio_dev->name =3D TI_TSC2046_NAME; indio_dev->modes =3D INDIO_DIRECT_MODE; - indio_dev->channels =3D dcfg->channels; - indio_dev->num_channels =3D dcfg->num_channels; + indio_dev->channels =3D tsc2046_adc_channels; + indio_dev->num_channels =3D ARRAY_SIZE(tsc2046_adc_channels); indio_dev->info =3D &tsc2046_adc_info; =20 ret =3D devm_regulator_get_enable_read_voltage(dev, "vref"); on top of my changes. Yes, that makes sense. Best regards Uwe --stbh7ln7otlrn7lo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmo5OV0ACgkQj4D7WH0S /k4p6Af/SZg0/AqIJrKcgKI/q7SnZ69RMvMCHHDxKiNdlK4ejPyuIwfxvZpT8fjd DCUlqvNIX83EEFBha4DTCyGYkytoigmyP53CYg/DjxmrMpANcgqCcGrn/kGWMS+S 6Sm6y0QsyIfYUoHI9oTc+RN9bb0ucUetcLpGSIo1zFQALOKEOCll/HfWee+E6c3Z EkZk5t7gPGUIyr1n1emAmjlKHKyEXRIMTBQ1ptAJINPmT3Vin+02LTU+7eIByG5I 3sYWsbzE8XJzY/qTo1Wz/iZ7MM4WJY+Z38XfguMBU0ZwTAZWo80CDrJHPbUPN5MR HYB994+aDn4LBQX8yIy+KONYxcOPkA== =1nqN -----END PGP SIGNATURE----- --stbh7ln7otlrn7lo--