From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED4A325B0A4 for ; Mon, 22 Jun 2026 16:15:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782144947; cv=none; b=DwHMA1D/23PfBvo1FXbhBt5QM+k/wbbucHS09ZcHlduv1xpZFoiXWV4FA5CdxJHv9pPTglxA4RppGWuzz7AwrLabwHsmoJD5A/jHAPpCu21byEa7zxyY7Bv3MiM/Z4d1NeZIpgPvxr1nqzWahwISMOUQwpmgXXX8c78lP7SOSIQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782144947; c=relaxed/simple; bh=zRncht//PInKMEuS4sg5fyC0BItulGq5pVMOQvZq4OQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EkD0d6AX4LrtHO2NIeA4SCX5gI1B/CNXTXt0GdhwKBjGdbpFNALuEAXO9sDlb0E98z0dPkpBhcPNAgo5y+S6JVYXvhghfyYvVgSOcZJjlItqGw+5AnzqSiOQtkP2SoLZYseWD8kInn8xPlddNve3Z85LH/zmKX9YypZ17hPbMxc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=gaM38OJs; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="gaM38OJs" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-491609cdd8fso28440925e9.2 for ; Mon, 22 Jun 2026 09:15:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1782144943; x=1782749743; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zRncht//PInKMEuS4sg5fyC0BItulGq5pVMOQvZq4OQ=; b=gaM38OJsOxeIwgx3W5YIlzeNGUeSVvtImEo0xjR83QyP+yS/8AMEBptcP1zTmwm85r k4C/hpJvFOt3W6BdAMDsLozO90h1ReYE6y3bgOVzxnruagx+o/KHt/RisRBAbASQ7kM5 U3alsHf3Gtjrotd5J84usz3utSUAOfIX3HRwbz/hlzCa9LAOE3g9Wge90WECLXjrbv5x wVaFW0s4JqZ8DnOvm56wwL92gj4ZrpR0oRLP0A6L90Xu5NHMXZZtmNTsZY+CbWyCyS6W Qc4v5qKWgiV2rhv5b3n8Z0dFuQJfOufZ6fNHWgnypennrX//CCwJVdLll1MQ41aG/W/T fdkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782144943; x=1782749743; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zRncht//PInKMEuS4sg5fyC0BItulGq5pVMOQvZq4OQ=; b=b5RsYA4+QtOyRy9jujFQdLmXNo91ZA5iEx5oXN8zAUvU58VVOqRP2SWHixGuNpVefK huPpThJnFMz8W4kwUyhK4ANj7db21JzlPdFZZHt0o4pH5lkIzdk/g4nThwboYrOjnd7r TXeGYrSE3OCWeH5sgDwxR6n9b+ci4/K96NPxGJBgzsxovWeaAQiCf0FVEhV1RN2SvjjT IXdh1TbYrQ5sUO1Iw+4BF6BV1om2y7wtSwIf5LJVXTsOyhCeJdgYJtNY29KH03TYeDrr fZjd9tpWAwlS61zWToqawUa+z67wUzZCR5v5cNlFWYpqoOu7+UE+NqlUjCyfehFXMety yvUA== X-Forwarded-Encrypted: i=1; AFNElJ+1vOzI1azC5V2tIUcQ3S2qt0o0Ar4SwB49WjmMARxDZ4wABhCmSE6X+uZJQOhlI8lFggw1ZyLmYtHuDgk=@vger.kernel.org X-Gm-Message-State: AOJu0YzpB68eOYVI4JUdqZJ+mrYfKsfmIjYUa7Mu1Md+iIhbwIW3CpV6 9GDJE5i/+7DShkWGNTQna4aTjO5XVgKKZnbUE77fHM6TTs+fA+uDhV/+6wQaw04i6+U= X-Gm-Gg: AfdE7ckQDPD+5EQQxknx/J4sB0ucTac1spBcbfz7QbRnlfHKnyifzN6FkxHx8cyklrh /Tn6zyhltNuvEnuziwpAWKfiFrbB0RZMKHZP80JwxNmJ1ERHc66GAcjyjMpeoGYBXEni97Xqs1j Rbm6bQG0PO89VvK6v0jv30D57fvvj41YOhlvN+h5mm28RmAZXtahAgG5DNUP/H6a7n5hC5nwoLu lexzGs0m+qbB7RPK+NQgqIxN7oxo0PfqSHilm4o9k5CxXM08J2useyiNtOKII+v8P40pPDxhYZY HFegHIzlUgePVrTW6ZBnx60vfrfIRpsFFcDJzJeTo3u15adMNEV29atWOqYBnN16/R3Q4NLgBNh C62uaxj7RDrSomYg+zLQpbG5nBtbtQq/DDC/F6NJfw268PR7wuvaOS+QZWDu/bm4S1Zkt+C9Isb kDJvbwAEBw+acms5L1T8DsCd3M7AxiURJOAKe2ara9YcXIE9rmenHAX/a6Jmhkee8QF4oJ8Qb0j 3k= X-Received: by 2002:a05:600c:628f:b0:490:bd66:e522 with SMTP id 5b1f17b1804b1-49240e72434mr246625255e9.29.1782144943295; Mon, 22 Jun 2026 09:15:43 -0700 (PDT) Received: from localhost (p200300f65f47db040ad79c14d83edb3c.dip0.t-ipconnect.de. [2003:f6:5f47:db04:ad7:9c14:d83e:db3c]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-46667221da1sm27127062f8f.36.2026.06.22.09.15.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2026 09:15:41 -0700 (PDT) Date: Mon, 22 Jun 2026 18:15:41 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Luca Ceresoli Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Lyude Paul , Danilo Krummrich , Marcus Folkesson , Laurent Pinchart , Jernej Skrabec , David Airlie , Simona Vetter , Jagan Teki , Liu Ying , Adrien Grassein , Peter Senna Tschudin , Martyn Welch , Russell King , Douglas Anderson , Dmitry Baryshkov , Biju Das , Tommaso Merciai , Manikandan Muralidharan , Andy Yan , Xin Ji , Loic Poulain , Fei Shao , Arnd Bergmann , Kees Cook , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org Subject: Re: [PATCH] drm: Use named initializers for arrays of i2c_device_data Message-ID: References: <20260518100401.631351-2-u.kleine-koenig@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="y646ypfl4vteiwwb" Content-Disposition: inline In-Reply-To: --y646ypfl4vteiwwb Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH] drm: Use named initializers for arrays of i2c_device_data MIME-Version: 1.0 Hello Luca, On Mon, Jun 22, 2026 at 04:50:06PM +0200, Luca Ceresoli wrote: > On Wed Jun 10, 2026 at 7:15 PM CEST, Uwe Kleine-K=F6nig (The Capable Hub)= wrote: > > On Mon, May 18, 2026 at 12:04:01PM +0200, Uwe Kleine-K=F6nig (The Capab= le Hub) wrote: > >> While being less compact, using named initializers allows to more easi= ly > >> see which members of the structs are assigned which value without havi= ng > >> to lookup the declaration of the struct. And it's also more robust > >> against changes to the struct definition. > >> > >> The mentioned robustness is relevant for a planned change to struct > >> i2c_device_id that replaces .driver_data by an anonymous union. > >> > >> While touching all these arrays, unify usage of whitespace in the list > >> terminator and drop trailing commas there. > >> > >> This patch doesn't modify the compiled arrays, only their representati= on > >> in source form benefits. The former was confirmed with x86 and arm64 > >> builds. > >> > >> Signed-off-by: Uwe Kleine-K=F6nig (The Capable Hub) > > > > who feels responsible to pick up this patch? >=20 > The affected files are mostly in drm-misc so I could apply it, but I think > we'd need an ack from files belonging lsewhere (should be just nouveau and > sitronix at quick glance). >=20 > >> base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731 > >> prerequisite-patch-id: 7779c63f16ef6f7247cdb71c89e66b27e299eb74 > >> prerequisite-patch-id: 6f920b6f8c31dc0ad1689200c37680755c20ce8b > ... > >> prerequisite-patch-id: 915b7a2276c5a38944107c84bb282271d0bf28f4 > >> prerequisite-patch-id: 76d499a624150588f7ef07dc087e70eca6f33419 > > > > FTR: These are bogous, there are no dependencies, I just wasn't > > attentive enough to drop these lines. >=20 > And 'b4 shazam' messes up because of these lines. >=20 > Overall I think it's better if you resend after splitting by tree, and > removing the prerequisite-patch-id lines. You can keep my R-by on all the > patches if you just split them without further changes. Thanks for considering to merge, will rework as suggested. Best regards Uwe --y646ypfl4vteiwwb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmo5X6oACgkQj4D7WH0S /k7aZAgAgxwaByetfG1d2X9atyXsHeGlCD55Pa/o1ew5duFQnVUaJvcNEbVOSZz+ v0V/9dVyvNdjtGDK5wSDDEBle2RShIvlf03cFHzxv5+2JujQYFFyL9KdAfPzgD4F u4JUNJ2tRoP8FKGjRrXfssn1nYDjF7CNf0uO7gBiA+gLqxixduOncPUKGDZ6aFyr vM4ndnOVMHZODdxv5jMZmpOfHDccoTViPQTaIo5B+/z7P36XleQvKA5rXc5lZDOK /rK3pfF/ns3LNa8qnfBbE415HX4DQT5KjLfETJjhxDUMrwQWZrcjGXqQuNscdIjY MXDXgyQ87eH6Os6E/yY2h51+U5vUlw== =YE6V -----END PGP SIGNATURE----- --y646ypfl4vteiwwb--