From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4CE534C98C for ; Mon, 22 Jun 2026 20:23:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782159833; cv=none; b=Y7HCx/7vq+R9y+dnWsRtN4SiWKAgmvNHCY/m8VDBu3nr2KTTXK+tcW69wzNqPN2qtDXrJ041BAWgvlaiIZXlPi4VE7hobkLvkZ0RNyZKLp9fy//cKu3EbTgDbz89b5g9wydE/hpyYDDqWWElYC8NoJxRZxdyP5Y4lyqUjqSeH20= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782159833; c=relaxed/simple; bh=L7H2ibsXc8PoK8CbMSVQjpP3esUP2noyWgkyHLN4J0I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=owPP8rFOF/S4KNP8bfAnwoW1mrbwajWKqA2Zce9P+6QeXYdmCj8+sXMDmTpShluWu5ENgY44P6Vi2h0kEyGpMoc0PO/SRpbNNjca1C0+zYJunOk3Bl+n6ztpUl+fErIypUcOu1FOOllfd8dxblVAtZ7/y+qwjvTqVnRRA7+Ami4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b=e00fEzYd; arc=none smtp.client-ip=209.85.219.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b="e00fEzYd" Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-8de7bfa31d5so53199666d6.1 for ; Mon, 22 Jun 2026 13:23:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg.org; s=google; t=1782159829; x=1782764629; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DmKAzXUWgr5Z6Z1mBVW0DXpsiSegxpV2RCsb4MGdO1I=; b=e00fEzYdm3eKKkSjXGKsOE3t+yVBkHwDQ3dhgoj4BlE/cyobHqlXyVvQBAwYSTdxXy 5a8R5TxzHXSr7LO9ZJXULz3/W8FMmG6bUI1RryaOTXQaSeAW0Kyg15HdOdoKTrvjNnlA Dz1O+JuNNTjwzENemuE50HWUh3/kpslePtQ4RZnV0wb9d3CKgF6wTIPuz9TrmrcgBtZQ 4MAGe5AUSd6kBuDwlvpNzOUFAZtXuCzbifmPxrZYh2lsSXtfwtmzU0n1oSoDppTr/VJ6 1S0GPmgWAQ8X/c8IJfO+sLUJZQ5TFyqJ6ApX4TkHFl9Mu5ZVd/67u4GEeBI0EPn3qCbY 9pew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782159829; x=1782764629; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DmKAzXUWgr5Z6Z1mBVW0DXpsiSegxpV2RCsb4MGdO1I=; b=dVoerZKhaRcy6mm1cewSU8kaSsGdBM3YMh//7tcX+tE/N5dFU3Leqxs9A2N2dvmVp0 RBg8/w+Lf62ZEUqrKbjd2kpLGk9qu1FgAaxhic66AN0CrHjbwm3rem4ibTZoSKERD4jC CSai/eSupkkfWlIvP7zmz0oLd7T/m0YjKeZmWmiGGaSFQDePgVD9KlsovphTYSw1y44L fqVGiYKs0OgftQWlshM166lGOusgICRDPGfzP07+xfmQJRChhlGqB9rmoR0/bgZQk4pP BIY79tnnD2XrplxxPkM9ipPRFvngAFp1yUXWSsq9HnIOehbSXrxqtwgnU9fsP6V5F/rA FtSw== X-Forwarded-Encrypted: i=1; AHgh+Rripi16WhH1558X+Wgc6oho/XBKJvwJhEMx4dKtfPdz40Kg1csriXKFpbJqLd1xVkjemyJlXfVFktjl2CM=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+CE4qtK4Jv/eElqpGyshrKRzgPS4peNVr2hQqXfdWRzNzSqfV 9E42R4ltuBiZiOQ3pVNv3BU6oWaipuHVly3GNsQLonFJxZhIn4PducJgk6q56vGaCGhA3/ImcAD c5nLOXJBUHw== X-Gm-Gg: AfdE7cnRpfA0EXJiLmKrSqMlLsyt/3q0Vjp5VCXRekFqHbs1Bk9DoUmEh09rngFkzd/ fUthNZGFPROODInIiTyhCh6GJsT5HOnbT2gLdElfW0LbIowLgURoqiTYLlfoj+L9tOEfGV2He3V UYoh5toeqk51wG9pcvO8I3pgpJCeR75w3Tz8TJPLOrI5s8IeyVrzkmUWKVaJaQ8VAmusn3LjInt Bg0MzHn7XsyJJsEn5WphkoqGGWX/vQklbYscdxWbVwwitXJA2zsM6KqVRgIGQvjY8hVmtQ7Gu+G cx7HGgNiyfkq18mfWCAUdXC8UKnMsEU5AAIR8K21HwjzpohkQT/WagfutXCH5TfOn7l2CP3jW2g /c2oZzXkbiF/3kRo6LeCfLOzwpfj+806HVPNDDnYbmCLW+IKCcVmsFGGaLbQd3aTXzohhnDmlT7 yPS+bYyoKChZ4= X-Received: by 2002:a05:6214:3314:b0:8c9:cb98:5fb1 with SMTP id 6a1803df08f44-8de3f78e4f3mr241102106d6.12.1782159829411; Mon, 22 Jun 2026 13:23:49 -0700 (PDT) Received: from localhost ([2603:7001:f100:500:365a:60ff:fe62:ff29]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8df81cde319sm105792376d6.31.2026.06.22.13.23.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2026 13:23:48 -0700 (PDT) Date: Mon, 22 Jun 2026 16:23:44 -0400 From: Johannes Weiner To: Zi Yan Cc: Andrew Morton , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Baolin Wang , Jiaqi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH hotfix] mm/compaction: handle free_pages_prepare() properly in compaction_free() Message-ID: References: <20260622-handle_free_pages_prepare_in_compaction_free-v1-1-fcf3b14abcf7@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260622-handle_free_pages_prepare_in_compaction_free-v1-1-fcf3b14abcf7@nvidia.com> On Mon, Jun 22, 2026 at 11:30:42AM -0400, Zi Yan wrote: > free_pages_prepare() can fail but compaction_free() does not handle the > failure case. Failed pages should not be added back to cc->freepages for > future use, since they can be either PageHWPoison or free_page_is_bad() > and might cause data corruption. > > Fixes: 733aea0b3a7bb ("mm/compaction: add support for >0 order folio memory compaction.") > Signed-off-by: Zi Yan > Cc: stable@vger.kernel.org Acked-by: Johannes Weiner