From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0C2F30ACE6 for ; Tue, 23 Jun 2026 13:17:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782220627; cv=none; b=SjTtaLIaRqIo7nhFaFAe7LGuG10gi3CgrY4dXmlCuPXc2XNnGpwRlpWm2YYwpuv9I6+LwbSeTuGjQ8eWQ/MRXIIppBE/QNKG++vxTuEjh1ZsQGEq6zjihHxXXNast+EqfX28vELGvNSJi7raUiCV9Fd/u1W4bf9TUcVhWVJ7tcA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782220627; c=relaxed/simple; bh=yHyj608976wab40x3rsluhL1qNNC39+L2MUtVW1iYSg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gz6qNc39pTEiSspKoeaQ8BnetMH3zFnKPD7zc2mIIZHh1AXcAOj4pZ3AnEBFiESyfyrbGufHyFGntr+wFdRtfS8eJnHFtrGdE/Jphml+TCol2yMPwP1K1KjlM/ZCNVffshfhJTUF23GXSq5PRxGCIZXW3UsqqdJmWKUEZ/X3HwQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jfoyxEy5; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jfoyxEy5" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-696bf0e7c9cso2302003a12.1 for ; Tue, 23 Jun 2026 06:17:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782220624; x=1782825424; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cC6Cq8bC4aGlsoHvL3LiTDVV50IQJG1ncLB50xy/GWk=; b=jfoyxEy5aE6ZVUcSFMz4Y6l8G0IE5vulvYuvS58u1oTMF9FrrwpQE5HPgmVx7/uEEZ WeTsMzlKpLmsnuwDPOhheJu6VZQxYHaJCgcDSAc3gkdBEh5x/gyKaGvwXG6X3JKgPJbK VyVf9Ms16pvSB6BvW2ftdKVt1IwhOzBm7c3Og3Z+k4h7CDE99jnVVfvxuL8RXI+Tgu9M pWHzJ3Zej4AhHCWsTWysyFk5xNyCa/4042LI+xoqP0mkLQc6rDs7qhnhvsYjSk/I7w5c yYfX+yus6YYEKEZ9GXIvs5OnVFFzA3YEP5DeYem9nxI4gWsa6pQe5xUHZIKnzDmEc1kS MRWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782220624; x=1782825424; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cC6Cq8bC4aGlsoHvL3LiTDVV50IQJG1ncLB50xy/GWk=; b=si3xBRIeEBg2uHPJHQjFAMQpiKhu7qSq3GU7SdRsmzxlInopokgBNT64IAFvZBtXvK xjPqwySfZR4k6DzG7NzBrhfJlYBVAAUBZdXGoLx8lLSR442T0j7McNgsQ8BST9+dc12f Y9u+WMxr+EXlU8n3lJVARVWV1ua9kiGDNeho7AutmwDG/ZWH2WL2YNyY+QAKy1yAMIgr PHkwEhbFoPbJlneVQBxUBmSzeKlca5Gc59nay4iOhePi1dw42ZmupudPzXH5Iz1MGGyo FuARZeOPV3vfUfWOEr3UzbyliRbgpHjDxF1nrdGvyTw4E/CEOfL+NSszEQNPGpsGMnw6 LMJQ== X-Forwarded-Encrypted: i=1; AFNElJ9AgJPAG/OJacZiAA2ZUgL8O4Cv+kZxEnzsWIY3iexpXhjSxZePOt/Regdi8yEdmvYR2kdQXV1KUlodv9k=@vger.kernel.org X-Gm-Message-State: AOJu0YwkjyfvxMcTmDk4ZTrE1VoPJI6bQnPgRoRWNzVoB072FWZGxC9s GEwDWCMlW3HHaIo5g8lWsth298R98U2Lb+8WqBJCvobWGQ3Kq/VD3eTn X-Gm-Gg: AfdE7cm/5+4VcCe49sqU3aQe0YJ1BK/Cul8vGeV+IpMW3FpizKi31/RMSxQuNOPUFtJ CEzWMXA2uxN1tP7gDTEjvDsA7oF0FnP57ImACvwDPLl0XryxQ13Fn7QCtYq4w6JNgWcQaywOiAj FZxmLPFH7wZxPk6F71q3s/9bezGB9JD4EA7IAVIwF3fe+JKeGw52lHeGY1zVQGevX6GNRYyk0wr 5XK/81f1JFQYQGx1IJE8GkltznUPWRsf2yQoSKMExd3/zDRJkkYJGfxWBU+OGwpuAT7nbSRZ3Lt rPNYuOSCIf64KquC9vcZSyzHOLxDQI8Y5mrDRTc6VpZ7X5tR1qeDRdWLUuUcD13HGRO8krTSEbp 3A9PwEv2wEFNhRd9BKo44VbJ+oAYk71HhzCoYhSQZF9NfmOQsi7nJxN9an5RKkzn35CYI+wVIse nUGdBA9dUd X-Received: by 2002:a05:6402:4022:b0:68c:3439:945f with SMTP id 4fb4d7f45d1cf-697d4315887mr2014951a12.12.1782220624018; Tue, 23 Jun 2026 06:17:04 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6977b82ee0bsm4934979a12.6.2026.06.23.06.17.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2026 06:17:03 -0700 (PDT) Date: Tue, 23 Jun 2026 16:16:59 +0300 From: Dan Carpenter To: Batu Ada Tutkun Cc: parthiban.veerasooran@microchip.com, christian.gromm@microchip.com, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: most: dim2: use dev_err_probe() for clock errors in rcar enable functions Message-ID: References: <20260623124243.1245-1-batuadatutkun@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260623124243.1245-1-batuadatutkun@gmail.com> On Tue, Jun 23, 2026 at 03:42:43PM +0300, Batu Ada Tutkun wrote: > rcar_gen2_enable() and rcar_gen3_enable() use the old pattern of > dev_err() followed by return PTR_ERR() when devm_clk_get() fails. > fsl_mx6_enable() in the same file was already converted to use > dev_err_probe() by a previous cleanup series. > > Convert the remaining two functions for consistency. devm_clk_get() > can return -EPROBE_DEFER, so dev_err_probe() is appropriate here: it > suppresses the log message at error level when the failure is a deferred > probe, avoiding misleading output during normal boot. > This feels like an AI patch. Please state when you are using AI. In fsl_mx6_enable(), the original code returned -EFAULT if devm_clk_get() failed so change it to propagate the error code and use dev_err_probe() made obvious sense. This was done in commit b7a013c12504 ("staging: most: dim2: use dev_err_probe and proper error codes for clock"). In this case, the logic is "monkey see, monkey do" which is reasonable AI logic but it's not enough motivation on its own Does devm_clk_get() actually return -EPROBE_DEFER? Does clk_prepare_enable() return -EPROBE_DEFER? Should that be changed as well? > Signed-off-by: Batu Ada Tutkun > --- ^^^ You need to say if a patch has been tested or not here under the --- cut off line. > drivers/staging/most/dim2/dim2.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) regards, dan carpenter