From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 934D837AA75 for ; Tue, 23 Jun 2026 14:15:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782224131; cv=none; b=VsLD6Ui/ppcEzoL1p5i6HHsMAC65a+fE1eThauQidnskm+4R66UEnRrAl6bv9g7Nzh4nJ4nxCcDMUtuSpCYX9h8FPWLyIw8bF0uFaY7vyepUrSNkuj26sBZ+Bf3sRZTf0DNHRVOd5gUxGpKhAc3oEIPH224rzrzQvsRHShYdcDI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782224131; c=relaxed/simple; bh=1CDyLYs9i+XbI4Sgve9hBq+4Pv0eYZPQlHzEOlzvrk0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=d2L28PlL4RMgHIiF4QS/D4BEdCvnQu8fXh8Mk3/hMgYOVBQVWlJYmgsU3wuFYi8dLMQyYWAX5Fyc1kxS/S03l90JxNpEmz0qNbO3odcN82T7dw2p+YHLrl8aEYna+nuGiksSwEU/OkUlJU3pxUtA7OR5BMxfGmb36J5UdKHqYlI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JfTrQuc0; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=oGoVY6Fe; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JfTrQuc0"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="oGoVY6Fe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782224129; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GcRTCVkjYUUItg6iTxHwmqo3jGbyzUdvgEni0gISf78=; b=JfTrQuc0NxIWIAveIeGZOUqgMB0ATKb2i8WiCg7e+8iS/pul2mDA3NAD74sh3lxhYQ9S6g zDCjWzzvoc9RIV5igv0AJtwiCv5I2Df+ob7N1VXlIEDvsBfK+eWsnCRtca9WIOmf69d5me afRIqpDA+phesXeR/BxXf/4Ll/MMIuI= Received: from mail-yx1-f72.google.com (mail-yx1-f72.google.com [74.125.224.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-93-A9uAI61NNZGwXZk2HfKveA-1; Tue, 23 Jun 2026 10:15:28 -0400 X-MC-Unique: A9uAI61NNZGwXZk2HfKveA-1 X-Mimecast-MFC-AGG-ID: A9uAI61NNZGwXZk2HfKveA_1782224127 Received: by mail-yx1-f72.google.com with SMTP id 956f58d0204a3-662f741fe3bso1610568d50.2 for ; Tue, 23 Jun 2026 07:15:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1782224127; x=1782828927; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=GcRTCVkjYUUItg6iTxHwmqo3jGbyzUdvgEni0gISf78=; b=oGoVY6FebBOdr4BYu4FPIM4pINiUgBs1gxdmB1P84qv+D62p+TLh6vEDycNGYoqUe4 mtUEI9gPw94phQh+Kt4GKh+ucIg9FEZdPbII2vwtcp+XW0gFwC46HJjSJ0lrdn67tl0j 8g57XfJ+awvOew2AEeY1D6F+RGXi5oKhhGfSCmIxnPpt8x3IH3pgKwXChGGSixf0MUhe FMHAj2nw2JOAfEr5BjE4x9KMgvQiurlkok71ZCd9Ah1iIydTGsvPB0T+V4eR8/JQ/n52 HaP+CR5W3w7MW5ceWG+Ebl/pQ0rNnR7HprMCB3qXvMnfhir7nYo6mGC9Af1vkgv4J4Gz XoOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782224127; x=1782828927; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GcRTCVkjYUUItg6iTxHwmqo3jGbyzUdvgEni0gISf78=; b=OKNJY8FHZEL0//87cnuQxUISBD7ZENrdQA5si7hkL3iWyCpWXFHT2lBI2y99LR7zMX 07BSRLR8ypaDPneQl9rdT3C2eD1nz5TfsYqWpgU5ricb+IVEkqCJgBVoFO23nhGD5jMc u+5n5HzPXHI8F+7JD2c2QNhpU9baRZcypUbpCvp7CKYN7Ji+pjY7M0K6VNavk3hTVcG4 IrigWAI2h3/htVC1dteeRfAsiWDN/BJJMrf+F6UyhVxjBbuvxSQq8MU/i5Mdq3I8+ivV s5fnFbw95mK8U96AtqknAcU+NmaGbJ9Hz8g6aA6huaFQKD5G6J5lpuSnoOJIn3+OUEdK ZdEw== X-Forwarded-Encrypted: i=1; AHgh+RqJYwnEaH10lhA1uxFqs48edTI9MERzxIpHkvFHiDDp1sPoQlZkjpZxx3OvV6SnvREJAVSJB5YXhbV4pjY=@vger.kernel.org X-Gm-Message-State: AOJu0YxUhMn0kkcjpyDxW1Sj7jngLg3LSD0fKTMtHmTV1phHbnu75umO d6PSUP9te3A4tThcsZ1i3ly0jBMQ8AnAlWZgDEOGhVNflmaz+xrNaOfGf6yux5SdWp0Wsoikjfc /ALXqTXK6sYz1CiXM8FiDaYS01Yj3cuSsLso7GsOTmqaQdhII9uBmKTfLjMMzowAz5A== X-Gm-Gg: AfdE7clslfhC5e9pIl7vKhdez99wS076ePSV9AIvBD4f8kOikpuNpiHxxrP19KUibt2 9CugwDtnPahplHWRyOdtDX0yE5WRiCEk06gpxnQAFRoPx9FlRmkcktcWyCEClwdCg5ko5Av0SZD nh8BFIlsz8u8Sm9hDmyS8zaP2xLw0HuSRV4zqfgnN9ljxn+WdV/uG8OYdXvutXm3rLM1XlGbPgE xJHprZtXdC2Ngyh8Y2WGc0+5vOygUySM3TIi8rl1CgBWBmG4tkDRkUqZZyatfwxvP/6Hpevm+/m LPZCIkFB123nHDOBmLDCyJZ9s7Vf9v24632SsOWKTwrEI3r54uBtQD6Mgqqhra3t3bNG8eFpa6H u+25sT+pEwwezMuOOm0mboReLasSAjeqLBSQeAtozLGUZFg== X-Received: by 2002:a05:690e:12cb:b0:662:a4ee:104b with SMTP id 956f58d0204a3-662ffe593c4mr17495481d50.48.1782224127248; Tue, 23 Jun 2026 07:15:27 -0700 (PDT) X-Received: by 2002:a05:690e:12cb:b0:662:a4ee:104b with SMTP id 956f58d0204a3-662ffe593c4mr17495392d50.48.1782224126475; Tue, 23 Jun 2026 07:15:26 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8df823ab84esm126185756d6.37.2026.06.23.07.15.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2026 07:15:25 -0700 (PDT) Date: Tue, 23 Jun 2026 10:15:24 -0400 From: Brian Masney To: Myeonghun Pak Cc: Alex Helms , Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Ijae Kim Subject: Re: [PATCH v2] clk: versaclock7: Fix APLL clock leak on probe failure Message-ID: References: <20260623094023.94231-1-mhun512@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260623094023.94231-1-mhun512@gmail.com> User-Agent: Mutt/2.3.2 (2026-04-26) On Tue, Jun 23, 2026 at 06:40:18PM +0900, Myeonghun Pak wrote: > vc7_probe() registers the APLL with clk_register_fixed_rate(), which is > not devm-managed and must be explicitly unregistered on probe failure. > > Most later errors already unwind through err_clk, but a failure from > vc7_get_bank_clk() in the output registration loop returned directly. > That skipped clk_unregister_fixed_rate() and leaked the APLL clock. > > Route that error through the existing err_clk label so the fixed-rate > clock is released consistently with the other probe failure paths. > > This issue was identified during our ongoing static-analysis research while > reviewing kernel code. > > Fixes: 48c5e98fedd9 ("clk: Renesas versaclock7 ccf device driver") > Co-developed-by: Ijae Kim > Signed-off-by: Ijae Kim > Signed-off-by: Myeonghun Pak Reviewed-by: Brian Masney