From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 875AF35AC33 for ; Tue, 23 Jun 2026 14:34:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782225254; cv=none; b=iB7cEo9IKXlV2n6Vu9RbNGntEyRB3rCoKY93hJvXBTlfl2xbaGQhn57rzlj0YU3kN4I95k1lqZAtS4oM0FOkoLaaXQwp2dK4VFZrB6yFtAJs0m2PRHf9X8lYj/m/Z7h2ntY5a0Z+VMjROQer0ntxry2qeR1s/gGMUPyejFTFv3U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782225254; c=relaxed/simple; bh=vZ9Ueq2wXFM4RPdfadUQVI4GnefEfSs6G+k0W6B2X3c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=h/v9qlGolUhIxWHr/zKjhiSRaUJ45s2SjtYZBYJvhDvhoUnR0IsbQ7I8KF7MW21lIdMPGWY8Ex/skS2aTCj6v7qVv/KyJW5hPyjNWbAuq0xW7adlJPRICAs8eGMJU9utsSniu7H9km+aKleVhNkUbMk1YKbH6Vgcz5dxOVpYWtA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=OQMgZsbV; arc=none smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="OQMgZsbV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1782225252; x=1813761252; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=vZ9Ueq2wXFM4RPdfadUQVI4GnefEfSs6G+k0W6B2X3c=; b=OQMgZsbVK7dOZWqgeF1lakVWAPpOfMusPhn1cTCVx+tm1xeils4PnKRi dAjMH/0XCukmoO6COzC239LmDFT4StQJKISRA0jlW7uYm0uD0JP0CAXKL d5jff2cpOk4bebEtzOVDK/4291+t7+geUDCfQ97LAU7kHFnx8km7STqbN L2Kv5u+OgZ+fPR+Cteq+9IjfJmc+yvTPg+CBXl2JccQX66T40+DjOViOm qtTrCrES51+C1tKnvkGV+AOLcrFE6rWZiuGzK8jUeGUPe6q+Jr4RmwSOB A3zvCOIiHwJLtKD7bp8xWrvMinsNi8TPh5eth2xqgpXVS6F5ys8Yqip9k w==; X-CSE-ConnectionGUID: PENpz84LTvCnqAe2qPwR0A== X-CSE-MsgGUID: thQtZGbTTwGoQwDLjhgYGw== X-IronPort-AV: E=McAfee;i="6800,10657,11826"; a="86656735" X-IronPort-AV: E=Sophos;i="6.24,220,1774335600"; d="scan'208";a="86656735" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2026 07:34:12 -0700 X-CSE-ConnectionGUID: uC6Z1sxGSDWvvF2T7tK4Zw== X-CSE-MsgGUID: sfSDphYiR06aKAwOflL6jg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,220,1774335600"; d="scan'208";a="248384070" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa006.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2026 07:34:09 -0700 Date: Tue, 23 Jun 2026 16:34:06 +0200 From: Raag Jadav To: Heikki Krogerus Cc: Rodrigo Vivi , Matthew Brost , Thomas =?iso-8859-1?Q?Hellstr=F6m?= , "Michael J . Ruhl" , Andy Shevchenko , Mika Westerberg , Riana Tauro , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/2] drm/xe/i2c: Handler for SMBus Alerts Message-ID: References: <20260622114759.3464047-1-heikki.krogerus@linux.intel.com> <20260622114759.3464047-2-heikki.krogerus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260622114759.3464047-2-heikki.krogerus@linux.intel.com> On Mon, Jun 22, 2026 at 01:47:58PM +0200, Heikki Krogerus wrote: > Some devices that are attached to the I2C controller use the > SMBus Alert signal for example to inform the host about > thermal events, so registering the default SMBus Alert > device device for them. The alert device makes sure that Nit: Duplicate 'device' ;) > the alert is processed and passed to the correct I2C client > driver. ... > @@ -182,7 +183,10 @@ void xe_i2c_irq_handler(struct xe_device *xe, u32 master_ctl) > return; > > /* Forward interrupt to I2C adapter */ > - generic_handle_irq_safe(xe->i2c->adapter_irq); > + if (xe->i2c->smbus_alert) > + xe_i2c_handle_smbus_alert(xe->i2c); > + else > + generic_handle_irq_safe(xe->i2c->adapter_irq); This looks like the else case will never hit since no other platform supports irq. Is it on the cards at some point or can we make it obsolete? Raag