From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B1F937CD3A for ; Tue, 23 Jun 2026 14:35:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782225323; cv=none; b=CgL7akJnibwzaUG/f4BjvpJG/mR2ZA1O+Zu2wMmLx/WU5USlsdiNgcVzAj3Qr9P2/lDMkmyr3dbtgJwfV0fKmz63wH0Klc6pxT5GHOyP6tFV51buB+gzBiPMCRvPXvXVY5kbzsiRDNUFiTNDjuTssUy8qr6xs/o7dITyTLhb+lU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782225323; c=relaxed/simple; bh=SRM7P0DVh8Y/9wPe/rOOybQ1B/N/vHxP3rylpmbDRRI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Tb+eMlQ7v1+7rJNrHC+gw1EsTq1oMeMRKQWu018kh5wVje5naXo3yrhyiZJs2DcPApFBEow0auGmL/U3SowzETqcMd2jGVxmm1vgzuU0kP5CivUn2J9xhUuORk8LHIBG/fkWrLdp9wVgkGsEMbOl1mwr6cK1TaDzd1yh7z0xyY0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LzJ/QGD0; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=O0/gL+jL; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LzJ/QGD0"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="O0/gL+jL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782225321; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hSWVR0//HeUMGIesSUzOzzGnHMJ2w79THlL/muBHE0Q=; b=LzJ/QGD0i8R3xtuesPFuQk+eHVzRO0se2rFMw1+oJcjVz3m6MmPTo3CQ4lEF/Swruu4KQf /cTymYN+vjqzn/nM92E+kFm4V/v3BZCWfIX/LhchC0nbGzG8WGGZN1XH6HfKrz1U0KPFDH +NKqrkq1w9ZA3fnDgVgI9tnh6/CIgVA= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-497-VzFVdeC6Pxi9EvZOXxcKfg-1; Tue, 23 Jun 2026 10:35:17 -0400 X-MC-Unique: VzFVdeC6Pxi9EvZOXxcKfg-1 X-Mimecast-MFC-AGG-ID: VzFVdeC6Pxi9EvZOXxcKfg_1782225316 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-8dba00e17b5so79493606d6.3 for ; Tue, 23 Jun 2026 07:35:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1782225316; x=1782830116; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=hSWVR0//HeUMGIesSUzOzzGnHMJ2w79THlL/muBHE0Q=; b=O0/gL+jLEuUhVcPLLZ7vc9w7FBjJzz7CmHe2W49tUD7Q6NeFPQDeRH9rBZFJSucoI/ bdcmhalT57REBqkZGQQHSyuYO+g4jK/czEzAiOsDdmdmYC4HeXEtJgTyZNJ7Ww0UHnPO K+iRk4c8CzTl3rkNioZn95oHzBDqbfuEEgdH3gWCKeXysX0iHq+rKXqsS9DVhElUOUo3 CYUUuX9Jk1LkrZgAcUBlkZyrGjqLvJCXb4EXomHHQ5eBFhtwO/GeXHIWBC8i5yyRH+1/ KA+5EwHAvsW+h1o/HA/+7STNnVIqFiL3vMyh3SgnjFnr19r8yEXUb7wGj2iKdo+0w5y4 wBdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782225316; x=1782830116; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hSWVR0//HeUMGIesSUzOzzGnHMJ2w79THlL/muBHE0Q=; b=dpNllLzxvSeg5f3v36v0jAwCBMTRX+Ou3IaDVhWCdY6Mi2lS9aHZA5khRwvr9sosIt JfPuxt+bjx+KJkis7QPPG9V2az1r9tyk6J0mUgtHE9zEFXyJL8p4cEJPxxJSMCqAdaFu xz5WmDsIw0jJfgJVt4OoF8z2hw5hGYnzff7b6f+jFy25n3dwWJ5QPr/x4ENzuCNBjPbR umWAay/bYOdbbJkGCinx7aVo8g1i1OVRgHbJmt1dH1wKwWvzrV54aL9NtgvpC03zqj+z CTvI1P59zghMYa96iekTuIfVZ74snt0naDda4uHwJx6iaEHKXyruPw2ArJ9PgKkPMncT j55A== X-Forwarded-Encrypted: i=1; AFNElJ8TRXGsFO48CdpwWykH0UF3hGYvHTHfUmHOwMcafoYVHEB7nnYDkE0QmeT4iKsHT9c/3YL5rUmWeGZzFYE=@vger.kernel.org X-Gm-Message-State: AOJu0YymghMurogzScSQ7KCCEcsY9B591L2ss9QpqEdZFNnzQi/5BBs8 BtUvY8zCk3orRQQftdr9aWs9L4MBn0st9iFtjfuRmQe+Px01vN4w+9Lp7471sYDQBiVrx1q6UB/ JWkePGCqVHDsr8oLPYkdT85q8Tpvz6ywsXPrRka30m5v9G1C1y3ST4y5aUCJ9WrBIHA== X-Gm-Gg: AfdE7cnLUr8vRXAubrbVeN6OQn+IIs3SOPBaUqQ2gNXyblAFRlMxps1zD/qqgyKTYpN c4ZVf1PXjE+8OusJR2ODvRIjnL2mkSG0jJ5pmUeYImmldTJ2tXo8uFlCBAfdwvVRSEDKRWfaiIL BVbDoVQyHEwd/zHu8FLkZqK3Gz5Yiw4nzJgpTcecQaKQGs9e8vlh55bg9xA1ivHz62UpMndoiI1 kzNFA//kdrCAuQYKFrnULluJMMWGoway6qZrUj/7EYeHWLbw1QUZnozUCTNrCBxh3xlQ/zQL5dP c/mjAqafLgTCoqP2jbjQUbmCIsMdxs6tfFO1MMbitdWe7otYTrOd+9oulqVtsYQleD9jZjMxmx8 ehO/qJde89yWhlHuGR8y1J0ZvcA11KfySfN55Jrc5/caFOw== X-Received: by 2002:a05:622a:1b8c:b0:517:5e32:af20 with SMTP id d75a77b69052e-519e490624dmr281782321cf.6.1782225316303; Tue, 23 Jun 2026 07:35:16 -0700 (PDT) X-Received: by 2002:a05:622a:1b8c:b0:517:5e32:af20 with SMTP id d75a77b69052e-519e490624dmr281781791cf.6.1782225315666; Tue, 23 Jun 2026 07:35:15 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51a51afc29csm24695621cf.27.2026.06.23.07.35.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2026 07:35:14 -0700 (PDT) Date: Tue, 23 Jun 2026 10:35:12 -0400 From: Brian Masney To: Myeonghun Pak Cc: Yassine Oudjana , Michael Turquette , Stephen Boyd , Matthias Brugger , AngeloGioacchino Del Regno , linux-clk@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ijae Kim Subject: Re: [PATCH] clk: mediatek: mt6735: Unregister PLLs on probe failure Message-ID: References: <20260623094125.95791-1-mhun512@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260623094125.95791-1-mhun512@gmail.com> User-Agent: Mutt/2.3.2 (2026-04-26) Hi Myeonghun, On Tue, Jun 23, 2026 at 06:41:11PM +0900, Myeonghun Pak wrote: > mtk_clk_register_plls() registers the apmixedsys PLL clocks manually, while > clk_mt6735_apmixed_remove() unregisters them on driver removal. > > If devm_of_clk_add_hw_provider() fails after the PLL registration succeeds, > probe returns the error directly and the remove callback is not run. This > leaves the registered PLL clocks behind on the probe failure path. > > Add an unregister_plls error path so provider registration failures unwind the > PLLs before returning the error. Please run your patches through checkpatch.pl before sending. > > Fixes: 43c04ed79189 ("clk: mediatek: Add drivers for MediaTek MT6735 main clock and reset drivers") > Co-developed-by: Ijae Kim > Signed-off-by: Ijae Kim > Signed-off-by: Myeonghun Pak > > --- > drivers/clk/mediatek/clk-mt6735-apmixedsys.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/mediatek/clk-mt6735-apmixedsys.c b/drivers/clk/mediatek/clk-mt6735-apmixedsys.c > index 9e30c089a2..04cf9665ec 100644 > --- a/drivers/clk/mediatek/clk-mt6735-apmixedsys.c > +++ b/drivers/clk/mediatek/clk-mt6735-apmixedsys.c > @@ -102,10 +102,17 @@ static int clk_mt6735_apmixed_probe(struct platform_device *pdev) > > ret = devm_of_clk_add_hw_provider(&pdev->dev, of_clk_hw_onecell_get, > clk_data); > - if (ret) > + if (ret) { > dev_err(&pdev->dev, > "Failed to register clock provider: %d\n", ret); > + goto unregister_plls; > + } > + > + return 0; > > +unregister_plls: > + mtk_clk_unregister_plls(apmixedsys_plls, ARRAY_SIZE(apmixedsys_plls), > + clk_data); > return ret; > } This fix is correct. Since only one path will encounter this, personally I would just put the call to mtk_clk_unregister_plls() inside the if statement above to simplify this further. Brian