From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B6BA38758F for ; Wed, 24 Jun 2026 06:22:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782282135; cv=none; b=McsCJL5+uHHONCQY/SDxFHbSbHWQPZyh5rZ/bNJymVhIaVPopz0Oy0lGSwjtdMCKH0v0LkUckr8WstbafqHYDUlvTYZRWS1WwNi2QusqwbwYWOpe/j6LhQY1JFI3dCN6sqfp5m1t0JVFaXkjySIfPvp0V6AMVMC68gxbZad4D34= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782282135; c=relaxed/simple; bh=iA2jQFQi7aUuyW+NEi3pdM7vtD+gpjGvXMqWxMf/Hrc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pFDHcQTAlubuQ7Yy/x/hFPRC8DW5XcdAN0mrDifZGwvqoxGkKXMv8wpXnuTcByp/OQoqxu8S6T9779GikJIfl2HACpkcpOLApqNlPBRtgKKeCHcbg3TGzuWwj96HDBGu58QNA1heK4p6wme0W1eyh/hTa6MwEmE7BH3sn9RAj64= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EgXy5h0a; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EgXy5h0a" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-c03a466c96aso109511766b.3 for ; Tue, 23 Jun 2026 23:22:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782282133; x=1782886933; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZRxB7+nWbl+xPPuabqlXkiLeUH/Z5B8J6JlB8gvKkmc=; b=EgXy5h0a8Rg+aX23a+vLgY2glWF33JPqfaeI5j0uIClMpexjTgwhV8oRRv0cOU+aDZ z8SyB1BRATosJ0ovwHvOMBfSw3XInC1IKpH0+J+aB55I9Lg8TTY/r7Vg/bU4HEVTrF0d ZcwOcWjdfcucCH7bCOnJyMVYoGeik1IGfubOvqL9PhT1uzMlKHWs0JO0oMnfLQdg8Eo8 2axk9yHKIIptxNEF7FVQrTDCxjIhfaRQSTzIyLnRmHQe5y/c5dkNig3DB7lpj7UjjcJK 7QV3kCrJG8W5RyehW4wLZhkDubiZqTr8FflkbeyEQMYZ1sp4QbVgKyAU20AfqDK5TPyv ULXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782282133; x=1782886933; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZRxB7+nWbl+xPPuabqlXkiLeUH/Z5B8J6JlB8gvKkmc=; b=sctEa7JDElNujQDapvRNqrg1j72hC7q07yk0JOjiAzJAv7WoVIg7kuufX8ejpp1x89 712J8cJ+4xSKCtzUUYJtoLw6qlC6UU8CWBTBolOM/9svCkfUSAwka/k8A1EyUvGMfUoz MC4CWRSwXiM2Iaw/zIByNBaI2B2HMXbsXu0PfhqORhdcZZkuO3xUA8hlVQ8H1FgmHoQ7 KMweThWLYoo76ulAAizUO/Vf1gZslDDe/EJfqY1e2NIoDhK8gNR5z93wNuOjLbeUUBmx 0R2Q94D7qb/0XkaVEAHmp9+GKH+CyRoQKLzJI68sUSQqHzPgpUkejW7Yy+sIsImi0lAV XoAg== X-Forwarded-Encrypted: i=1; AFNElJ9iVsKybr8xwkZrWFaNwBqSAyGcTsSa7nmB0dDkVIXIbhVTPJ7Yk/DMeCVVgNbXUh90CufhkHA7NOU0nkw=@vger.kernel.org X-Gm-Message-State: AOJu0Yz779ppId9qiv38pwW/FoDAR64apKOV4tcGrYNcW6Pkqur5+nJd BcYi65/iHkTPNepIzPUzVBbPboe72EWTBU54Iow/WoibAYUd5uD3TkLw X-Gm-Gg: AfdE7cnCEe91wSMAsihzmOkcuppH8aEoZHyiG3cQ4LPmF4O6XcpAdEoyRzJaiaz8LoJ nj6Aj/DbeN138NIQOdkpar5HCt+okdxNwygCJ2kp5EC1UaMT6Um1/iBJdw1pUMHeNECBl2s8D5u zTAEZBLaumrxhcupASpwh7e0JqExyI0ScZ6cBtcbRFyMLCZJnuIIS7I0qpLQZCrItQHDQ6hMavI 9gQQyyROyTD9SW92Onvnv03B/M9IepqcOOaIJMpM65xL1rZwWg1yTaZ5Rh7R5SCR3jk9hfAOb12 gjQXgdyawceT5Qyh9YnNrTzIgW9NCJJYdVXeJ6wCJQnWVuGoVrZdOrMnnj5Rt9mz1aWku5Qkgjw Z8N6ExTOH2dYBjUXV8+jWykHF8XV266uJKULfzGJgAT4Wt5J0GhTAQkwPkXZNhDDFMsF4QBT3aw JVQCv2lSf2 X-Received: by 2002:a17:907:1c93:b0:bfe:ed25:c564 with SMTP id a640c23a62f3a-c0c671927e1mr497535066b.53.1782282132956; Tue, 23 Jun 2026 23:22:12 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c0c60ac97aesm607385966b.30.2026.06.23.23.22.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2026 23:22:12 -0700 (PDT) Date: Wed, 24 Jun 2026 09:22:08 +0300 From: Dan Carpenter To: Batu Ada Tutkun Cc: parthiban.veerasooran@microchip.com, christian.gromm@microchip.com, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: most: dim2: use dev_err_probe() for clock errors in rcar enable functions Message-ID: References: <20260623124243.1245-1-batuadatutkun@gmail.com> <6a3ae40a.3dabba3e.2527ef.7783@mx.google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6a3ae40a.3dabba3e.2527ef.7783@mx.google.com> On Tue, Jun 23, 2026 at 03:35:08PM +0300, Batu Ada Tutkun wrote: > rcar_gen2_enable() and rcar_gen3_enable() use the old pattern of > dev_err() followed by return PTR_ERR() when devm_clk_get() fails. > fsl_mx6_enable() in the same file was already converted to use > dev_err_probe() by a previous cleanup series. > > Convert the remaining two functions for consistency. devm_clk_get() > calls clk_get() which can return -EPROBE_DEFER if the clock provider > has not yet registered. Using dev_err_probe() suppresses the log at > error level in that case, avoiding misleading "cannot get clock" output > during a normal deferred probe. > > clk_prepare_enable() cannot return -EPROBE_DEFER since the clock handle > is already acquired at that point, so those error paths are left as > dev_err(). > > Signed-off-by: Batu Ada Tutkun > > --- > Compile tested only. No R-Car hardware available. This is a correctness > fix for the deferred probe path, not a response to a reported > user visible issue. > > Changes in v2: > - Mention clk_get() explicitly in commit message > - Add testing note under --- cut off line > Perfect. Thanks. Reviewed-by: Dan Carpenter regards, dan carpenter