From: Florian Westphal <fw@strlen.de>
To: Carlos Grillet <carlos@carlosgrillet.me>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Phil Sutter <phil@nwl.cc>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH nf-next 1/4] netfilter: nf_conntrack_sane: replace u_int16_t with u16
Date: Wed, 24 Jun 2026 23:00:26 +0200 [thread overview]
Message-ID: <ajxFah1khNl5brEl@strlen.de> (raw)
In-Reply-To: <20260624184036.71051-2-carlos@carlosgrillet.me>
Carlos Grillet <carlos@carlosgrillet.me> wrote:
> Use preferred kernel integer type u16 instead of the POSIX u_int16_t
> variant.
>
> No functional change.
>
> Signed-off-by: Carlos Grillet <carlos@carlosgrillet.me>
> ---
> net/netfilter/nf_conntrack_sane.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/netfilter/nf_conntrack_sane.c b/net/netfilter/nf_conntrack_sane.c
> index 39085acf7a71..130b3e68090e 100644
> --- a/net/netfilter/nf_conntrack_sane.c
> +++ b/net/netfilter/nf_conntrack_sane.c
> @@ -35,7 +35,7 @@ MODULE_DESCRIPTION("SANE connection tracking helper");
> MODULE_ALIAS_NFCT_HELPER(HELPER_NAME);
>
> #define MAX_PORTS 8
> -static u_int16_t ports[MAX_PORTS];
> +static u16 ports[MAX_PORTS];
These port variables are useless and will be removed soon.
next prev parent reply other threads:[~2026-06-24 21:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-24 18:40 [PATCH nf-next 0/4] netfilter: replace u_int*_t with kernel int types (batch 2) Carlos Grillet
2026-06-24 18:40 ` [PATCH nf-next 1/4] netfilter: nf_conntrack_sane: replace u_int16_t with u16 Carlos Grillet
2026-06-24 21:00 ` Florian Westphal [this message]
2026-06-24 18:40 ` [PATCH nf-next 2/4] netfilter: nf_conntrack_h323_main: replace u_int8_t with u8 Carlos Grillet
2026-06-24 18:40 ` [PATCH nf-next 3/4] netfilter: nf_conntrack_amanda: replace u_int16_t with u16 Carlos Grillet
2026-06-24 18:40 ` [PATCH nf-next 4/4] netfilter: ip_vs_nfct: replace u_int8_t with u8 Carlos Grillet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajxFah1khNl5brEl@strlen.de \
--to=fw@strlen.de \
--cc=carlos@carlosgrillet.me \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox