From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61EB323AB9D for ; Thu, 9 Jul 2026 15:01:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783609275; cv=none; b=YGm2jivZi7Bilkl9PhqT/HkBDWMLm53448zYf9ePtVCHv2bPJb1feENvsrzWNbPh8xFVY+zZv8SSkFQlWJgbRYpOoRyu+kAUJKTdC60lokKvkT2zTszoZtAaYMAcINpcjCcGZJLd9PpyMLkI9sL0SwnoB9ck6fn7VUWXoH9DKxQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783609275; c=relaxed/simple; bh=Lr+5ewuwnuRI0XQJvhazEBz3R+huyj5xuWkRpvr4yT8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jadTtSyNEU+pACO376bE18RZbMc8zqdlH6MHQT8BYIL2Foon60P7bXF0LrCxWxSDq+zlp0rkZmOsRfw5qFYPFpbTxT0plJLLqbp0Ar0ohw2k0+pnQZFFdr73bRsnk+bF8YRS3ubUsrmcZoOxpxhl1GjnK/SpaEeStK3e9jVLQ84= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b=UgC0LK9s; arc=none smtp.client-ip=209.85.219.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b="UgC0LK9s" Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-8ee6912d86dso12464616d6.1 for ; Thu, 09 Jul 2026 08:01:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg.org; s=google; t=1783609272; x=1784214072; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=lCoCDKvKWAelS8ArabvJ3verPItQS1mXV1mG6RVch54=; b=UgC0LK9sg3qH03Cw+jLytqCbxtNtUM3AsGZw7yx56l6seCUZ708yx3ZBm5j1NGOBfb 8EblrIUBcajU+jzC8t+fSLglTkfY2jy35M15CsYrfiO6wVJKnvtaskTNBhE6FvZnB1uB OmdD01uWbr0kzLHnjukh29iEk8wBJxP6X+zwYCMahoAAD3KyCjaq0DR8yR8acrck+WTl WHLVA86/6/3QvdXM6w219+vFP58/SHUps+iRO2bXYm4PHjCUdVpr80lot5Kjo3geZWde 6QncQEXj7a9z7QwzQA0rw+4UIPSFC686he6sW768yNc9Uco3C5N8zqzXOF9fbPyeXFoD c3Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783609272; x=1784214072; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=lCoCDKvKWAelS8ArabvJ3verPItQS1mXV1mG6RVch54=; b=H+Yxj6tKmmVKo6IducJJB1bYwgO03wrDg5zBWeGGKsaqk9LpvGzbRqzT+tgPH9UHbV DBkG3/+av0V/bf1782P9Njtc7papyw7eIVN43Z3TCSjXj20kFKWehce7n+UG2fyzTI9b 7dfA8NXe71jhZo+jFwMp+E02oWQNVln6UEU5i7V3eJn1x9FFL94jTCPFJsqgiFvlLjQ+ TAMFiyOdkQKastH6NrBUvGK7t6HMtvT1IngE83uU+Vtt7fSUpqKbQtXEUPKPpYp2/+iK 8MRjuw2PIcnRh5SdZaDN68a7pBlv5E3pPVw8AB+J8oZ5Eu83AGo79f3kdS5x0+9WBD9S KJyA== X-Forwarded-Encrypted: i=1; AHgh+RrGz0R4WR0VKJbbziyvJTJnauuSUOZwtNnuiLtGxSdFDeYphPfDKp8jU3LsAiywplNOdfKYAa4lev62EbQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2lKxztit5dYgpscjaYIfp4hsnlxImCVUDmcdj5aNGvKY+zUl/ 6qPC98EPCaKe3JmQJqJEcLn8O50SxhWt1IsTqdU3gZBoKxvGCBWyMa5mVdHMg58aF3c= X-Gm-Gg: AfdE7cnUwmRaxHivJjALZ6uvsqCIAdaViEzY0hDkUZuY6LP5Z3jwvHewziqaWbTwKZ9 9vaC8RZ/ziMhM6+zXnx32LkOa0UV/efZexAs85W6iR/dsX/fa/Jme7sN7GG/jSBxGRllIstCo5R uMd1pdUJ/3pUu4wqQ1L/Ig7jvy9zZTiEXbHiGzSWL88pQlw7X47Pwl1ktOTo+VT8/HXgGUxZgXY vtIxzxQ1HpSqKh0iZdNywNupqIkjW0tFJjCJtyYChBhlRt1WTO0SjpOZJ7L7p3/N1J2X6x9YM7F tLuNIO7hab2pbaAcGPThgDwym/nGw41zKmHu6oYWdYhseQ08SRf0kYP/Xs+jhgrePvRh6t5AqSM B0wj7wmsfaazhL2EbMlpYrMWvcFjiY0jCcZFbENa7UM0sNEXWrK3+O2MiJcLXueTUcbid6ur0DE mMVM4wTVgDtbE= X-Received: by 2002:a05:6214:1305:b0:8e9:f62b:8fa2 with SMTP id 6a1803df08f44-8fec342e855mr93084796d6.55.1783609265440; Thu, 09 Jul 2026 08:01:05 -0700 (PDT) Received: from localhost ([2603:7001:f100:500:365a:60ff:fe62:ff29]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ffd81f4bbdsm18994596d6.36.2026.07.09.08.01.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 08:01:04 -0700 (PDT) Date: Thu, 9 Jul 2026 11:01:03 -0400 From: Johannes Weiner To: Xueyuan Chen Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Barry Song , Nanzhe Zhao , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , Youngjun Park , David Hildenbrand , Lorenzo Stoakes , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Qi Zheng , Axel Rasmussen , Yuanchu Xie , Wei Xu Subject: Re: [RFC PATCH v2 2/3] mm: distinguish large folio swap allocation failures Message-ID: References: <20260709145124.764807-1-xueyuan.chen21@gmail.com> <20260709145124.764807-3-xueyuan.chen21@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260709145124.764807-3-xueyuan.chen21@gmail.com> On Thu, Jul 09, 2026 at 10:51:23PM +0800, Xueyuan Chen wrote: > @@ -5550,10 +5558,7 @@ long mem_cgroup_get_nr_swap_pages(struct mem_cgroup *memcg) > > if (mem_cgroup_disabled() || do_memsw_account()) > return nr_swap_pages; > - for (; !mem_cgroup_is_root(memcg); memcg = parent_mem_cgroup(memcg)) > - nr_swap_pages = min_t(long, nr_swap_pages, > - READ_ONCE(memcg->swap.max) - > - page_counter_read(&memcg->swap)); > + nr_swap_pages = min(nr_swap_pages, page_counter_margin(&memcg->swap)); This hunk is unrelated to this patch. Don't mix refactor work with new functionality. Make the previous patch a pure refactor job (where you add page_counter_margin() and use it here ^), like I had proposed.