From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35D0137B409; Thu, 9 Jul 2026 15:36:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783611384; cv=none; b=RgT6Ty4p0OlzOuQN8WReSt6oHWHZvXzzoHvcruf+VgNUruco+nL1fOP2NmEPJ+6ddCLzM+4mZ6ee+03ru9/0/5kcI9rt3XKKA/tLTB8YMjjaINizTJ9kS5QT+jbpK2Bzlk69nMaUI++xqQGip8Ae0yG8vhHfLWol94eCPjApLjg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783611384; c=relaxed/simple; bh=Ejl/nG81qlGdwy91cBsag1LCiQh7fO+qjQ7Jolgchy0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EPVmTp+EF46vX0RMXHBp7QKKrJTIqzvbFTGUDLzQlvaxaPqJnMHwcwH7/vm4+Akqs6yDuIOpYJua7Md2c36ZHplgRMADkCtiguCIP6CzZD5rxnEMed8GZDw7heRVXCOfzYxsp0oXzpm0rQKR3ZcgjW1+s1luavw4+Btju0st3eE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=c58V4tRt; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="c58V4tRt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29BA21F00A3A; Thu, 9 Jul 2026 15:36:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783611382; bh=4mg2V0R7ROggXXchkyKDCKlOYU1ruVph4CL/uITEWhg=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=c58V4tRtaxqpKPeZvomkSUxRufHz00GTZSdV7gdbR7tLG41wuZYPKtLskkkHtg/Wb 8jNv8LPawi649eM8ho1JXfSx1BMDPxHrymwneL/GvGyWdhek3KsH7zFC5e1JjQWnou iOv4zpApjw7SbfT7AEw2JV7BD/tfMbe0uXK3kEa812I62T6vpYt5jUz7FpFtTe10CD 4ECqE0tZFBdePa8c3CMUA9bDBbgK2axaR9q94iDgV5sxxlRY58ZdX0Hk+O48jzlZeo qTiDDqfpGfqIZ8KxE9OxS7usK9HxPv2ff2iR6va1vt9/CrJjbTxqFimlbYjuS1kNkk JQbXGDOnK1ftQ== Date: Thu, 9 Jul 2026 16:36:08 +0100 From: Lorenzo Stoakes To: "David Hildenbrand (Arm)" Cc: "Vlastimil Babka (SUSE)" , "Mike Rapoport (Microsoft)" , Andrew Morton , Alexander Graf , Alexander Potapenko , Brendan Jackman , Christoph Lameter , Dennis Zhou , Dmitry Vyukov , Johannes Weiner , "Liam R. Howlett" , Marco Elver , Michal Hocko , Muchun Song , Oscar Salvador , Pasha Tatashin , Pratyush Yadav , Suren Baghdasaryan , Tejun Heo , Uladzislau Rezki , Zi Yan , kasan-dev@googlegroups.com, kexec@lists.infradead.org, linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 0/3] mm: split a couple of headers from internal.h Message-ID: References: <20260709-internal-h-v2-0-695631425968@kernel.org> <0970fec0-5c18-41e1-b63d-029c7a8354ee@kernel.org> <67bbfc47-a8f1-4557-9a24-298bad4f3591@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <67bbfc47-a8f1-4557-9a24-298bad4f3591@kernel.org> On Thu, Jul 09, 2026 at 12:21:12PM +0200, David Hildenbrand (Arm) wrote: > On 7/9/26 12:09, Vlastimil Babka (SUSE) wrote: > > On 7/9/26 12:00, Mike Rapoport (Microsoft) wrote: > >> mm/internal.h becomes more and more bloated. > >> > >> Split declarations related to mm_init, memblock, vmalloc and sparse into > >> new headers. > >> > >> --- > >> v2 changes: > >> * fix fallouts of rebase fixups of checkpatch warnings > >> > >> v1: https://patch.msgid.link/20260709-internal-h-v1-0-956d5092782d@kernel.org > >> > >> --- > >> Mike Rapoport (Microsoft) (3): > >> mm: split out mm_init and memblock declarations from internal.h > >> mm: split out sparse declarations from internal.h > >> mm: split out vmalloc declarations from internal.h > >> > >> MAINTAINERS | 3 + > >> kernel/liveupdate/kexec_handover.c | 3 +- > >> mm/cma.c | 1 + > >> mm/execmem.c | 1 + > >> mm/hugetlb.c | 1 + > >> mm/internal.h | 183 ------------------------------------- > >> mm/kmsan/hooks.c | 1 + > >> mm/kmsan/shadow.c | 1 + > >> mm/memblock.c | 1 + > >> mm/memory_hotplug.c | 1 + > >> mm/mm_init.c | 3 + > >> mm/mm_init.h | 120 ++++++++++++++++++++++++ > >> mm/page_alloc.c | 1 + > >> mm/percpu-vm.c | 1 + > >> mm/sparse-vmemmap.c | 2 + > >> mm/sparse.c | 2 + > >> mm/sparse.h | 63 +++++++++++++ > >> mm/vmalloc.c | 1 + > >> mm/vmalloc.h | 46 ++++++++++ One thing to be wary of, and I mean I'm going to get a bunch of conflicts with my mega series, but anythign that uses vma's should use internal.h rather than vma.h directly (the mega series touches this). But nothing you changed does use VMAs afaict so should be good. > >> 19 files changed, 251 insertions(+), 184 deletions(-) > > > > Sounds good > > > > Acked-by: Vlastimil Babka (SUSE) > > Agreed > > Acked-by: David Hildenbrand (Arm) Oh hey me too! <3 Acked-by: Lorenzo Stoakes > > -- > Cheers, > > David Cheers, Lorenzo