From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 131F933B6DB for ; Thu, 9 Jul 2026 11:22:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783596139; cv=none; b=mJ4ki/dYkSno3K6qtRBW8khynFJFoGrxVnQNMfRqrl4BU+TcCYpJMPO0Os2Q8C4ZopsXoWCKdJxAgpxxk4MFb0GAMCSFJ97TByjqD9DjGTdNCivX3/FMgomuDvCehr5wwLP84xpnxnPE2Fp7dM5jMH9OfmrQngBY9f6g7N6DI9I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783596139; c=relaxed/simple; bh=F51qepsmIqkYSW+u/nRZULsZ0h4Hxz/pFc8lKtp3m/8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oKX735puWZt/gocUsNIL8GOHj+wKzJQ9jMrUIaoJS+LOJqAOsmJINpkoy1rkdPVBJFroiYFuVy6u2ssZxjzlyG3Eu7bANkm/ysYc1adrGMkacz698Af0TPe5wTh/YdJRWeqCChlDBF2yA1+mP3gDf0Ze4jdVZuhnKgw3BhfuNiE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jKKXU1uz; arc=none smtp.client-ip=209.85.210.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jKKXU1uz" Received: by mail-ot1-f48.google.com with SMTP id 46e09a7af769-7eb4d8a21a8so1053259a34.2 for ; Thu, 09 Jul 2026 04:22:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783596137; x=1784200937; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=L97oa22rqRYQnN2lA0gHFbJaDXfbrCyHzvc6NqNE0LU=; b=jKKXU1uzxwe9+8qdMOam3bgNVBBxjhlHvLFn1KKDdK+JeyD0dmN5f3kurePhfImO+d 2n5NNjSoAuR5z2UoM6tx/5oistTcieZ8zJR7Q6k2mXhIOm82THY7llNhmIRel0odPVXW l4FCqpOjrroS/bqQG0k7FLXpur5bQpJ4FK114C2BgWJyhsXPi5masmSDFTuuawZp0aSJ pYkD5Fof/Vr/xMdl9fKyRSH7lJHqPwX5lPSrnfg0WiRfqP/pGLMPaUNWiuU6E79FO7Jp 9a38Uy/eEH8ZRPZoUxpDAFk4sXsyL4/UBZ88mL08rv35xGVy6anHbNc5DhXaGozpQ2lJ wUsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783596137; x=1784200937; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=L97oa22rqRYQnN2lA0gHFbJaDXfbrCyHzvc6NqNE0LU=; b=naYPbmdesaTQYe/CUNv6lcTbLIpEeHaQJZQNjQVbJxPSV4gO3nY6MqpAtf0V25AcWj kl7mbM0GqjorqByIhimVi7LLZCLkRqzZZYaL1l+mqz2MamURfs4dSzy5R/hfru+sV7Fa qHmDaZyw75YCaf9l5BEywrvGV6ttDyt0E0sP28i8F5wjiCSZek2Qnv57Oz/afYJQ3++g /zICh0Je6z82xkTURU/c0+Q7oqzBlkuulVQqO9o18E/dQXA4blB+1JtMLsu0v4sxBKuV Hlw5Q/TwDilZwJj4964BMM6UNKepQQ6zkZRp1Y/apiit7rWhfylhviZzZMSO2NpmIzXU Z8fQ== X-Forwarded-Encrypted: i=1; AFNElJ+vFZty2OPQS1GulwQdnVsmTSMwWhZUgjgY7xKQCMHxLLF+KpZnuayyTXzdmABSeTWijNQaBEHbInttiTo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9g1hwwpgKc3mz77GPiuSHnEd9v24fQJhdrkaYnGD+YWzgdwVY CA6VbyvCW5TBGyPrv+g3r5UmoNG7zm0fhxFJAImAYxI6EXINUlsEvUMT X-Gm-Gg: AfdE7cl+zvoMBSwd1ppw94ySuNGhmpnE6rZW82T0uY3tQllYGx2T/RUbnxW/Dr7CAho 6UveL/nQ83FWQfkvNbTqfOsgLU4MLTB4r+o22H97QAPUWEQyhpoDDqk4CmCw9QjweYpZ/G+dC6n +rEpK+QGYTJ3FrfClT+zavDRSzSOuYAlZIENujvW8p9HulnvF3aOqkMP8OzJryg+Gt4m0csvONI f87mHXqYcEPJhjstBL6MTb5Ftoj4Ky66txceD/ToQdphuhXjhdrzvUig36KY+oZtEICZuyPdWMC naHq9bM75i70+WiI7eXN6xGMTUodCZDOgF55N38OSNuQ5GcOhwjaDEEOTwoLA1QBIJBXHoflWJ4 98xOkpwWLAfWes6SMFmsjfSxKp2oXUpmOZcsQrHZUNo7Vl9/GUenpsu92a5lX8i6fbWLWoeP5tY ajoTqv X-Received: by 2002:a05:6830:4c15:b0:7e9:b34c:ce3d with SMTP id 46e09a7af769-7ebcff78d91mr4953408a34.18.1783596137021; Thu, 09 Jul 2026 04:22:17 -0700 (PDT) Received: from localhost ([74.80.182.70]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7ebcae177c5sm3984476a34.5.2026.07.09.04.22.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 04:22:16 -0700 (PDT) Date: Thu, 9 Jul 2026 14:22:09 +0300 From: Dan Carpenter To: Aditya Tipre Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: remove else after return in enqueue_reorder_recvframe Message-ID: References: <20260709040419.216324-1-tipreaditya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260709040419.216324-1-tipreaditya@gmail.com> On Thu, Jul 09, 2026 at 12:03:48AM -0400, Aditya Tipre wrote: > The duplicate-frame path returns immediately, so the following else is > unnecessary. What? Also no. It's necessary. Checkpatch is just a simple perl script. Use this as an opportunity to learn to be critical of your tools. ;) regards, dan carpenter