Re: [PATCH v1 01/11] rcu: Rename struct rcu_gp_oldstate to rcu_gp_seq

[Frederic Weisbecker <frederic@kernel.org>]

Le Wed, Jun 24, 2026 at 06:23:43AM -0700, Puranjay Mohan a écrit :
> The polled grace-period state structure rcu_gp_oldstate holds a snapshot
> of the normal (and, on SMP, expedited) grace-period sequence numbers.
> Upcoming changes store this structure in the callback segment list, where
> the "oldstate" name reads poorly: there it represents the grace period a
> segment is waiting on and is also compared against the current
> grace-period state.
> 
> Rename struct rcu_gp_oldstate to the more neutral struct rcu_gp_seq, and
> shorten its members rgos_norm and rgos_exp to norm and exp.  Local
> variables and parameters of this type are renamed from rgosp/rgos to
> gsp/gs accordingly.
> 
> While at it, provide a single definition of the structure in rcupdate.h
> rather than separate Tiny-RCU and Tree-RCU definitions, and give it the
> ->exp field unconditionally.  Tiny RCU does not track expedited grace
> periods and leaves ->exp unused, but a single definition that always has
> ->exp lets the shared callback code in rcu_segcblist.c reference it
> without CONFIG_SMP guards, including on !SMP builds.
> 
> No functional change.
> 
> Signed-off-by: Puranjay Mohan <puranjay@kernel.org>

Reviewed-by: Frederic Weisbecker <frederic@kernel.org>

-- 
Frederic Weisbecker
SUSE Labs