From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 558EC331221 for ; Thu, 9 Jul 2026 14:28:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783607293; cv=none; b=oJPTydPz7SRIdCvlxA9plaRyzkMzgxBpi3rIR4yuXSu5eWPKj4WfDfrmhT6tUlaiq3RjdLf97idJBVm+Z1njP2nZ5L7pRKrbT4FAXb+tiQVax0rQni9IsPUhxdz+eT5iCw5Dxw0JklD0N9MXBGZ2cpBvfSoeUAJqbN3YVM3dOlw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783607293; c=relaxed/simple; bh=PgUeHneBxAfToAshr4h3JMYv/lZaBMB1tn2P/BKrqhk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LC5cQTLa4TDjru3LsQhfTa7n2cyzUtoR3upWyOiok9OdlLynHVL0cSXl0DHy/59gVKVx4/5Ss4FoA9/6bgevdnKSQdllyLbFlwMNUiP4JYyC3OQy9O8wjFmAp753s3jApWy/2I2H6hn8ZFEtSThU6GaxJf2HJku0N+fSP46rCmU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=FanlmF/8; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=krMgrhtg; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FanlmF/8"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="krMgrhtg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783607291; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=92JJ36rrwvvb7yLlV9W9rV0xnJPT/KBmVXI1YNHLk7c=; b=FanlmF/8SWP7lq2MFDR6YZg0Ek7Jv6zYYsL33/u5GH1seJ13F1Ruxj8gTXAxT/lr9blVhf 8kPA08BSPYYsUIZ2yu8iSc/hy9TvaXIH0aUi46q+/PrCJ4amtLStGHKM0NaaRK5CzDNeVf 61Saj9THMH9T++eUgmKS5uVNSGrVZmc= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-84-P1knTruaMuG7so4BuqSgJA-1; Thu, 09 Jul 2026 10:28:08 -0400 X-MC-Unique: P1knTruaMuG7so4BuqSgJA-1 X-Mimecast-MFC-AGG-ID: P1knTruaMuG7so4BuqSgJA_1783607288 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c1c7f135bso36193021cf.0 for ; Thu, 09 Jul 2026 07:28:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783607288; x=1784212088; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=92JJ36rrwvvb7yLlV9W9rV0xnJPT/KBmVXI1YNHLk7c=; b=krMgrhtgg99JnjZEuGUQQWlW4YlJi+2KY3mz+PM8lyccdTbQLQu/eoPTZuR3vgbkOL N3jVMxNvIsfbK4uId2Om81UQFY8aUIE+BLjIq9kNkdHOtI7QZ6cHn4/r8jdQ/fppLFU6 2Nw0bX6nZs152M3lnmlJC1UP7gKjpSA8oJtZSIYc7FskcyAWcuSyurOBMvivnzrTwT6P 7GFyyJgpC+byfAzZ0C72VLWIGYlPnPCuOrd+QP1677uj5aazT0Ic4CnMqSr4Ta/aLluU 9dzxWhfP0kLOfVMd9KmHH5uwEaNo1AQBIH8ry647JKLXVpIk0umoYGdsDAWmfepRcC6J BGfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783607288; x=1784212088; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=92JJ36rrwvvb7yLlV9W9rV0xnJPT/KBmVXI1YNHLk7c=; b=Nv+pllb6eN96BNhpI5A2/pTx5km3Vc+QAZgSJ3JPe5l5WAZeQNbt+lR7QVIElnG9LS V734SIWY9KDtvGfojOqB8muyYsctGwAb3BucRT8SPvuoSKYI3Ocg/JpHaKJPOQbBueih CXmhjXFuaZ8ny38mRvdhlKWa06ti9FGg8Hbmi4GYSYmiwmRxPMLHfxCGZOy+x4/pCj57 jq9+lSGiq94kTg7nNqDE32x6bPP4S+MKHgd9WvUFfzt7ZZqyWxrmS59ZVNRwMtSvMLMV 3pjZ0LnElTu0FO3hxjvHIdVjMahBjRhLQwPw1zdr+0DuwXo862yUBcPl+wMtivWIYeZG cY3g== X-Forwarded-Encrypted: i=1; AHgh+RrbJCBZU516SjMNOhmvv+fWDcomLihMl6yKJEb6hCRJs3lgx4OauCC4iSbNOXYXGu2H10oy8Y6us5xBNOc=@vger.kernel.org X-Gm-Message-State: AOJu0YykhIDdoA0ygyxptw5IMY5rKLLPZZRcZfBtzdD+f3yMt9GXD3ew 6fy/C3eIYLfYNYhs2UXbHQUDW1Kf6rw7oHOSdECYahCkavLNll35e4uxiyIfNSxHF/I9bQw4E89 DK+x06rc4sQ0ndEhe7P1JHOyNauvxLZfWIGLTLFkp3sJZ/T7+fX1XkVuVJAPXNMJ6mw== X-Gm-Gg: AfdE7clSgy/INtX7G4gxwXY+LzKpLN2cOu83Iv/3+2a+83LSeU3VzX2EQ1lzz7zD1Rz eJwBB9m+X/gmpS1xlPYkamXFd4RASv6GDmT5XUCWwg2UXxTvAGL9Q0NiLjLaR+Dxg2U5IxzNnD2 KCpnjwHdUCVDCJJ7zU6K4Hr9cCphvXqYKGKbbDv86dv9XFyAQEJYm3/yRniHQ2BxBRtw4Tg9RYL cNAzR0zIAIEcdPYyyWiVOdD20Kyo0xEL9WJdsy3B2rh0QxsR4RjVhFc8yJxYFqmZJ6FBHU5g8iV 3OPyI81zEIq5Q1GoAhfdRX+y5KvgghWOzCrfWZvWxanJ08N52DV6GN86iVPGN9xKsLqloaS957v bHOrx8R/IuUV85fRADQruUWwwiUsAwguCtHdXLEpwUSxJFQ== X-Received: by 2002:ac8:7fc8:0:b0:51c:2068:a9f8 with SMTP id d75a77b69052e-51c8b399047mr79250331cf.5.1783607288354; Thu, 09 Jul 2026 07:28:08 -0700 (PDT) X-Received: by 2002:ac8:7fc8:0:b0:51c:2068:a9f8 with SMTP id d75a77b69052e-51c8b399047mr79249991cf.5.1783607287938; Thu, 09 Jul 2026 07:28:07 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51c41d2cde7sm173167731cf.18.2026.07.09.07.28.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 07:28:07 -0700 (PDT) Date: Thu, 9 Jul 2026 10:28:04 -0400 From: Brian Masney To: Louis-Alexis Eyraud Cc: Michael Turquette , Stephen Boyd , Matthias Brugger , AngeloGioacchino Del Regno , Chen-Yu Tsai , Edward-JW Yang , Johnson Wang , kernel@collabora.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2] clk: mediatek: pllfh: Fix IO remapping leak in register_pllfhs error path Message-ID: References: <20260709-clk-mediatek-pllfh-fix-v2-1-a235078fe9d5@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260709-clk-mediatek-pllfh-fix-v2-1-a235078fe9d5@collabora.com> User-Agent: Mutt/2.3.2 (2026-04-26) On Thu, Jul 09, 2026 at 02:23:00PM +0200, Louis-Alexis Eyraud wrote: > When mtk_clk_register_pllfhs function fails to register a PLL, it > unregisters all PLLs and cleans up itself in its error path before > returning, so the function callers don't need to do it. > > But contrary to mtk_clk_unregister_pllfhs function, that does almost > the same sequence, it does not free the IO memory mapped on fhctl node, > leading to a leak. > > Fix this leak by factorizing the cleanup sequence in a new private > function and use it both mtk_clk_register_pllfhs and > mtk_clk_unregister_pllfhs functions. > > Also, change the loop index start value to avoid the -1 operation on > index at each loop. > > Fixes: d7964de8a8ea ("clk: mediatek: Add new clock driver to handle FHCTL hardware") > Signed-off-by: Louis-Alexis Eyraud Reviewed-by: Brian Masney