From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52AD932E126 for ; Thu, 9 Jul 2026 14:24:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783607054; cv=none; b=u4TUz53tFIe5heYTGWwpIsP/NNWXpQkaMeSNgJIjsVb4Oww4IkGVJbyPcWBScSruueTyuVOIeDpdk/W6tXt8Fov5Kz2ZGn3o1kZkBN2eIr96v8uOjP7uHkO2pZSykUFHFA57Yeuk+bI8amlcDtuGomH/z1UkBsawshQNBhK3jso= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783607054; c=relaxed/simple; bh=H/58S8xtc3DqTmrpTgSLBSpHd4+F0iyFIRuxJ/sA9tU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=L7HFZkVErM84+NT38Nz6QUgqZK4VAfZl889RQY5rfZhhWIC+enJ/YP3dl+13ae7jU4G1gQ9tG48kgiqVr8n5DYNrvQPTdGaSeWu0B/1c4PkOaiCzGFSBJSibfLMyGa6SYUr6QmBqC2z4/blPx9iTg5OOHpe0nCoOnV7GlCnFVSg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AOlBpBoY; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=l1lnFmSl; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AOlBpBoY"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="l1lnFmSl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783607052; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Y1C0dXpz7AWQiPJGGV2R39/aRuB5qt1XtWGhBi3VmSQ=; b=AOlBpBoYq2V56FRdIt0PmA6U503odVxUbZTx8zQ6G7q7O+wVYyxZedU/ZJ+syxy197R4uP x3iiRGaaOGLezr7rULcXtVyL6xD3KHvnNf0LYldt7GcM/u+Jrp8Zvsu0Xf18BFuUd33SYt gMdbK9CA6kYwolmIeSwK9LzohnhODtQ= Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-381-Woo6fq7RM3yxmHgRzRHseQ-1; Thu, 09 Jul 2026 10:24:08 -0400 X-MC-Unique: Woo6fq7RM3yxmHgRzRHseQ-1 X-Mimecast-MFC-AGG-ID: Woo6fq7RM3yxmHgRzRHseQ_1783607048 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-7fec7afc9d1so28377477b3.1 for ; Thu, 09 Jul 2026 07:24:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783607048; x=1784211848; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=Y1C0dXpz7AWQiPJGGV2R39/aRuB5qt1XtWGhBi3VmSQ=; b=l1lnFmSlcVJoFL58ciwvQ9LbFDrRkeKNyVBgh0VSuEkVChR1iTI6HGnOMjw606MCQm i3atJaK+kTNsaELRvbMr+X/eNr+nxhrUIxRyl3qgOOAYI93pf4u6SnSYrR4bwiFGgEKu uPR0pf6cTQtDt5ys9ES4U9rIyIPTD6IvjXWLCHion4mLGhlxez5V/zWWHNgBiIdZH8e7 wQA7f+yKeMoESZ4Dgjv3BpUvCKa6jXG4x1hQIuu9wCA/MV1f/OKOEHqKO1rUfHMFT30o jFnlQoqpFDZHQOJlKPPZbddUnQ91eegTMV14+M6Z6bSLzfY9+j2yvQSDe3tbDBrwGWps r1sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783607048; x=1784211848; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Y1C0dXpz7AWQiPJGGV2R39/aRuB5qt1XtWGhBi3VmSQ=; b=Dy53YxWLhbeZv17k51CvqJPSnnRkMwXfA+uTKvIcgqvGOt2BZ+ZNoQaNRouLprBM+Y KSzUJ4lQ9PfeLZm5tTBZ+dkm3+iwyM5g7nZYpbeS608XMZ5n3lsNA6iwj5TnCkM5AIA+ cvDsBGSXEu5kbbKC35eGG7Xxx31nVzo8S8iuTOCqfOKeXtNblDQo3LicjBoutKsdhHgP h8c6H8D24JvVgOD2pmOzO/53PllUIXSeTTayAqGmG+WMGhhjIdP8jqLfT+yEdEoiwQ7g K6JK8xnofoIAlPB0qeze6SNS2DMEfDPw73dX3AjJvq+5s7hCafGIZJZlCoqOIUaiboIK 41TQ== X-Forwarded-Encrypted: i=1; AHgh+RquAaHOpy7k4aEDNVZrV6LByq4VEsMNTkwfeeNV1dwU8NoeWcMB0pA2iftKWJO9RCUxmKSxuui1RvQoeA0=@vger.kernel.org X-Gm-Message-State: AOJu0YyV3W2ANMXeUQBiABbKsruqGF623HMf2EI/8IGgrWc/ALyTTBLr nEWA9c5A1AjsxpSl8St5gUoipmsvXGKSTi1B8bXkgc4fW9X+6wEI/zonLK/HX+KssO/ruKKat45 lFfVdkvXCWFQhHbgULlKSqJQpm16b0dUFZw8nAj1dGospLXabUkmHQMzbSom9xGPf/w== X-Gm-Gg: AfdE7cmHJJ0bvwlXNx6KA84/V8y4Uc/+RmsQxsNXThTkw4coN1BoroXk0bAJSxPgOdo eB8Vn/t3DEiZMhIHZQXLjMvIy/dLjkLKXYU7HL3/EHvAlDbuIf25N1f3CzcCeoGuxj+H+LvjL1a Mc4huaiHjnBI4hZ3MOCnOmF9YlE9TKrbbFKqSLv0k5Kh2t9o469aOgMA3v8db0VXWfa1GTJwH4B tYVaqgr630WIBUr0olopwGLhtYgHv3fjsdxsKU8f2Ml8zpm6Gzv72BTODDeT0h20Bs4w2Cg34rU AXiuu4opiBlerDeYhqUZ6VBc9b4/UdixYAzKjlwmb7GMaKH77mGq++/lH/nWY0qGauzSuKT9IsN L10xx2pZe8aZ/NNN6QWV/MOBIy3DgJ0A2U6KWwadVs9xFXw== X-Received: by 2002:a05:690c:6c84:b0:81c:8300:f719 with SMTP id 00721157ae682-81dc0ce7f36mr61951637b3.56.1783607048246; Thu, 09 Jul 2026 07:24:08 -0700 (PDT) X-Received: by 2002:a05:690c:6c84:b0:81c:8300:f719 with SMTP id 00721157ae682-81dc0ce7f36mr61951307b3.56.1783607047696; Thu, 09 Jul 2026 07:24:07 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id 00721157ae682-81e6c1e1d12sm18995437b3.33.2026.07.09.07.24.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 07:24:06 -0700 (PDT) Date: Thu, 9 Jul 2026 10:24:02 -0400 From: Brian Masney To: Christian Marangi Cc: Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: en7523: reset PCIE HB on init for AN7581 Message-ID: References: <20260708084045.8380-1-ansuelsmth@gmail.com> <6a4fa6ab.b2781ae3.385c0f.d696@mx.google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6a4fa6ab.b2781ae3.385c0f.d696@mx.google.com> User-Agent: Mutt/2.3.2 (2026-04-26) On Thu, Jul 09, 2026 at 03:48:26PM +0200, Christian Marangi wrote: > On Wed, Jul 08, 2026 at 12:52:49PM -0400, Brian Masney wrote: > > Hi Christian, > > > > Thanks for the patch. > > > > On Wed, Jul 08, 2026 at 10:40:44AM +0200, Christian Marangi wrote: > > > It was reported that PCIE HB should be reset for AN7581 or some instability > > > or link training issue will be present on warm boot scenario. > > > > > > Reset PCIE HB on clk HW init to handle warm boot problem with PCIe. > > > > > > Signed-off-by: Christian Marangi > > > --- > > > drivers/clk/clk-en7523.c | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > > > > diff --git a/drivers/clk/clk-en7523.c b/drivers/clk/clk-en7523.c > > > index 1ab0e2eca5d3..c450d89bfa96 100644 > > > --- a/drivers/clk/clk-en7523.c > > > +++ b/drivers/clk/clk-en7523.c > > > @@ -57,6 +57,7 @@ > > > > > > #define REG_RST_CTRL2 0x830 > > > #define REG_RST_CTRL1 0x834 > > > +#define REG_PCIE_HB_RST BIT(29) > > > #define EN751221_REG_RST_DMT 0x84 > > > #define EN751221_REG_RST_USB 0xec > > > > > > @@ -853,6 +854,12 @@ static int en7581_clk_hw_init(struct platform_device *pdev, > > > val = readl(base + REG_NP_SCU_PCIC); > > > writel(val | 3, base + REG_NP_SCU_PCIC); > > > > > > + val = readl(base + REG_RST_CTRL1); > > > + val |= REG_PCIE_HB_RST; > > > + writel(val, base + REG_RST_CTRL1); > > > + val &= ~REG_PCIE_HB_RST; > > > + writel(val, base + REG_RST_CTRL1); > > > + > > > > Sashiko has a question about whether or not a delay or a flush is needed > > between the writel() calls? > > > > https://sashiko.dev/#/patchset/20260708084045.8380-1-ansuelsmth%40gmail.com > > > > Hi Brian, from the test done by me and Airoha with their CI on 10000 test, > no delay is needed. If we want to be on the save side I can add it anyway > for consistency with the other code. What do you think? 10,000 test is probably good enough then. Reviewed-by: Brian Masney