From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7832A392C25 for ; Tue, 7 Jul 2026 14:26:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783434365; cv=none; b=G1eTq+NfM79S9iyO4sCNW3hDPr2zi2dbkkNckPNbVAWUzCTAHEg+L98uy+gosn6a8Gd6HHUGuFkB7LWGKlRWYtc0ZnEd0mtAyhIw+YKyuGe2DC5rqAFU4yEa2LLritv7uX8leckaYL4kFMt6iHpIp4O/g8n0+lA3Au1p8e4rQQc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783434365; c=relaxed/simple; bh=xGf+twjfwFTEdiC1e/+J+01uu+OuSW6e7ZPWRm+BAG4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eu5cRLZe43j+oBJ0mnVdfdhARuD3kN56BOj8GFef/yYfbt94II13oh52BnVpE9hVLqxdNN5lH3YulRx4jZ9NQw6mY4B3njaDYvs+owC38cGKFcUAU718jLuXQKyT4vTNYwNVQapeGARBHG8/fi4IgfsgVrVj0JQhG9IyQCIFN9E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bxm5kR8G; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bxm5kR8G" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2cca24023edso30934035ad.1 for ; Tue, 07 Jul 2026 07:26:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783434360; x=1784039160; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Y0Xej5JFnQ1aHA2JgsyhmNNKCDzVPH/sjRZ+7VR4tcg=; b=bxm5kR8GItLnMBss/rV+9Q3amL7Zx+1l3EaEHjFqsdZsHHPoOgM/9YXKU26bW+Ixvu vxIJQ+zFSvkN6PQupcgh8QkiWZ2iwVQkvYD8+vYTiG3/N0OZJw2dTgLPP4oNSc2OEllI QtsTGxZqMiJ6lNSNf6cHkJefhD97YTKBXvDMXeB/daw5tuG2GM0NPWtzIOaRcy5zB1g8 PhqKlwNV4N6JBCgtYT9UiQfvAjz9952xspuHVQbvhe2GE00A1Bj+FCCDzhVTaLgRoynB r9xrose5QUgsECELUjhJH8kyJG33vFZLDF6VlF9qAvJu8HnkzUnjJndc+uvzDVGsmiL2 MekQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783434360; x=1784039160; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y0Xej5JFnQ1aHA2JgsyhmNNKCDzVPH/sjRZ+7VR4tcg=; b=GysaK9pPTcB4UpjBdSmfWHm1ecE9w/jaGFToAv5LRzX44ILuNnBmqYAMqvFtu+mI5A enK3xoXyl6cdP0eHlt8D51BnTa3aVAlb6R93vugI6XIeYZDBkhPHQDjJkgm87abNT6ZP G8T2HzHvLXJtn/jxK5l/WqpLxriIYwYMh4ukLB/Jnt+YbLYPd1si+Hk07JEwC8N7cH/I GcKBCCBnKV1/P9v2tIkQMuFiQKj5He1JB7bLIi9Xtowu/sFuAQN/8sBzeGymgwI4epZI sTG53zp2WL3xykq32zNLXXh0fyVMwJkMYJwzEB1sQSbEgwwq3qsqEj44CzT2HJ5U1mwL 331w== X-Forwarded-Encrypted: i=1; AHgh+RqbLdGYMy1HZ/L3GZ8RVw7KwSel+goq+aCt+/TElorrl47lUEHiGf3LbUaF95saY1NLDAf36x65m4KGTxo=@vger.kernel.org X-Gm-Message-State: AOJu0YxVNIYKD/G7etCDRMcpYexCZYe3k+o86CELogat8rNFa/x9ybXq Pd47ZTA6ZYnyPA36oXDWVP8BQVS/liwxqwxNrOvpp1d01i15ErT6UFRV X-Gm-Gg: AfdE7cmgENbAkHtWQJiWzeSNkSp9iRjeqBnf6rvCA9ag+mGsYDM2JhqQd5sykI+Zf8j LFlAXaO9qAiPwJy9XcryLxnDhGEmb8vuwDSJaCArupo7XkPw9Cs8scsf1umjAnbdlHqHVn3ICzT Y+NihUxI8GxNZw244cxgBpxg1JyC4GFrzq2POJK2CG7zKdKqTwynratVx+aFBuIipwEWON4758b d9jqX0BtcgL4aPQdssv5aL4EMKtXSmNrftsxzlszncSEHx3dATLUjDbr5UfZFoZeY2uBkqP+ELS yybaZMCLT0+HJvovkvwo6T0JRCl5W48gaO/PbGHwUpAerH+P9spIv3PvTrSujUX4Bd+yNc0SFai Ewde26cX4xcdleNopE7/+AXMIj2bF5xU3nyD8ePYiw4yy4+1u5jClbk+cEoKFeR9T5wTqUkql5X uMHrLlrAwY0w== X-Received: by 2002:a17:902:d58a:b0:2c9:d55d:2d3 with SMTP id d9443c01a7336-2ccbe615a18mr54950605ad.15.1783434359661; Tue, 07 Jul 2026 07:25:59 -0700 (PDT) Received: from john-p8 ([98.97.43.67]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9bdb9a3sm13105655ad.13.2026.07.07.07.25.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 07:25:58 -0700 (PDT) Date: Tue, 7 Jul 2026 07:25:56 -0700 From: John Fastabend To: Feng Yang Cc: andrii@kernel.org, eddyz87@gmail.com, ast@kernel.org, daniel@iogearbox.net, memxor@gmail.com, martin.lau@linux.dev, song@kernel.org, yonghong.song@linux.dev, jolsa@kernel.org, emil@etsalapatis.com, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf-next] selftests/bpf: Fix memory leak in msg_alloc_iov Message-ID: References: <20260707081434.539327-1-yangfeng59949@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260707081434.539327-1-yangfeng59949@163.com> On Tue, Jul 07, 2026 at 04:14:34PM +0800, Feng Yang wrote: >From: Feng Yang > >In the msg_alloc_iov function, the iov pointer is only assigned to >msg->msg_iov after all memory allocations complete successfully. >Therefore, when a calloc failure triggers the unwind_iov cleanup branch, >we should use the local variable iov instead of msg->msg_iov. > >Fixes: 753fb2ee0934 ("bpf: sockmap, add msg_peek tests to test_sockmap") >Signed-off-by: Feng Yang >--- > tools/testing/selftests/bpf/test_sockmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/tools/testing/selftests/bpf/test_sockmap.c b/tools/testing/selftests/bpf/test_sockmap.c >index 3e6be455d158..aaf2050e8845 100644 >--- a/tools/testing/selftests/bpf/test_sockmap.c >+++ b/tools/testing/selftests/bpf/test_sockmap.c >@@ -435,7 +435,7 @@ static int msg_alloc_iov(struct msghdr *msg, > return 0; > unwind_iov: > for (i--; i >= 0 ; i--) >- free(msg->msg_iov[i].iov_base); >+ free(iov[i].iov_base); > free(iov); > return -ENOMEM; Thanks, Reviewed-by: John Fastabend