From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 650A7305669 for ; Tue, 7 Jul 2026 14:47:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783435677; cv=none; b=Yj93X1GkEjYXfDkcyvD6rXajy1JRt+X/wQR5gwdYuhvR3yWVwkxxAU9Mr7NohsYP9i+84pmzzWQLPwG8oXNtIwynRKmZolwpB7KNyWFsle+FzAYEIAblkPxkSvYst6uPmmKZmkmsCItR13uhKxayHWYxze6dAFMQjI4eALntWhY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783435677; c=relaxed/simple; bh=+z+gxYFlPtHgHZIMkVwjSgyTxL0CHmGy1/FkcqoL/Zw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AY9hVcraJBbqy9TerTttFGhrcK4trsRt2gM6sNEr5BItgoDD7Sode1wih4VgvisNrCtvjDjNRhLO76nikN0gCClIAfZqL/rtJEQPLq0RManx7rMYSR7OjUCIHFTrJYswBw2xllais6IJRRVkfskVWSp8keJlRcHuET0+UxJJu60= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=RcFbVtNd; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=o/9bzYBE; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RcFbVtNd"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="o/9bzYBE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783435675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WrZMujM7glJ2AgSACwXIbeDVc0Wnvusn0xlE1OdCrOs=; b=RcFbVtNd31L+c/83HomQ2l/yMthSND8e7Mn80+fqzzFi1nDVAvVBZBdS0b+mJNJKGxTrtj OYWpOOOPgQuaAQAPlJ2i/l2gbB0IfpvBinFidB46K8Ey1NKK5aCU6l6Z+V99MjUslxotJa aI9PFPEFXFgXiI/IMUDcxtJwnirOcoc= Received: from mail-oi1-f197.google.com (mail-oi1-f197.google.com [209.85.167.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-15-JSvL5FA-NgKbUhPLZvRY0w-1; Tue, 07 Jul 2026 10:47:54 -0400 X-MC-Unique: JSvL5FA-NgKbUhPLZvRY0w-1 X-Mimecast-MFC-AGG-ID: JSvL5FA-NgKbUhPLZvRY0w_1783435674 Received: by mail-oi1-f197.google.com with SMTP id 5614622812f47-49f3a97f1caso1331820b6e.0 for ; Tue, 07 Jul 2026 07:47:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783435673; x=1784040473; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=WrZMujM7glJ2AgSACwXIbeDVc0Wnvusn0xlE1OdCrOs=; b=o/9bzYBEaPc96a2Regmzs/9JbGZck0snyi0SW7N3jqnXt6OpUVze14j77K3ysc9tKe qYsZwpiZ6LLvWZfWBFPUdyu9q6GKCmxJMQtP8A/sm2Lvozh4SqLi27bjujohIvcD2xrm 8AiN62vN/OK1dDqyeqQAu4K2ruEjsltpj6hAkRy7MqGD0E7AHPOyZvjRqDgcRgDp83N2 F/fEViZ9KNkB7J2mG2YZs9DzDvfGC1Pq723VJ4C/qqurM33TZ8/miYru4Ki8T+OWyn4T WK7ZNcAsLXeRf0fjQWGhVx3OYXh3XZMFh+nN59Q1zXVrzi/vdJaW8BQkawmeWyGpCI2P DCXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783435673; x=1784040473; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WrZMujM7glJ2AgSACwXIbeDVc0Wnvusn0xlE1OdCrOs=; b=Q/LN0ItgHVxmsVQk+lSn3wIHkFlAPHDYbh0byfhoLjsplGjicd2Cr9oBnnIZCkWTZ5 Hh9qG6+3NVQ42UgSO0BkHbkZAGyOCYfT1K4pSD6XtjsW7yq51bCN4cBlUxnwK3heX4iI ATQuQpwKYlc0i8nrg2zHe4G8cBj+i3XhFORAf/HfvTufrvVdOZ+fMnPtVXBR4a7qfG4B hsOrUURVolKvRInKWfjFrD3r0JCR2cA81b0d/w7LfEyXhQ+UaFt5lN1O2gjhNMvDglCe u2AV8tL4+eQvm4dJDXWDr39FYdXG6CeyJYZuQXfM1YkGvhYXn3hXlPZQR3lE2WL2mQ2D 82QQ== X-Forwarded-Encrypted: i=1; AFNElJ9szSnOgVHGK1XiTUROGZweJN32yM6q6RUrJ08cN7+N0NU5Qg8xJwAGrW6qJcMza+SSAXbYT8AckhhZBMY=@vger.kernel.org X-Gm-Message-State: AOJu0YwFcVGOiq/5eb9dMpZNvMuPdH150d8RV6uZBOG2/r8PeDTncRkd /9vhDTsM9sr2bl0dxtPBqY8myNTPcLrpa09uArE9y6CU/S0gM1ikMF6XNzOw2OvMDBEBwpqAV8e NvcJnSPWQSYV7jz87pN16wAxzUVSF4d91F6TtuapvsGX+zksUhjJ/w8lIotWI0qsqEw== X-Gm-Gg: AfdE7clbjEU6Drwymia4bFRaR7rImphi+MsIGrIhACVD6P3/vhhVcnOzuE8NRP4B42H lOlEZhe0/nLIgAZFekGD/FfdWMJXWPM+vhyBf2MoTqizI+tC0FM0UdglwXU/dHzZ0Muq1oH7nsY zZN+Ubh6zQetGgVKT6YmhkahfWBsiDP6Y4eSXT6edD8mv2RAe5WEN1P1nCyCf7EpF26eUCui3mF kigD6Wp4UYX5+zFYs8ET300pFatW3a/idRz5UVK5X8thKVlmh/IIn/GO3OAX8CnuoQIOnbSgBDG cLFP5a2LWBtYfeJirUFxcJZD3RWJ5htEHVv4O9LupG4YmESL9MRcG2AqgCFjG6YO/Qt+TB6tAhB /zD45mr67 X-Received: by 2002:a05:6820:818b:b0:6a1:87cb:c34e with SMTP id 006d021491bc7-6a3555125fdmr3682525eaf.72.1783435669913; Tue, 07 Jul 2026 07:47:49 -0700 (PDT) X-Received: by 2002:a05:6820:818b:b0:6a1:87cb:c34e with SMTP id 006d021491bc7-6a3555125fdmr3682515eaf.72.1783435669460; Tue, 07 Jul 2026 07:47:49 -0700 (PDT) Received: from redhat.com ([2600:382:850a:55b4:731e:b0d4:e0cc:410]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6a30ff8e0a0sm11018754eaf.3.2026.07.07.07.47.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 07:47:48 -0700 (PDT) Date: Tue, 7 Jul 2026 10:47:44 -0400 From: Brian Masney To: Akari Tsuyukusa Cc: Michael Turquette , Stephen Boyd , Matthias Brugger , AngeloGioacchino Del Regno , "open list:COMMON CLK FRAMEWORK" , "open list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , stable@vger.kernel.org, Chen-Yu Tsai , Miles Chen Subject: Re: [PATCH v2 3/6] clk: mediatek: mt7622: fix memory leak on module removal Message-ID: References: <20260707074839.240676-1-akkun11.open@gmail.com> <20260707074839.240676-4-akkun11.open@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260707074839.240676-4-akkun11.open@gmail.com> User-Agent: Mutt/2.3.2 (2026-04-26) On Tue, Jul 07, 2026 at 04:48:32PM +0900, Akari Tsuyukusa wrote: > clk-mt7622-apmixedsys.c and clk-mt7622-infracfg.c do not call > platform_set_drvdata() during their driver probe callback, > but their remove callback calls platform_get_drvdata(). > This results in platform_get_drvdata() returning NULL, > which leads to calling kfree(NULL) in mtk_free_clk_data(NULL). > This leaves clk_data unreleased, causing a memory leak. > > Fix this by calling platform_set_drvdata() during probe. > > Fixes: c50e2ea6507b ("clk: mediatek: mt7622-apmixedsys: Add .remove() callback for module build") > Fixes: 838b86331c5e ("clk: mediatek: mt7622: Move infracfg to clk-mt7622-infracfg.c") > Cc: stable@vger.kernel.org > Signed-off-by: Akari Tsuyukusa Reviewed-by: Brian Masney