From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010037.outbound.protection.outlook.com [52.101.46.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0335B41D4E7 for ; Tue, 7 Jul 2026 17:11:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.46.37 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783444262; cv=fail; b=ncNv0DnF+ho/6rALJez0bRJ4dMNYgkzZKsZouv09pVG/JmX2wAYVmL82mG/M8qKkKeyA0WM4XZZVn0aeciyxvv7njDSgNL4U6ca2Z3C4wbLx1EX/ihBKTKYEYZRQEy4+fIThOyjMItAbmmaAt734lKyyvlLyP4xx7Kn/Mq6Q+Bg= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783444262; c=relaxed/simple; bh=AqdTCdZjDJPr74OkumNSGn5hmLipIMdFZd4f5qtiPDs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bAhpewHFtT/C6J/8bGQD9Qwcnav26m0i5OJbzr9e4ej1WUIPK5LHV2TwbsJiRMd6LVNRRB6JlEsUUi71vKIMlwz4H8SUDF4mZHlrLfU/Q5ZfbubwksjElA/KRrfszICjAnRxYAo4g1TwHeLwC3P3bDu75mGAtfz50drwXK0lyOo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gehealthcare.com; spf=pass smtp.mailfrom=gehealthcare.com; dkim=pass (2048-bit key) header.d=gehealthcare.com header.i=@gehealthcare.com header.b=NdOE730W; arc=fail smtp.client-ip=52.101.46.37 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gehealthcare.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gehealthcare.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gehealthcare.com header.i=@gehealthcare.com header.b="NdOE730W" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dwgAN5D4LldtaVq6H65r+Stqoz7vQm3bDi/HdBewMAFG6V8l1fl3Vdr1X0Eu/sU6KNCBC5w7WZMAxcv1fgK32eKzdId0otgQgmuHRRPQ3qBfsCkE58ZRv2SngTGkohM7nWXQLdZgMQhvzkavvxn6UWHZtjBPozxJTey+rKMWYVJAvOW+WfHf3ja+q9LrWUmyMyhDmvELgca69LXk2m57TCXH4s61NoDA823ttuIX2ztYPl8gTAGc5boMqRFs/lysvLJVdef2I6mlROfL5m+S508/VJToIOxq6YSCqW5n5FDKQyjpcSc0wkzui/gPOrvC8u1cmgOvnZWAwJ75anmEtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zuFjPVWZ0S7I/NhN5L7l+kiIF5nNZ0lY3SyapqM/CP8=; b=TSVagGysUivdMoROSoSEpT/PM2SHUQV0qq4s5hcVYw2J8sUPMpZ3YzU8RZYzj747ipcjwH6unRN13lCnwMhjBx+/znsh3QwGr6vaqWUzgaMUHNTytgKm/Y3bw6NLmG23hY5Ge9tHvvSp6CYL6aw5ovMKx2u0HYDs1H/pEc1j40kpLapfI4Xljxf91W4sUc7L0C8lXTkjKrYQMTX/+IMaV5iCZroMuRUPx4CHNb+eMCyHfooBX1IPCoIc4Ys3szqK9kN6MUDjMEnKCzuBylYuS4PdkUowpuIB1DxGszKsh0zveHp+9fGSqhCPXPgtF7JWpUwkhJT6tqYGQeoaxoBVIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 165.85.157.49) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=gehealthcare.com; dmarc=fail (p=quarantine sp=quarantine pct=100) action=quarantine header.from=gehealthcare.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gehealthcare.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zuFjPVWZ0S7I/NhN5L7l+kiIF5nNZ0lY3SyapqM/CP8=; b=NdOE730WWNw230mNaeX2acYO91Izd4CzYbGgt0+vyw6z7ZpQtdJuazfaeBT5kd8XWpI54nByvX1HiDaHszqzE/fuIapxhd9E2VXOii0MWbfWe5r6dC/037IczrwaAgI20gZHVaQVxi9Qay5m4UjnB4ZqPivl/UE6ZzzpmpWYATgju2es5gRtR40ROOE5YczBlU+XChLPMv002SegQwpFWMxemijMOI5lJ/YcxKdBuAk59E1HtcvCwYaoE/Schut3rKuxhLuxiIMh2DtEll5SXR19xt0ZM0rqy4vkaSoRcKK9hVApHC1sdoWput0gAW1v4ILPOzsprl6RuMfoXbMqrw== Received: from CH2PR14CA0002.namprd14.prod.outlook.com (2603:10b6:610:60::12) by BY1PR22MB5631.namprd22.prod.outlook.com (2603:10b6:a03:4b4::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.8; Tue, 7 Jul 2026 17:10:58 +0000 Received: from CH1PEPF0000A347.namprd04.prod.outlook.com (2603:10b6:610:60:cafe::a0) by CH2PR14CA0002.outlook.office365.com (2603:10b6:610:60::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.159.19 via Frontend Transport; Tue, 7 Jul 2026 17:10:58 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 165.85.157.49) smtp.mailfrom=gehealthcare.com; dkim=none (message not signed) header.d=none;dmarc=fail action=quarantine header.from=gehealthcare.com; Received-SPF: Fail (protection.outlook.com: domain of gehealthcare.com does not designate 165.85.157.49 as permitted sender) receiver=protection.outlook.com; client-ip=165.85.157.49; helo=atlrelay1.compute.ge-healthcare.net; Received: from atlrelay1.compute.ge-healthcare.net (165.85.157.49) by CH1PEPF0000A347.mail.protection.outlook.com (10.167.244.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.6 via Frontend Transport; Tue, 7 Jul 2026 17:10:58 +0000 Received: from zeus (zoo13.fihel.lab.ge-healthcare.net [10.168.174.111]) by builder1.fihel.lab.ge-healthcare.net (Postfix) with ESMTP id 1D72D1290D; Tue, 7 Jul 2026 20:10:56 +0300 (EEST) Date: Tue, 7 Jul 2026 20:10:55 +0300 From: Ian Ray To: Greg Kroah-Hartman Cc: oe-linux-nfc@lists.linux.dev, linux-kernel@vger.kernel.org, Griffin Kroah-Hartman , David Heidelberg , Carl Lee , Jakub Kicinski , Krzysztof Kozlowski , Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= Subject: Re: [PATCH] nfc: nxp-nci: Add remove on IRQ error Message-ID: References: <2026070726-observer-fang-9716@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2026070726-observer-fang-9716@gregkh> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A347:EE_|BY1PR22MB5631:EE_ X-MS-Office365-Filtering-Correlation-Id: 21105ba4-5d5c-4e1a-4b41-08dedc4ab6cd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|36860700016|376014|1800799024|82310400026|56012099006|11063799006|18002099003|22082099003|5023799004; X-Microsoft-Antispam-Message-Info: tCxKACxLlva/LOoXmS/Xnc07eJx3JvrK4tFsdsU88TKtbAD1cb7jpgfX2TwBNWtRCuruPXBp744nyxAXNyq0pVs3NcZv+fWuJy34DiBeBGGTT+BmgWxqIXPccT4yiunOsZvP1Zbq3PpwHID/r+dg9EOfIvPb83AXKSzsU5utcPXn34eKAcLDoZYg1AYBcJpj9gwnIRCd0ZcQ0eyUZVk2iKBVPk6/jqTIJ7VSIAqK6Q8R7UUWlKssGD+N1k7wl9k+C3RZiCuomCLfD/yjGDPUhzzXcfm705K8PXJyK/xm1+b503IE4ISSDd84ao0DDyggSHUuYgVtcjZnJq/5N5/DMLrbVKSmMEtDXGIpwKTaq3E3vaOE5+C+Z+rH529OCqg9qVJ2T0XcH0Vok2atOGGEiI+TUrTVcgFs+q9nwtY/auyoUmEn+DZtJpRJjhXRoo5ZcYeaeMMIyfGrYFQEUvO4NOn47dfjRjVoEWy9eowtdu8pTYiXEUX8tWsCBfkMbk8SrBgCSzfe04HLhZcT2jp8ZaHzU2MOVGpEE1N5eaygWRq1ARMYo+JXtFie1kiVeNWBGAFI0AyEY8XtBlyDMwr9b98UGpM8i7Jsa0FrKaJE6vaKCPwaKnoaVKmiVHJDNnHEEmTM47OEs/aSfuIPJ/ViYAIIgUmIt1yDEHX7O4rHz2cnFKAxqf/7wzzOZWjN4AvscxP8lbFUd7WqMm9P22qF5w== X-Forefront-Antispam-Report: CIP:165.85.157.49;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:atlrelay1.compute.ge-healthcare.net;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(23010399003)(36860700016)(376014)(1800799024)(82310400026)(56012099006)(11063799006)(18002099003)(22082099003)(5023799004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ljz/XfzIGT0sgoZl4tRONzYQksg4WzOhgYh1h3WmQzHTGUE+Ik7rxhSV+kGXehmwG4NI6gzALi+yvFXBISYaDdlD8slzPl20T4g/ymw2VDK+AM30ZxYgE0LnwTOQtyCXm5/npm63k3Qm1PF6i1tmw0ABK4AAdgFxlTlxIw522CxS2I4kj3uJ4kbDyb6HEV3LGWGK420JQkDNDU6NWMDdB8t7NwU78xBX4y/gLVDCpmfxSur7BTiqx/33JZyx6r61lHRyDk36cU2+p4efyjPMHdtza3uLmgRrsgLrmv+i0Zc3z/b7wxDBl/5FBhsDvSjbJob0rNDqfNbGgQsD60xejHrSGef71X82bm+KdDd5ccNz19f15hY/GH6vh/s4CIjEsDEa++XUdPtpMi6eALwtj9ZadW1Iu9IZQItZ3zV9L2thShPKEECt6QDlip+Ge2zX X-OriginatorOrg: gehealthcare.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2026 17:10:58.4159 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 21105ba4-5d5c-4e1a-4b41-08dedc4ab6cd X-MS-Exchange-CrossTenant-Id: 9a309606-d6ec-4188-a28a-298812b4bbbf X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=9a309606-d6ec-4188-a28a-298812b4bbbf;Ip=[165.85.157.49];Helo=[atlrelay1.compute.ge-healthcare.net] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-CH1PEPF0000A347.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR22MB5631 On Tue, Jul 07, 2026 at 04:23:27PM +0200, Greg Kroah-Hartman wrote: > From: Griffin Kroah-Hartman > > Add a call to nxp_nci_remove() in nxp_nci_i2c_probe() when the > request_threaded_irq() fails. > Previously, IRQ resources were not being freed upon error. > > Assisted-by: gkh_clanker_2000 > Cc: David Heidelberg > Cc: Carl Lee > Cc: Jakub Kicinski > Cc: Krzysztof Kozlowski > Cc: Ian Ray > Cc: "Uwe Kleine-König (The Capable Hub)" > Signed-off-by: Griffin Kroah-Hartman > Signed-off-by: Greg Kroah-Hartman Nice improvement! Reviewed-by: Ian Ray > --- > drivers/nfc/nxp-nci/i2c.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/nfc/nxp-nci/i2c.c b/drivers/nfc/nxp-nci/i2c.c > index faebc89a7ef5..564f38735510 100644 > --- a/drivers/nfc/nxp-nci/i2c.c > +++ b/drivers/nfc/nxp-nci/i2c.c > @@ -334,8 +334,10 @@ static int nxp_nci_i2c_probe(struct i2c_client *client) > nxp_nci_i2c_irq_thread_fn, > irqflags | IRQF_ONESHOT, > NXP_NCI_I2C_DRIVER_NAME, phy); > - if (r < 0) > + if (r < 0) { > nfc_err(&client->dev, "Unable to register IRQ handler\n"); > + nxp_nci_remove(phy->ndev); > + } > > return r; > } > -- > 2.55.0 >